Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037703Openbravo ERP09. Financial managementpublic2018-01-23 10:202018-02-22 18:18
Reporterdmiguelez 
Assigned ToTriage Omni OMS 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037703: Refactor TestCosting class to make it more manageable.
DescriptionRefactor TestCosting class to make it more manageable.

This class has become too big to manage, refactor it to make it easier to maintain.
Steps To ReproduceRefactor TestCosting class to make it more manageable.

This class has become too big to manage, refactor it to make it easier to maintain.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-23 10:20dmiguelezNew Issue
2018-01-23 10:20dmiguelezAssigned To => Triage Finance
2018-01-23 10:20dmiguelezOBNetwork customer => No
2018-01-23 10:20dmiguelezModules => Core
2018-01-23 10:20dmiguelezTriggers an Emergency Pack => No
2018-01-23 10:22hgbotCheckin
2018-01-23 10:22hgbotNote Added: 0101885
2018-01-23 10:22hgbotStatusnew => resolved
2018-01-23 10:22hgbotResolutionopen => fixed
2018-01-23 10:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ed116cab029986758076af3858c25b86803bede [^]
2018-01-23 10:24dmiguelezNote Added: 0101887
2018-01-23 10:25dmiguelezReview Assigned To => dmiguelez
2018-01-23 10:25dmiguelezNote Added: 0101888
2018-01-23 10:25dmiguelezStatusresolved => closed
2018-01-23 10:25dmiguelezFixed in Version => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102681

Notes
(0101885)
hgbot   
2018-01-23 10:22   
Repository: erp/devel/pi
Changeset: 7ed116cab029986758076af3858c25b86803bede
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Jan 22 17:05:50 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7ed116cab029986758076af3858c25b86803bede [^]

Fixes Issue 37703. Refactors TestCosting class

* Assert Classes were placed in a new package
* Constants were moved to a new class
* TestCostingUtils now contains all the API to create tests
* New test classes were created containig the tests
* TestCosting class was converted into a suite running all test classes

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
A src-test/src/org/openbravo/test/costing/TestCostingBase.java
A src-test/src/org/openbravo/test/costing/TestCostingLandedCost.java
A src-test/src/org/openbravo/test/costing/TestCostingNoSourceAdjustments.java
A src-test/src/org/openbravo/test/costing/TestCostingSourceAdjustments.java
A src-test/src/org/openbravo/test/costing/TestIssue37033.java
A src-test/src/org/openbravo/test/costing/TestIssue37279.java
A src-test/src/org/openbravo/test/costing/assertclass/CostAdjustmentAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/DocumentPostAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/LandedCostCostMatchedAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/LandedCostReceiptLineAmountAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/MatchedInvoicesAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/OrderToReceiptResult.java
A src-test/src/org/openbravo/test/costing/assertclass/PhysicalInventoryAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/ProductCostingAssert.java
A src-test/src/org/openbravo/test/costing/assertclass/ProductTransactionAssert.java
A src-test/src/org/openbravo/test/costing/utils/TestCostingConstants.java
A src-test/src/org/openbravo/test/costing/utils/TestCostingUtils.java
R src-test/src/org/openbravo/test/costing/TestCostingUtils.java
---
(0101887)
dmiguelez   
2018-01-23 10:24   
Test Plan:

Lanch TestCosting suite and check that everything is ok
(0101888)
dmiguelez   
2018-01-23 10:25   
Code Review + Testing Ok
(0102681)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test