0037699: Connection leak if the Validate Store Server process is executed from the ERP using more than one thread

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0037699

Retail Modules

StoreServer

public

2018-01-22 16:24

2018-10-17 09:52

Reporter

AugustoMauch

Assigned To

AugustoMauch

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0037699: Connection leak if the Validate Store Server process is executed from the ERP using more than one thread

Description

The validate store server can be executed:
- Using the validate.store.data ant task (it is possible to specify the number of threads to use for the validation)
- From the ERP, executing the Background Store Data validator process (1 thread is used for the validation)

The current way of cleaning the database connections after the validation would leak connections if invoked from the ERP using more than 1 threads.

Even though now that combination is not possible, the way the connections are closed should be improved to prevent leaks in the future.

Steps To Reproduce

- Change this line [1], set the number of threads to use to 4
- Open the Process Request window
- Schedule the Background Store Data validator process to be executed immediately
- Check that some connections have been leaked

[1] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/tip/src/org/openbravo/replication/symmetricds/process/BackgroundStoreDataValidator.java#l86 [^]

Proposed Solution

Additional Information