Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037688Retail ModulesWeb POSpublic2018-01-19 11:102018-01-24 14:13
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037688: Remove unneeded receipt save which causes performance problems
DescriptionAfter every change in the receipt, calculateReceipt is executed. Inside this function, we do a save of the order in the local database.

All the interactions with the local database must be avoided because the performance get affected.

We need to remove all saves of the receipt done before doing calculateReceipt because they are not needed and make performance to be bad.
Steps To ReproduceSee Desc.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0037690RR18Q1 closed migueldejuana Remove unneeded receipt save which causes performance problems 
depends on backport 0037691RR17Q4.1 closed migueldejuana Remove unneeded receipt save which causes performance problems 
depends on backport 0037692RR17Q3.3 closed migueldejuana Remove unneeded receipt save which causes performance problems 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-19 11:10migueldejuanaNew Issue
2018-01-19 11:10migueldejuanaAssigned To => migueldejuana
2018-01-19 11:10migueldejuanaOBNetwork customer => No
2018-01-19 11:10migueldejuanaTriggers an Emergency Pack => No
2018-01-19 11:12hgbotCheckin
2018-01-19 11:12hgbotNote Added: 0101778
2018-01-19 11:12hgbotStatusnew => resolved
2018-01-19 11:12hgbotResolutionopen => fixed
2018-01-19 11:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b6d3bbc589ba8c79d86245b6f067364b87040ffe [^]
2018-01-19 12:02jorgewederagoIssue Monitored: jorgewederago
2018-01-19 12:15marvintmNote Added: 0101785
2018-01-19 12:15marvintmNote Added: 0101786
2018-01-19 12:17marvintmReview Assigned To => marvintm
2018-01-19 12:17marvintmStatusresolved => closed
2018-01-19 12:17marvintmFixed in Version => RR18Q2
2018-01-19 12:17marvintmStatusclosed => new
2018-01-19 12:17marvintmResolutionfixed => open
2018-01-19 12:17marvintmFixed in VersionRR18Q2 =>
2018-01-19 12:18marvintmStatusnew => scheduled
2018-01-19 12:18marvintmStatusscheduled => resolved
2018-01-19 12:18marvintmFixed in Version => RR18Q2
2018-01-19 12:18marvintmResolutionopen => fixed
2018-01-19 12:18marvintmStatusresolved => closed
2018-01-23 11:47hgbotCheckin
2018-01-23 11:47hgbotNote Added: 0101900
2018-01-23 11:47hgbotStatusclosed => resolved
2018-01-23 11:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b6d3bbc589ba8c79d86245b6f067364b87040ffe [^] => http://code.openbravo.com/retail/backports/3.0RR17Q3.3/org.openbravo.retail.posterminal/rev/b3f034cd8aefcd826dd352363a3bb63c03b90596 [^]
2018-01-24 14:13marvintmStatusresolved => closed

Notes
(0101778)
hgbot   
2018-01-19 11:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b6d3bbc589ba8c79d86245b6f067364b87040ffe
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jan 19 11:11:45 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b6d3bbc589ba8c79d86245b6f067364b87040ffe [^]

Fixed issue 0037688: Remove unneeded receipt save which causes performance problems

- Remove unneeded receipt save to improve performance

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0101785)
marvintm   
2018-01-19 12:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8687c3aebeb893002b171d0f696ae540358ca0ff
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jan 19 12:08:50 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8687c3aebeb893002b171d0f696ae540358ca0ff [^] [^]

Fixed issue 0036893: If WebPOS is on Payment Tab it should not be possible to add products

-Mantain the check for corner case when a line is added while the order is be send to backend. Remove from rfid buffers the line because it is not added

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0101786)
marvintm   
2018-01-19 12:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d61149f258b8f73a8abda9dd265720369aeefba7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jan 19 12:13:01 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d61149f258b8f73a8abda9dd265720369aeefba7 [^] [^]

Fixed issue 0036893: If WebPOS is on Payment Tab it should not be possible to add products

- if isCalculateReceiptLocked is TRUE we must log the problem and remove from rfid buffers the product

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0101900)
hgbot   
2018-01-23 11:47   
Repository: retail/backports/3.0RR17Q3.3/org.openbravo.retail.posterminal
Changeset: b3f034cd8aefcd826dd352363a3bb63c03b90596
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jan 23 11:47:12 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.3/org.openbravo.retail.posterminal/rev/b3f034cd8aefcd826dd352363a3bb63c03b90596 [^]

Fixed issue 0037688: Remove unneeded receipt save which causes performance problems

- Remove unneeded receipt save to improve performance
-Mantain the check for corner case when a line is added while the order is be send to backend. Remove from rfid buffers the line because it is not added

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---