0037674: The cancellation of the OBPOS_PreOrderSave hook is not correctly handled in Pay Open Tickets

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0037674

Retail Modules

Web POS

public

2017-12-05 16:20

2018-01-25 11:26

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR18Q1

Fixed in Version

RR18Q1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0037674: The cancellation of the OBPOS_PreOrderSave hook is not correctly handled in Pay Open Tickets

Description

The cancellation of the OBPOS_PreOrderSave hook is not handled correctly in Pay Open Tickets. Depending on which ticket cancels the hook, it might leave the previous tickets saved in websql with the hasbeenpaid attribute to 'Y', but not synchronized, making it impossible to update them afterwards.
This can lead to cashup differences if the payments change between synchronization retries (because the "locked" ticket won't be updated).

Steps To Reproduce

Login in web pos.
Create two tickets in draft and add products to both of them.
Go to the Menu > Pay Open Tickets and select the tickets created in the first step.
Open the browser console and execute the following:
OB.MobileApp.model.attributes.permissions["OBMOBC_SynchronizedMode"] = true
OB.FAILCONDITION = true
OB.FAILDOCNO = the_documentNo_of_the_second_ticket
OB.UTIL.HookManager.registerHook('OBPOS_PreOrderSave', function(a,b){
  if(OB.FAILCONDITION && a.receipt.get('documentNo') === OB.FAILDOCNO){
    OB.MobileApp.model.hideSynchronizingDialog();
    a.cancellation = true;
  }
  OB.UTIL.HookManager.callbackExecutor(a,b);
})

Add a full payment in Card and click on Done. The process will stop because of the hook.
Remove the Card payment.
Add a full payment in Voucher.
Execute the following in the browser console:
OB.FAILCONDITION = false;

Click on the Done button again. This time the hook will not cancel the execution and the tickets will be synchronized, although the following error will appear in the console:
[checkBlocked][no-transaction][hasbeenpaid_is_yes] Wrong write in c_order avoided.

Load both tickets again in WebPOS:
The first ticket will be paid with Card (although the card payment was completely removed).
The second ticket will be paid with Voucher.

Proposed Solution

Additional Information