Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037673Retail ModulesGift cards and gift voucherspublic2018-01-18 17:352018-11-16 12:59
Reporterkchoperena 
Assigned Tokchoperena 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037673: [SERQA 3684]: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note
Description- Register OBPOS_PrePaymentSelected hook
- Add config preference GCNV_ForbidAnonymousCustomerUseCreditNote
- Add config preference GCNV_ForbidUseCreditNoteForDifferentCustomer
- Add logic to forbid make the payment or the return of the receipt using Credit note related to an anonymous customer
- Add logic to forbid make the payment or the return of the receipt using Credit note related to a customer different from the registered on the ticket
Steps To Reproduce1.- Log into the WebPOS
2.- In the menu, select 'Verified Returns' option
3.- Select a receipt related to an anonymous customer
4.- Select the credit note payment method to do the return

Proposed SolutionExpected:
5.- A popup will be shown with an information message:
'It is not allowed to create a Credit Note for an anonymous customer. Please, change the customer or the payment method'
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue37673.diff (13,829) 2018-08-07 12:37
https://issues.openbravo.com/file_download.php?file_id=12034&type=bug
diff AnonymousCustomerLimitationsFinalTests.diff (37,822) 2018-08-07 12:38
https://issues.openbravo.com/file_download.php?file_id=12035&type=bug
diff issue37673_POSTerminal.diff (1,516) 2018-08-07 13:33
https://issues.openbravo.com/file_download.php?file_id=12036&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-01-18 17:35kchoperenaNew Issue
2018-01-18 17:35kchoperenaAssigned To => Retail
2018-01-18 17:35kchoperenaFile Added: forbidAnonymousCustomerGiftCardCreationGiftCards.diff
2018-01-18 17:35kchoperenaTriggers an Emergency Pack => No
2018-01-18 17:36kchoperenaResolution time => 1516575600
2018-01-23 13:57ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-23 14:35ranjith_qualiantech_comStatusnew => scheduled
2018-01-23 16:13ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => kchoperena
2018-01-25 10:04kchoperenaSummary[SERQA 3684]: Forbid that the Anonymous Customer creates a credit note in verified returns => [SERQA 3684]: Forbid that the Anonymous Customer creates a credit note
2018-01-25 10:04kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=16586#r16586
2018-01-25 13:28kchoperenaSummary[SERQA 3684]: Forbid that the Anonymous Customer creates a credit note => [SERQA 3684]: Forbid that the Anonymous Customer use a credit note
2018-01-25 13:48kchoperenaSummary[SERQA 3684]: Forbid that the Anonymous Customer use a credit note => [SERQA 3684]: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note
2018-01-25 13:48kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=16587#r16587
2018-01-25 16:30hgbotCheckin
2018-01-25 16:30hgbotNote Added: 0101950
2018-01-25 16:30hgbotStatusscheduled => resolved
2018-01-25 16:30hgbotResolutionopen => fixed
2018-01-25 16:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/5b506aa23c67f77754d50b191f226642de3f62e3 [^]
2018-01-25 18:15hgbotCheckin
2018-01-25 18:15hgbotNote Added: 0101977
2018-03-08 16:28kchoperenaStatusresolved => new
2018-03-08 16:39kchoperenaNote Added: 0103094
2018-07-27 08:33guillermogilFile Deleted: forbidAnonymousCustomerGiftCardCreationGiftCards.diff
2018-07-27 08:33guillermogilFile Added: forbidAnonymousCustomerGiftCardCreationGiftCards.diff
2018-08-07 12:37kchoperenaFile Deleted: forbidAnonymousCustomerGiftCardCreationGiftCards.diff
2018-08-07 12:37kchoperenaFile Added: issue37673.diff
2018-08-07 12:38kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=17499#r17499
2018-08-07 12:38kchoperenaFile Added: AnonymousCustomerLimitationsFinalTests.diff
2018-08-07 13:33kchoperenaFile Added: issue37673_POSTerminal.diff
2018-08-07 14:38hgbotCheckin
2018-08-07 14:38hgbotNote Added: 0106173
2018-08-07 14:39hgbotCheckin
2018-08-07 14:39hgbotNote Added: 0106174
2018-08-08 13:16hgbotCheckin
2018-08-08 13:16hgbotNote Added: 0106241
2018-08-08 13:16hgbotStatusnew => resolved
2018-08-08 13:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/5b506aa23c67f77754d50b191f226642de3f62e3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/3730767daa869db7663fdb68ade8b030fe089288 [^]
2018-08-09 08:31hgbotCheckin
2018-08-09 08:31hgbotNote Added: 0106248
2018-08-10 13:21hgbotCheckin
2018-08-10 13:21hgbotNote Added: 0106282
2018-08-10 14:50hgbotCheckin
2018-08-10 14:50hgbotNote Added: 0106286
2018-08-11 12:23hgbotCheckin
2018-08-11 12:23hgbotNote Added: 0106302
2018-08-11 12:23hgbotCheckin
2018-08-11 12:23hgbotNote Added: 0106303
2018-08-17 13:33marvintmReview Assigned To => marvintm
2018-08-17 13:33marvintmStatusresolved => closed
2018-08-17 13:33marvintmFixed in Version => RR18Q4
2018-11-16 12:59psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17928#r17928
2018-11-16 12:59psanjuanProposed Solution updated

Notes
(0101950)
hgbot   
2018-01-25 16:30   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 5b506aa23c67f77754d50b191f226642de3f62e3
Author: Kepa Choperena <kepa.choperena <at> openbravo.com>
Date: Thu Jan 25 13:49:11 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/5b506aa23c67f77754d50b191f226642de3f62e3 [^]

Fixed issue 37673: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
A web/org.openbravo.retail.giftcards/js/hooks/afterPaymentSelectedHook.js
---
(0101977)
hgbot   
2018-01-25 18:15   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1b58d411b187ccc12a6a587ca6b9dd3b052dd56f
Author: Kepa Choperena <kepa.choperena <at> openbravo.com>
Date: Thu Jan 25 18:15:29 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1b58d411b187ccc12a6a587ca6b9dd3b052dd56f [^]

Related to issue 37673: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note.

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0103094)
kchoperena   
2018-03-08 16:39   
Backout reason -> Moved to 18Q3 release
(0106173)
hgbot   
2018-08-07 14:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8fd21ed4c30937c32944c1f0de5b468e11e73dcd
Author: Kepa Choperena <kepa.choperena <at> openbravo.com>
Date: Tue Aug 07 14:38:46 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8fd21ed4c30937c32944c1f0de5b468e11e73dcd [^]

Related to issue 37673: Added OBPOS_PrePaymentSelected hook

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0106174)
hgbot   
2018-08-07 14:39   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 57e889c7cdbed1570c048b9d6238d302aa71e049
Author: Kepa Choperena <kepa.choperena <at> openbravo.com>
Date: Tue Aug 07 14:14:33 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/57e889c7cdbed1570c048b9d6238d302aa71e049 [^]

Related to issue 37673: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note.
Added new development

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
A web/org.openbravo.retail.giftcards/js/hooks/afterPaymentSelectedHook.js
A web/org.openbravo.retail.giftcards/js/hooks/preOrderSaveHook.js
---
(0106241)
hgbot   
2018-08-08 13:16   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 3730767daa869db7663fdb68ade8b030fe089288
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Aug 08 13:16:00 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/3730767daa869db7663fdb68ade8b030fe089288 [^]

Fixed issue 37673: Fixed dbconsistency on AD_Message

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0106248)
hgbot   
2018-08-09 08:31   
Repository: tools/automation/pi-mobile
Changeset: 1165afd694bb4643eccbd67944d5a00731c0b544
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 09 08:31:22 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1165afd694bb4643eccbd67944d5a00731c0b544 [^]

Related to issue 37673: [SERQA 3684]: Forbid that the Anonymous Customer and a customer different from the registered on the ticket use a credit note
New tests for issue checking

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreateCreditNoteWithAnonymous.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNote.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNoteInPayOpenTickets.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomer.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomerInPayOpenTickets.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37470_ChangeProfile.java
---
(0106282)
hgbot   
2018-08-10 13:21   
Repository: tools/automation/pi-mobile
Changeset: 3f0c70d69954a552178af546f5b82920456ba3b1
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Aug 10 11:15:29 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3f0c70d69954a552178af546f5b82920456ba3b1 [^]

Related to issue 37673: Added test cases for Anonymous Credit Notes

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0106286)
hgbot   
2018-08-10 14:50   
Repository: tools/automation/pi-mobile
Changeset: 80bfdabba1b65d8aef27e23b331a27e1d550ff4f
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Aug 10 14:50:10 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/80bfdabba1b65d8aef27e23b331a27e1d550ff4f [^]

Related to issue 37673: Added test cases for Anonymous Credit Notes

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreateCreditNoteWithAnonymous.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNote.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNoteInPayOpenTickets.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomer.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomerInPayOpenTickets.java
---
(0106302)
hgbot   
2018-08-11 12:23   
Repository: tools/automation/pi-mobile
Changeset: 64bee1d4ea7640b155b18c1334ccd205919b4d45
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Aug 10 18:48:11 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/64bee1d4ea7640b155b18c1334ccd205919b4d45 [^]

Related to issue 37673: Added test cases for Anonymous Credit Notes

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreateCreditNoteWithAnonymous.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNote.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/ForbidCustomerDifferentAssignedTicketUseCreditNoteInPayOpenTickets.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomer.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/UseCreditNoteWithAnonymousCustomerInPayOpenTickets.java
---
(0106303)
hgbot   
2018-08-11 12:23   
Repository: tools/automation/pi-mobile
Changeset: 7896cf5dd883be093684339c972c4d2eab7944c7
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Aug 10 18:56:39 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7896cf5dd883be093684339c972c4d2eab7944c7 [^]

Related to issue 37673: Added test cases for Anonymous Credit Notes

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/CreateCreditNoteWithAnonymous.java
---