Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037646Retail ModulesWeb POSpublic2018-01-15 18:532018-01-24 14:24
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q4.1Fixed in VersionRR17Q4.1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037646: LogClient should not be sent if session is not valid
DescriptionCurrently logclient is always sent, even if the WebPOS already detected that session is no longer valid, and that the user must log in again. This wastes network bandwidth, which can in some cases be problematic.

Instead, the process should not be run if the session is not valid, and should only be restarted when the user logs in again.
Steps To Reproduce- Log in the WebPOS, with the "Network" tab in developer tools open.
- Restart tomcat (to force session lost)
- Wait some time.
- At some point, the WebPOS detects that the session is lost, and shows the popup that explains the user that he needs to log in again.
- Wait more time. Check the "Network" tab, and realize that the log client request is still triggered periodically. This doesn't make sense, as it wastes bandwidth without any chance of succeeding.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037644 closed marvintm LogClient should not be sent if session is not valid 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-15 18:53marvintmTypedefect => backport
2018-01-15 18:53marvintmTarget Version => RR17Q4.1
2018-01-22 11:19marvintmAssigned ToRetail => marvintm
2018-01-22 13:53hgbotCheckin
2018-01-22 13:53hgbotNote Added: 0101841
2018-01-22 13:53hgbotStatusscheduled => resolved
2018-01-22 13:53hgbotResolutionopen => fixed
2018-01-22 13:53hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.mobile.core/rev/f87bcc98aa2af5adfcf17d26bd74e71dabec740e [^]
2018-01-24 14:24migueldejuanaReview Assigned To => migueldejuana
2018-01-24 14:24migueldejuanaNote Added: 0101923
2018-01-24 14:24migueldejuanaStatusresolved => closed
2018-01-24 14:24migueldejuanaFixed in Version => RR17Q4.1

Notes
(0101841)
hgbot   
2018-01-22 13:53   
Repository: retail/backports/3.0RR17Q4.1/org.openbravo.mobile.core
Changeset: f87bcc98aa2af5adfcf17d26bd74e71dabec740e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jan 22 13:52:24 2018 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q4.1/org.openbravo.mobile.core/rev/f87bcc98aa2af5adfcf17d26bd74e71dabec740e [^]

Fixed issue 37646. LogClient request will no longer happen if session was lost. Added API to enable/disable log client process, with two main goals:
-Disable the interval when session is lost, to remove unnecessary overhead
-Try to prevent potential duplicate calls to the log client process

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
---
(0101923)
migueldejuana   
2018-01-24 14:24   
Tested and reviewed