Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037644Retail ModulesWeb POSpublic2018-01-15 18:532018-01-16 12:04
marvintm 
marvintm 
urgentmajoralways
closedfixed 
5
 
 
migueldejuana
No
0037644: LogClient should not be sent if session is not valid
Currently logclient is always sent, even if the WebPOS already detected that session is no longer valid, and that the user must log in again. This wastes network bandwidth, which can in some cases be problematic.

Instead, the process should not be run if the session is not valid, and should only be restarted when the user logs in again.
- Log in the WebPOS, with the "Network" tab in developer tools open.
- Restart tomcat (to force session lost)
- Wait some time.
- At some point, the WebPOS detects that the session is lost, and shows the popup that explains the user that he needs to log in again.
- Wait more time. Check the "Network" tab, and realize that the log client request is still triggered periodically. This doesn't make sense, as it wastes bandwidth without any chance of succeeding.
Performance
depends on backport 0037645RR18Q1 closed marvintm LogClient should not be sent if session is not valid 
depends on backport 0037646RR17Q4.1 closed marvintm LogClient should not be sent if session is not valid 
depends on backport 0037647RR17Q3.3 closed marvintm LogClient should not be sent if session is not valid 
Issue History
2018-01-15 18:53marvintmNew Issue
2018-01-15 18:53marvintmAssigned To => Retail
2018-01-15 18:53marvintmTriggers an Emergency Pack => No
2018-01-15 18:53marvintmStatusnew => scheduled
2018-01-15 18:53marvintmAssigned ToRetail => marvintm
2018-01-16 08:31hgbotCheckin
2018-01-16 08:31hgbotNote Added: 0101712
2018-01-16 08:31hgbotStatusscheduled => resolved
2018-01-16 08:31hgbotResolutionopen => fixed
2018-01-16 08:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d32c1f1c4bcfd8b52c5e640627fb0d1381c57edf [^]
2018-01-16 08:33marvintmResolution time => 1517180400
2018-01-16 10:27shuehnerTag Attached: Performance
2018-01-16 10:27shuehnerIssue Monitored: shuehner
2018-01-16 12:01hgbotCheckin
2018-01-16 12:01hgbotNote Added: 0101717
2018-01-16 12:04migueldejuanaReview Assigned To => migueldejuana
2018-01-16 12:04migueldejuanaNote Added: 0101718
2018-01-16 12:04migueldejuanaStatusresolved => closed

Notes
(0101712)
hgbot   
2018-01-16 08:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d32c1f1c4bcfd8b52c5e640627fb0d1381c57edf
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jan 15 18:56:46 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d32c1f1c4bcfd8b52c5e640627fb0d1381c57edf [^]

Fixed issue 37644. LogClient request will no longer happen if session was lost.

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
---
(0101717)
hgbot   
2018-01-16 12:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4d5709f5f93d359f30cbfe978d3b726ed7c36502
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jan 16 11:58:35 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4d5709f5f93d359f30cbfe978d3b726ed7c36502 [^]

Related to issue 37644. Added API to enable/disable log client process, with two main goals:
-Disable the interval when session is lost, to remove unnecessary overhead
-Try to prevent potential duplicate calls to the log client process

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/logClientSyncUtils.js
---
(0101718)
migueldejuana   
2018-01-16 12:04   
Tested and reviewed