Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0037640 | Openbravo ERP | 02. Master data management | public | 2018-01-15 17:28 | 2018-02-22 18:18 |
|
| Reporter | samuel_nicuesa | |
| Assigned To | AtulOpenbravo | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | 3.0PR18Q2 | |
| Merge Request Status | |
| Review Assigned To | dmiguelez |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | 50491 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0037640: Trying to separate discounts using different organizations that are not in the same branch DOES NOT separate these discounts |
| Description | Trying to separate discounts using different organizations that are not in the same branch DOES NOT separate these discounts. (Using "Discounts and Promotions" window).
All these discounts appear for all the users when they should be separated. |
| Steps To Reproduce | Log in into ERP as Openbravo/openbravo
Using the The White Valley Group Admin Role go to "Discounts and Promotions" window.
Create a new record and set the following data:
Organization: Vall Blanca Store
Discount/Promotion Type *: Fixed Percentage Discount
Name: Test 50%
Printed Name: Test 50%
Starting date: 01-01-2018
Included Products: Only those defined
Discount: 50.
Save.
Go to Products tab.
Create a new record.
Product: Alpine poles
Active: Enabled.
Save.
---
Then go to Sales Order window and create one record :
Organization: Central Mountains Store.
Business Partner: Arturo Montoro.
Save.
Go to lines tab.
Create a new record.
Product: Alpine Poles.
Save.
---
Choose the sales order created and press Book button.
Go back to the lines tab and you will see that the discount created using Vall Blanca Store has been applied.
This should not happens because central mountain's organization is "Central Mountains Store" and "Vall Blanca Store" is in other branch. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | defect | 0027862 | | closed | dmiguelez | Trying to separate discounts using different organizations that are not in the same branch DOES NOT separate these discounts. RR |
|
| Attached Files |  patch27862.patch (767) 2018-01-15 17:28
https://issues.openbravo.com/file_download.php?file_id=11460&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-01-15 17:28 | samuel_nicuesa | New Issue | |
| 2018-01-15 17:28 | samuel_nicuesa | Assigned To | => Triage Finance |
| 2018-01-15 17:28 | samuel_nicuesa | File Added: patch27862.patch | |
| 2018-01-15 17:28 | samuel_nicuesa | OBNetwork customer | => Yes |
| 2018-01-15 17:28 | samuel_nicuesa | Modules | => Core |
| 2018-01-15 17:28 | samuel_nicuesa | Support ticket | => 50491 |
| 2018-01-15 17:28 | samuel_nicuesa | Resolution time | => 1517785200 |
| 2018-01-15 17:28 | samuel_nicuesa | Triggers an Emergency Pack | => No |
| 2018-01-15 17:29 | samuel_nicuesa | Relationship added | depends on 0027862 |
| 2018-01-15 17:35 | samuel_nicuesa | Note Added: 0101707 | |
| 2018-01-15 17:53 | dmiguelez | Assigned To | Triage Finance => AtulOpenbravo |
| 2018-01-16 06:38 | AtulOpenbravo | Status | new => scheduled |
| 2018-01-17 03:48 | AtulOpenbravo | Note Added: 0101736 | |
| 2018-01-18 11:36 | hgbot | Checkin | |
| 2018-01-18 11:36 | hgbot | Note Added: 0101767 | |
| 2018-01-18 11:36 | hgbot | Status | scheduled => resolved |
| 2018-01-18 11:36 | hgbot | Resolution | open => fixed |
| 2018-01-18 11:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7f73f128fec8ab03189bcdda3d1392c0ee152370 [^] |
| 2018-01-18 11:48 | hgbot | Checkin | |
| 2018-01-18 11:48 | hgbot | Note Added: 0101768 | |
| 2018-01-18 11:49 | dmiguelez | Review Assigned To | => dmiguelez |
| 2018-01-18 11:49 | dmiguelez | Note Added: 0101769 | |
| 2018-01-18 11:49 | dmiguelez | Status | resolved => closed |
| 2018-01-18 11:49 | dmiguelez | Fixed in Version | => 3.0PR18Q2 |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102664 | |
| 2018-02-22 18:18 | hudsonbot | Checkin | |
| 2018-02-22 18:18 | hudsonbot | Note Added: 0102665 | |
|
Notes |
|
|
|
We have seen that in WEB POS the discounts are being applied properly.
In the ERP the Discount lookup is not taking into account the organization tree. A proposed solution was attached (patch27862). |
|
|
|
|
- Login as F&B International Group Admin
- Navigate to Discount and Promotion window
- Create a new record
- Organization: F&B España - Región Norte
- Discount/Promotion Type: Price Adjustment
- Name: Discount 50%
- Starting Date: 01-01-2018
- Included Products: Only those defined
- Discount %: 50
- Rest all the fields default value
- Save record.
- Navigate to Product Tab
- Add record for product Vino Blanco 0,75L
- Create a new record in Discount and Promotion
- Organization: F&B España, S.A
- Discount/Promotion Type: Price Adjustment
- Name: Discount 20%
- Starting Date: 01-01-2018
- Included Products: Only those defined
- Discount %: 20
- Rest all the fields default value
- Save record.
- Navigate to Product Tab
- Add record for product Vino Rosado 0,75L
- Navigate to Sales Order window.
- Create a new record for any business partner in organization "F&B España - Región Sur"
- Add line for product Vino Blanco 0,75L Quantity = 1000
- Realize that Net Unit Price = Net List Price = 5.33 (No discount and promotion is applied)
- Add another line for product Vino Rosado 0,75L, Quantity = 1000
- Realize that Net Unit Price = 4.50, Net List Price = 5.63 (20% discount and promotion is applied)
- Book the order and realize that price set in both steps remains same and are correct.
- Repeat same steps to create Sales Invoice.
- Create a new record for any business partner in organization "F&B España - Región Norte"
- Add line for product Vino Blanco 0,75L Quantity = 1000
- Realize that Net Unit Price =2.67, Net List Price = 5.33 (50% discount and promotion is applied)
- Add another line for product Vino Rosado 0,75L, Quantity = 1000
- Realize that Net Unit Price = 4.50, Net List Price = 5.63 (20% discount and promotion is applied)
- Book the order and realize that price set in both steps remains same and are correct.
- Repeat same steps to create Sales Invoice.
- Create a new record for any business partner in organization "F&B España, S.A"
- Add line for product Vino Blanco 0,75L Quantity = 1000
- Realize that Net Unit Price =5.33, Net List Price = 5.33 (No discount and promotion is applied)
- Add another line for product Vino Rosado 0,75L, Quantity = 1000
- Realize that Net Unit Price = 4.50, Net List Price = 5.63 (20% discount and promotion is applied)
- Book the order and realize that price set in both steps remains same and are correct.
- Repeat same steps to create Sales Invoice. |
|
|
|
(0101767)
|
|
hgbot
|
|
2018-01-18 11:36
|
|
Repository: erp/devel/pi
Changeset: 7f73f128fec8ab03189bcdda3d1392c0ee152370
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 16 12:50:55 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7f73f128fec8ab03189bcdda3d1392c0ee152370 [^]
Fixes Issue 37640: Trying to separate discounts using different
organizations that are not in the same branch DOES NOT separate
these discounts
** Apply offers (discount and promotion) to the lines whose order
organization is in organization tree of the offer organization.
---
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
---
|
|
|
|
(0101768)
|
|
hgbot
|
|
2018-01-18 11:48
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|