Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037629Retail ModulesWeb POSpublic2018-01-12 12:542018-03-26 09:54
Reportermrecasens 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-05-03
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/graph/257d231e2ba8 [^]
Triggers an Emergency PackNo
Summary0037629: "Verified return" menu option not present when none of the terminal's Terminal Type payment methods are counted in cash up.
DescriptionPayment methods not counted in cash up is a condition, amongst two others, to have a Terminal for Sellers terminal but the rest of the conditions are not being met:

* The Layaway Orders field must be checked.
   => Not true: it is unchecked by default.
* The Pos Terminal Type may only contain payment methods that are not counted in the Cash Up process.
   => True, we change this and experience the issue
* The roles that are accessing to these terminals should have the Web POS action Receipt this Layaway property set to 'N'.
   => Not true: it is set to 'Y' by default.


You would expect to have payment methods defined in the terminal type not counted in the cashup (e.g. Credit Notes), and still be able to use verified returns functionality.

cf. http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Terminal_for_Seller [^]
Steps To Reproduce1. Open a terminal
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^] [you may need to unlink and link again the terminal]
=> See that in the menu, option "Verified Returns" is present
2. Open Openbravo backoffice
3. Go to POS Terminal Type and select "VBS POS Terminal Type"
4. Open "Payment Method" tab
5. Uncheck "Count Payment in Cash Up" for all 4 payment methods present [you may need to activate "Automatic Deposit" for Payment Method 'Check' in Payment Method window]
6. Open again the same terminal
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]
=> See that in the menu, option "Verified Returns" is not present anymore. Note that the rest of the menu options that should disappear in a Terminal for Sellers terminal are not present either: Open Drawer, Cash Up, Cash Up Partial, Cash Management.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0037760RR18Q1 closed rqueralta "Verified return" menu option not present when none of the terminal's Terminal Type payment methods are counted in cash up. 
depends on backport 0037761RR17Q4.2 closed rqueralta "Verified return" menu option not present when none of the terminal's Terminal Type payment methods are counted in cash up. 
related to defect 0037776 closed ranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-12 12:54mrecasensNew Issue
2018-01-12 12:54mrecasensAssigned To => Retail
2018-01-12 12:54mrecasensResolution time => 1484780400
2018-01-12 12:54mrecasensTriggers an Emergency Pack => No
2018-01-12 13:00mrecasensSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16527#r16527
2018-01-12 14:20mrecasensDescription Updatedbug_revision_view_page.php?rev_id=16529#r16529
2018-01-15 09:14marvintmResolution time1484780400 => 1516921200
2018-01-17 15:12rqueraltaAssigned ToRetail => rqueralta
2018-01-17 15:12rqueraltaStatusnew => scheduled
2018-01-19 15:13hgbotCheckin
2018-01-19 15:13hgbotNote Added: 0101804
2018-01-19 15:13hgbotStatusscheduled => resolved
2018-01-19 15:13hgbotResolutionopen => fixed
2018-01-19 15:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/f17771dc4a378d983de8607b6507109c63b7f142 [^]
2018-01-19 23:24hgbotCheckin
2018-01-19 23:24hgbotNote Added: 0101809
2018-01-22 17:06hgbotCheckin
2018-01-22 17:06hgbotNote Added: 0101857
2018-01-25 11:36egoitzIssue Monitored: egoitz
2018-01-25 11:36egoitzIssue Monitored: malsasua
2018-01-25 12:41marvintmReview Assigned To => marvintm
2018-01-25 12:41marvintmNote Added: 0101940
2018-01-25 12:41marvintmStatusresolved => closed
2018-01-25 12:41marvintmFixed in Version => RR18Q2
2018-01-30 09:57marvintmStatusclosed => new
2018-01-30 09:57marvintmResolutionfixed => open
2018-01-30 09:57marvintmFixed in VersionRR18Q2 =>
2018-01-30 09:57marvintmStatusnew => scheduled
2018-01-30 09:57marvintmStatusscheduled => resolved
2018-01-30 09:57marvintmFixed in Version => RR18Q2
2018-01-30 09:57marvintmResolutionopen => fixed
2018-01-30 10:03marvintmStatusresolved => closed
2018-01-30 18:03marvintmRelationship addedrelated to 0037776
2018-02-16 17:15hgbotCheckin
2018-02-16 17:15hgbotNote Added: 0102470
2018-03-26 09:54marvintmRegression level => Production - Confirmed Stable
2018-03-26 09:54marvintmRegression date => 2017-05-03
2018-03-26 09:54marvintmRegression introduced in release => RR17Q3
2018-03-26 09:54marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/graph/257d231e2ba8 [^]

Notes
(0101804)
hgbot   
2018-01-19 15:13   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: f17771dc4a378d983de8607b6507109c63b7f142
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Thu Jan 18 15:43:07 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/f17771dc4a378d983de8607b6507109c63b7f142 [^]

Fixed issue 37629: "Verified return" menu option not present when none of the
terminal's Terminal Type payment methods are counted in cash up.

---
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0101809)
hgbot   
2018-01-19 23:24   
Repository: tools/automation/pi-mobile
Changeset: 044c3db5049130144d605debd0592f6bf2968409
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Jan 19 17:24:22 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/044c3db5049130144d605debd0592f6bf2968409 [^]

Verifies issue 37629: "Verified return" menu option not present when none of the
terminal's Terminal Type payment methods are counted in cash up.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I37629_VerifiedReturnMenuNotPresentWhenNonePaymentMethodsAreCountedInCashUp.java
---
(0101857)
hgbot   
2018-01-22 17:06   
Repository: tools/automation/pi-mobile
Changeset: 1bf19a0adbe8bd03042c8b8ae8caeaedeaca6315
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Jan 22 11:05:39 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1bf19a0adbe8bd03042c8b8ae8caeaedeaca6315 [^]

Related to issue 37629: "Verified return" menu option not present when none of the
terminal's Terminal Type payment methods are counted in cash up.

Backed out changeset: 044c3db50491

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I37629_VerifiedReturnMenuNotPresentWhenNonePaymentMethodsAreCountedInCashUp.java
---
(0101940)
marvintm   
2018-01-25 12:41   
Fix is correct, test will be added later.
(0102470)
hgbot   
2018-02-16 17:15   
Repository: tools/automation/pi-mobile
Changeset: df1394c05376f67b9aad6b4b6918682facf6298f
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Feb 15 17:36:54 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/df1394c05376f67b9aad6b4b6918682facf6298f [^]

Verifies issue 37629: Added automated test
"I37629_VerifiedReturnMenuNotPresentWhenNonePaymentMethodsAreCountedInCashUp"

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I37629_VerifiedReturnMenuNotPresentWhenNonePaymentMethodsAreCountedInCashUp.java
---