Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037616Retail ModulesLoyalty Management for Retailpublic2018-01-11 10:212018-01-22 11:27
Reporterguillermogil 
Assigned Toguillermogil 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037616: Since 17Q3 Loyalty is not working
DescriptionSince 17Q3 Loyalty is not working, and login in the WebPOS is not possible when it is installed and there is data defined in the models.
Steps To ReproduceInstall loyalty, and configure a Loyalty Program.
Try to login in the Web POS. Notice that an error appears.
Proposed SolutionSimpleQueryBuilder classes which implement masterdata models should be changed to ProcessHQLQuery, which implement proper paging, offset definition, and error control.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-11 10:21guillermogilNew Issue
2018-01-11 10:21guillermogilAssigned To => Retail
2018-01-11 10:21guillermogilTriggers an Emergency Pack => No
2018-01-11 10:24hgbotCheckin
2018-01-11 10:24hgbotNote Added: 0101664
2018-01-11 10:24hgbotStatusnew => resolved
2018-01-11 10:24hgbotResolutionopen => fixed
2018-01-11 10:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/e39d21b6b8eec6e65bd8542b3aeca1d683b0a4e9 [^]
2018-01-11 14:10hgbotCheckin
2018-01-11 14:10hgbotNote Added: 0101666
2018-01-11 19:48marvintmAssigned ToRetail => guillermogil
2018-01-11 19:57marvintmDescription Updatedbug_revision_view_page.php?rev_id=16523#r16523
2018-01-11 19:57marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16525#r16525
2018-01-11 19:57marvintmProposed Solution updated
2018-01-11 19:58marvintmResolution time => 1516402800
2018-01-12 12:47hgbotCheckin
2018-01-12 12:47hgbotNote Added: 0101678
2018-01-19 16:12hgbotCheckin
2018-01-19 16:12hgbotNote Added: 0101808
2018-01-22 11:27jorge-garciaReview Assigned To => jorge-garcia
2018-01-22 11:27jorge-garciaNote Added: 0101826
2018-01-22 11:27jorge-garciaStatusresolved => closed
2018-01-22 11:27jorge-garciaFixed in Version => RR18Q2
2018-01-22 11:43jorge-garciaNote Edited: 0101826bug_revision_view_page.php?bugnote_id=0101826#r16570

Notes
(0101664)
hgbot   
2018-01-11 10:24   
Repository: erp/pmods/org.openbravo.retail.loyalty
Changeset: e39d21b6b8eec6e65bd8542b3aeca1d683b0a4e9
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu Jan 11 10:23:17 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/e39d21b6b8eec6e65bd8542b3aeca1d683b0a4e9 [^]

Fixed issue 37616: Modified MastarData process to ProcessHQLQuery

Using JSONProcessSimple was generating errors on login due to a sanity check on POS

---
M src/org/openbravo/retail/loyalty/master/AccumulationRules.java
M src/org/openbravo/retail/loyalty/master/LoyaltyManagement.java
M src/org/openbravo/retail/loyalty/master/LoyaltyProgram.java
M src/org/openbravo/retail/loyalty/master/RedemptionRules.java
---
(0101666)
hgbot   
2018-01-11 14:10   
Repository: erp/pmods/org.openbravo.retail.loyalty
Changeset: 34f3896ebd008792f08683105a0020003f5d65cf
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Thu Jan 11 14:10:45 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/34f3896ebd008792f08683105a0020003f5d65cf [^]

Related to issue 37616: Implemented ParentList Logic

---
M src/org/openbravo/retail/loyalty/master/AccumulationRules.java
M src/org/openbravo/retail/loyalty/master/LoyaltyManagement.java
M src/org/openbravo/retail/loyalty/master/LoyaltyProgram.java
M src/org/openbravo/retail/loyalty/master/RedemptionRules.java
---
(0101678)
hgbot   
2018-01-12 12:47   
Repository: erp/pmods/org.openbravo.retail.loyalty
Changeset: 6d966756f41901169eea31be78a2e0d01f30bcf8
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Fri Jan 12 12:47:49 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/6d966756f41901169eea31be78a2e0d01f30bcf8 [^]

Related to issue 37616: Added active filters

---
M src/org/openbravo/retail/loyalty/master/AccumulationRules.java
M src/org/openbravo/retail/loyalty/master/LoyaltyManagement.java
M src/org/openbravo/retail/loyalty/master/LoyaltyProgram.java
M src/org/openbravo/retail/loyalty/master/RedemptionRules.java
---
(0101808)
hgbot   
2018-01-19 16:12   
Repository: erp/pmods/org.openbravo.retail.loyalty
Changeset: 56daaba72422bc17172dee4d1c84a86a71d8bd07
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jan 19 16:12:29 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty/rev/56daaba72422bc17172dee4d1c84a86a71d8bd07 [^]

Related to issue 37616. Properly implement masterdata refresh criteria

---
M src/org/openbravo/retail/loyalty/master/AccumulationRules.java
M src/org/openbravo/retail/loyalty/master/AccumulationRulesProperties.java
M src/org/openbravo/retail/loyalty/master/LoyaltyManagement.java
M src/org/openbravo/retail/loyalty/master/LoyaltyManagementProperties.java
M src/org/openbravo/retail/loyalty/master/LoyaltyProgram.java
M src/org/openbravo/retail/loyalty/master/LoyaltyProgramProperties.java
M src/org/openbravo/retail/loyalty/master/RedemptionRules.java
M src/org/openbravo/retail/loyalty/master/RedemptionRulesProperties.java
---
(0101826)
jorge-garcia   
2018-01-22 11:27   
(edited on: 2018-01-22 11:43)
Reviewed and tested