Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037547Retail ModulesWeb POSpublic2017-12-26 13:182018-02-16 17:15
Reportermalsasua 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket49703
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037547: Cashup invoice is not including the layaways, but it is including the canceled layaways
DescriptionWhen a layaway is created, and it is not paid totally, the layaway is not included in the invoice created by cashup.
If you cancel the layaway (using "cancel layaway" or "cancel & replace" functionality) the layaway that it is cancelling the original layaway is included in the invoice of cashup, but the original layaway is not included in it.
Steps To ReproducePOS:
. do a cashup (so we start with a clean cashup)
. create a new layaway - L1 (total 100 - paid 20)
. do a cashup

BO:
. no invoice is created in the cashup. L1 is not invoiced

POS:
. load previous layaway L1
. execute "cancel layaway" functionality > L2 is created with amount -100 (total paid -20)
. do a cashup

BO:
. invoice is created with total amount -100, and L2 is related with the invoice, but L1 never is invoiced
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0037694RR18Q1 closed rqueralta Cashup invoice is not including the layaways, but it is including the canceled layaways 
depends on backport 0037695RR17Q4.1 closed rqueralta Cashup invoice is not including the layaways, but it is including the canceled layaways 
depends on backport 0037696RR17Q3.3 closed rqueralta Cashup invoice is not including the layaways, but it is including the canceled layaways 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-26 13:18malsasuaNew Issue
2017-12-26 13:18malsasuaAssigned To => Retail
2017-12-26 13:18malsasuaOBNetwork customer => Yes
2017-12-26 13:18malsasuaSupport ticket => 49703
2017-12-26 13:18malsasuaResolution time => 1515884400
2017-12-26 13:18malsasuaTriggers an Emergency Pack => No
2017-12-26 18:12PracticsIssue Monitored: Practics
2018-01-03 21:53rqueraltaAssigned ToRetail => rqueralta
2018-01-03 21:53rqueraltaStatusnew => scheduled
2018-01-15 04:37hgbotCheckin
2018-01-15 04:37hgbotNote Added: 0101686
2018-01-15 04:37hgbotStatusscheduled => resolved
2018-01-15 04:37hgbotResolutionopen => fixed
2018-01-15 04:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/824c1b0ddcba362a1dafb01aa8e9f7420a2d2913 [^]
2018-01-15 09:34marvintmNote Added: 0101687
2018-01-15 09:34marvintmStatusresolved => new
2018-01-15 09:34marvintmResolutionfixed => open
2018-01-15 09:35marvintmStatusnew => scheduled
2018-01-15 17:36hgbotCheckin
2018-01-15 17:36hgbotNote Added: 0101708
2018-01-16 20:37hgbotCheckin
2018-01-16 20:37hgbotNote Added: 0101731
2018-01-16 20:38rqueraltaStatusscheduled => resolved
2018-01-16 20:38rqueraltaResolutionopen => fixed
2018-01-18 18:49marvintmReview Assigned To => marvintm
2018-01-18 18:49marvintmStatusresolved => closed
2018-01-18 18:49marvintmFixed in Version => RR18Q2
2018-01-22 11:28marvintmStatusclosed => new
2018-01-22 11:28marvintmResolutionfixed => open
2018-01-22 11:28marvintmFixed in VersionRR18Q2 =>
2018-01-22 11:28marvintmStatusnew => scheduled
2018-01-22 11:28marvintmStatusscheduled => resolved
2018-01-22 11:28marvintmFixed in Version => RR18Q2
2018-01-22 11:28marvintmResolutionopen => fixed
2018-01-22 11:28marvintmStatusresolved => closed
2018-02-16 17:15hgbotCheckin
2018-02-16 17:15hgbotNote Added: 0102469

Notes
(0101686)
hgbot   
2018-01-15 04:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 824c1b0ddcba362a1dafb01aa8e9f7420a2d2913
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Sat Jan 13 23:40:52 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/824c1b0ddcba362a1dafb01aa8e9f7420a2d2913 [^]

Fixed issue 37547: Cashup invoice is not including the layaways, but it is
including the canceled layaways

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0101687)
marvintm   
2018-01-15 09:34   
The fix is not correct. Instead, the only thing that is needed is to set the cashupId properly in the original layaway if it is different from the cancelling layaway, so that the cashup process takes both of them into account.
(0101708)
hgbot   
2018-01-15 17:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2ea70517ede6239eb46102db3650687c4b537a7a
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Jan 15 11:33:54 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2ea70517ede6239eb46102db3650687c4b537a7a [^]

Related to issue 37547: Cashup invoice is not including the layaways, but it is
including the canceled layaways

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
---
(0101731)
hgbot   
2018-01-16 20:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fea83e2f893f4bc1a1905d6dcad67d317c9c0f8b
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Jan 15 16:25:11 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fea83e2f893f4bc1a1905d6dcad67d317c9c0f8b [^]

Related to issue 37547: Cashup invoice is not including the layaways, but it is
including the canceled layaways

---
M src/org/openbravo/retail/posterminal/CancelLayawayLoader.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0102469)
hgbot   
2018-02-16 17:15   
Repository: tools/automation/pi-mobile
Changeset: ab37a2b36d17b0988edb657d1412a3f95b83a2da
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Feb 15 17:35:15 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ab37a2b36d17b0988edb657d1412a3f95b83a2da [^]

Verifies issue 37547: Added automated test "I37547_CashupInvoiceIsNotIncludingTheLayaways"

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I37547_CashupInvoiceIsNotIncludingTheLayaways.java
---