Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037542Retail ModulesWeb POSpublic2017-12-21 16:402018-01-19 08:51
ReporterSandrahuguet 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037542: Is impossible to update a customer in hgvol environment
DescriptionIs impossible to update a customer in hgvol environment.
The problem is that a wrong remote BPLocation request is done, and it takes a lot of time and fails with timeout.

Wrong remotefilter in BPLocation request example (value is missing):
{columns: ["bpartner"], operator: "=", isId: true}

Correct example:
{columns: ["bpartner"], operator: "=", value: "ABD91C9D3BC94175B876FBBE9CACA008", isId: true}


test failing in hgvol jobs:
http://ci.openbravo.com/view/retail/job/ret-higvol-pgsql/1093/testReport/org.openbravo.test.mobile.retail.pack.selenium.tests.layaway/I35248_VerifyUpdateCustomerOnLayaway/test/ [^]
Steps To ReproduceIn a hgvol environment
-Enable all high volumes preference
-Log in the WebPOS
-Tap on customer name
-Tap on the 3 dots at right in one customer and tap on edit
-Tap on save button
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0036515 closed migueldejuana Improve BusinessPartner query performance removing location info from it 
related to backport 0037662 closed ranjith_qualiantech_com I36641_VerifyReceiptAddressOnCustomerUpdate is not stable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-21 16:40SandrahuguetNew Issue
2017-12-21 16:40SandrahuguetAssigned To => Retail
2017-12-21 16:40SandrahuguetResolution time => 1516230000
2017-12-21 16:40SandrahuguetTriggers an Emergency Pack => No
2017-12-21 16:46hgbotCheckin
2017-12-21 16:46hgbotNote Added: 0101188
2017-12-21 16:46SandrahuguetNote Added: 0101189
2018-01-04 13:31ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-04 14:46ranjith_qualiantech_comRelationship addedrelated to 0036515
2018-01-05 12:55ranjith_qualiantech_comStatusnew => scheduled
2018-01-05 13:50hgbotCheckin
2018-01-05 13:50hgbotNote Added: 0101595
2018-01-05 13:50hgbotStatusscheduled => resolved
2018-01-05 13:50hgbotResolutionopen => fixed
2018-01-05 13:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f178b75af5ce4ccfea4b9051a05d1dc7dc140827 [^]
2018-01-05 13:50hgbotCheckin
2018-01-05 13:50hgbotNote Added: 0101596
2018-01-08 10:59shuehnerTag Attached: Performance
2018-01-09 09:45SandrahuguetNote Added: 0101629
2018-01-09 09:45SandrahuguetStatusresolved => new
2018-01-09 09:45SandrahuguetResolutionfixed => open
2018-01-09 09:46hgbotCheckin
2018-01-09 09:46hgbotNote Added: 0101630
2018-01-09 09:47SandrahuguetNote Added: 0101631
2018-01-10 10:45hgbotCheckin
2018-01-10 10:45hgbotNote Added: 0101646
2018-01-10 14:17ranjith_qualiantech_comStatusnew => scheduled
2018-01-10 14:18hgbotCheckin
2018-01-10 14:18hgbotNote Added: 0101651
2018-01-10 14:18ranjith_qualiantech_comStatusscheduled => resolved
2018-01-10 14:18ranjith_qualiantech_comResolutionopen => fixed
2018-01-11 18:58marvintmNote Added: 0101674
2018-01-11 18:58marvintmStatusresolved => new
2018-01-11 18:58marvintmResolutionfixed => open
2018-01-17 07:05hgbotCheckin
2018-01-17 07:05hgbotNote Added: 0101737
2018-01-17 07:05hgbotStatusnew => resolved
2018-01-17 07:05hgbotResolutionopen => fixed
2018-01-17 07:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f178b75af5ce4ccfea4b9051a05d1dc7dc140827 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/be8ab9532f94cfbb75c33b636e6b96e86803fe2c [^]
2018-01-19 08:51marvintmReview Assigned To => marvintm
2018-01-19 08:51marvintmStatusresolved => closed
2018-01-19 08:51marvintmFixed in Version => RR18Q2
2018-01-19 11:49ranjith_qualiantech_comRelationship addedrelated to 0037662

Notes
(0101188)
hgbot   
2017-12-21 16:46   
Repository: tools/automation/pi-mobile
Changeset: fc8932e746fbabe5906d47d694d81036b8f704a0
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Dec 21 16:46:31 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fc8932e746fbabe5906d47d694d81036b8f704a0 [^]

related to issue 37542 Remove temporarily from the hgvol jobs

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35248_VerifyUpdateCustomerOnLayaway.java
---
(0101189)
Sandrahuguet   
2017-12-21 16:46   
Please, activate again when the issue will be fixed
(0101595)
hgbot   
2018-01-05 13:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f178b75af5ce4ccfea4b9051a05d1dc7dc140827
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 05 18:19:47 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f178b75af5ce4ccfea4b9051a05d1dc7dc140827 [^]

Fixed issue 37542 : Location should not be saved while saving existing customers

* In Remote mode, location need not to be saved again if we save the existing customer
* locationModel is not neccessary to set in ChangedBusinessPartners model, since it requires json of receipt
* locId needs to be set in customer, Because in Customer Loader it creates based on exists of locId

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0101596)
hgbot   
2018-01-05 13:50   
Repository: tools/automation/pi-mobile
Changeset: 70f7857b6dca014d098c501e573f8b33806cccbe
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 05 17:42:47 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/70f7857b6dca014d098c501e573f8b33806cccbe [^]

Verifies issue 37542 : Modified automated test 'I35248_VerifyUpdateCustomerOnLayaway'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35248_VerifyUpdateCustomerOnLayaway.java
---
(0101629)
Sandrahuguet   
2018-01-09 09:45   
Still failing in higvol jobs:

https://ci.openbravo.com/view/retail/job/ret-higvol-pgsql/1127/testReport/junit/org.openbravo.test.mobile.retail.pack.selenium.tests.layaway/I35248_VerifyUpdateCustomerOnLayaway/test/ [^]


https://ci.openbravo.com/view/retail/job/ret-higvol-oracle/1007/testReport/org.openbravo.test.mobile.retail.pack.selenium.tests.layaway/I35248_VerifyUpdateCustomerOnLayaway/test/ [^]
(0101630)
hgbot   
2018-01-09 09:46   
Repository: tools/automation/pi-mobile
Changeset: fb5c1401463ead3ac1d5ca92a202b8a08fcdd92d
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Jan 09 09:46:23 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb5c1401463ead3ac1d5ca92a202b8a08fcdd92d [^]

related to issue 37542 Remove temporarily from the hgvol jobs

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35248_VerifyUpdateCustomerOnLayaway.java
---
(0101631)
Sandrahuguet   
2018-01-09 09:47   
Disable I35248_VerifyUpdateCustomerOnLayaway test again. Please, activate again when the issue will be fixed.
(0101646)
hgbot   
2018-01-10 10:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 943d645ebce7079d6eb0a7b9d146be131df49fe4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 10 15:15:26 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/943d645ebce7079d6eb0a7b9d146be131df49fe4 [^]

Related to issue 37542 : Location should not be saved while saving existing customers

---
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
---
(0101651)
hgbot   
2018-01-10 14:18   
Repository: tools/automation/pi-mobile
Changeset: 493768360275604c38ab5c1115c866e54e555ced
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 10 18:48:12 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/493768360275604c38ab5c1115c866e54e555ced [^]

Verifies issue 37542 : Modified automated test 'I35248_VerifyUpdateCustomerOnLayaway'

* Enabled High volume

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35248_VerifyUpdateCustomerOnLayaway.java
---
(0101674)
marvintm   
2018-01-11 18:58   
It seems there is a problem now, because of some part of the code that was removed. When you edit the customer and assign it again to the receipt, the location disappears:
- Activate remote mode.
- Click on customer selector button.
- On the "Arturo Montoro" record, click on "..." button, and select "Edit".
- Change customer name.
- Click on "Save".
- Now, click on "Assign customer". Notice that the customer is assigned correctly, but that the address button now is empty. This didn't happen previously.
(0101737)
hgbot   
2018-01-17 07:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: be8ab9532f94cfbb75c33b636e6b96e86803fe2c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 17 11:35:24 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/be8ab9532f94cfbb75c33b636e6b96e86803fe2c [^]

Fixed issue 37542 : Removed unused customer attributes while saving customer

---
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---