Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037507Retail ModulesWeb POSpublic2017-12-19 10:482018-03-07 09:24
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037507: New hook is required when synchronyzing a ticket
DescriptionIt is necessary to create a new hook which is executed after the transaction which completes and saves the ticket has been finalised. This hook should receive the ticket as a parameter.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 37507 source posterminal.patch (13,266) 2018-02-15 12:57
https://issues.openbravo.com/file_download.php?file_id=11584&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-12-19 10:48marvintmNew Issue
2017-12-19 10:48marvintmAssigned To => Retail
2017-12-19 10:48marvintmTriggers an Emergency Pack => No
2017-12-19 10:49aferrazIssue Monitored: aferraz
2017-12-22 12:10ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-12-26 09:51ranjith_qualiantech_comStatusnew => scheduled
2018-01-05 12:52hgbotCheckin
2018-01-05 12:52hgbotNote Added: 0101592
2018-01-05 12:52hgbotStatusscheduled => resolved
2018-01-05 12:52hgbotResolutionopen => fixed
2018-01-05 12:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2898eecee9697b2be47bff59daca97eb54432ba4 [^]
2018-01-08 18:18marvintmNote Added: 0101626
2018-01-08 18:18marvintmStatusresolved => new
2018-01-08 18:18marvintmResolutionfixed => open
2018-01-15 14:01aferrazNote Added: 0101694
2018-01-16 08:29aferrazNote Added: 0101711
2018-01-16 09:10aferrazNote Deleted: 0101711
2018-01-17 11:32hgbotCheckin
2018-01-17 11:32hgbotNote Added: 0101744
2018-01-17 11:32hgbotStatusnew => resolved
2018-01-17 11:32hgbotResolutionopen => fixed
2018-01-17 11:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2898eecee9697b2be47bff59daca97eb54432ba4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/49a47f0e9f007f8a1f6ae11f61dc81d259f38e19 [^]
2018-01-24 18:53aferrazNote Added: 0101931
2018-01-24 18:57aferrazStatusresolved => new
2018-01-24 18:57aferrazResolutionfixed => open
2018-01-29 16:02ranjith_qualiantech_comStatusnew => scheduled
2018-01-30 10:42hgbotCheckin
2018-01-30 10:42hgbotNote Added: 0102044
2018-01-30 10:42hgbotStatusscheduled => resolved
2018-01-30 10:42hgbotResolutionopen => fixed
2018-01-30 10:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/49a47f0e9f007f8a1f6ae11f61dc81d259f38e19 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0948174235a6e5c917cdfd46c3a45ff4de92fbb [^]
2018-01-31 14:35marvintmNote Added: 0102093
2018-01-31 14:35marvintmStatusresolved => new
2018-01-31 14:35marvintmResolutionfixed => open
2018-02-01 18:48aferrazNote Added: 0102122
2018-02-02 12:06ranjith_qualiantech_comStatusnew => scheduled
2018-02-05 09:32hgbotCheckin
2018-02-05 09:32hgbotNote Added: 0102167
2018-02-05 09:32hgbotStatusscheduled => resolved
2018-02-05 09:32hgbotResolutionopen => fixed
2018-02-05 09:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0948174235a6e5c917cdfd46c3a45ff4de92fbb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6956dba51f4e3a651acff90c04e08e77ed7f95e3 [^]
2018-02-05 14:23aferrazNote Added: 0102191
2018-02-06 17:01aferrazNote Deleted: 0102191
2018-02-13 09:47marvintmReview Assigned To => marvintm
2018-02-13 09:47marvintmStatusresolved => closed
2018-02-13 09:47marvintmFixed in Version => RR18Q2
2018-02-13 14:47ranjith_qualiantech_comNote Added: 0102363
2018-02-13 14:47ranjith_qualiantech_comStatusclosed => new
2018-02-13 14:47ranjith_qualiantech_comResolutionfixed => open
2018-02-13 14:47ranjith_qualiantech_comFixed in VersionRR18Q2 =>
2018-02-13 14:47ranjith_qualiantech_comNote Added: 0102364
2018-02-13 14:47ranjith_qualiantech_comNote Deleted: 0102364
2018-02-14 08:37hgbotCheckin
2018-02-14 08:37hgbotNote Added: 0102384
2018-02-14 08:37hgbotStatusnew => resolved
2018-02-14 08:37hgbotResolutionopen => fixed
2018-02-14 08:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6956dba51f4e3a651acff90c04e08e77ed7f95e3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/493a942155e187815771d1c271e45188ee860396 [^]
2018-02-14 12:11ranjith_qualiantech_comNote Added: 0102398
2018-02-14 12:11ranjith_qualiantech_comStatusresolved => new
2018-02-14 12:11ranjith_qualiantech_comResolutionfixed => open
2018-02-14 12:11ranjith_qualiantech_comStatusnew => scheduled
2018-02-15 12:57ranjith_qualiantech_comFile Added: issue 37507 source posterminal.patch
2018-02-21 08:25hgbotCheckin
2018-02-21 08:25hgbotNote Added: 0102543
2018-02-21 08:25hgbotStatusscheduled => resolved
2018-02-21 08:25hgbotResolutionopen => fixed
2018-02-21 08:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/493a942155e187815771d1c271e45188ee860396 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/928a4741ef6907df1ebbccfa6af04035229a00c9 [^]
2018-03-07 09:24marvintmStatusresolved => closed
2018-03-07 09:24marvintmFixed in Version => RR18Q2

Notes
(0101592)
hgbot   
2018-01-05 12:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2898eecee9697b2be47bff59daca97eb54432ba4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 05 17:22:23 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2898eecee9697b2be47bff59daca97eb54432ba4 [^]

Fixed issue 37507 : Added new hook for PreSyncReceipt after saving receipt

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0101626)
marvintm   
2018-01-08 18:18   
Current hook works correctly, but we need to implement the same functionality for multiorders flow (Pay Open Tickets). The hook should also be called there, individually per paid ticket, and the individual ticket should also be received as a parameter.
(0101694)
aferraz   
2018-01-15 14:01   
If we modify the receipt json inside this hook, we get a js error:

ticketCloseUtils.js: OB.error("The receipt has been modified while it was being closed:\n" + diffStringified + "\n");
(0101744)
hgbot   
2018-01-17 11:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 49a47f0e9f007f8a1f6ae11f61dc81d259f38e19
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 17 16:02:45 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/49a47f0e9f007f8a1f6ae11f61dc81d259f38e19 [^]

Fixed issue 37507 : Added new hook for PreSyncReceipt after saving receipt in multiorders

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0101931)
aferraz   
2018-01-24 18:53   
PreSyncReceipt hook is not being executed in Cancel Layaway and Void Layaway processes.
(0102044)
hgbot   
2018-01-30 10:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d0948174235a6e5c917cdfd46c3a45ff4de92fbb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 30 15:11:42 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d0948174235a6e5c917cdfd46c3a45ff4de92fbb [^]

Fixed issue 37507 : Refactor PreSyncReceipt for receipts and multiorders

* Added PreSyncReceipt for Cancel Layaway and Void Layaway

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0102093)
marvintm   
2018-01-31 14:35   
With the last changes, there is now a problem which didn't happen before: now some properties are set in the receipt after the OBPOS_PreSyncReceipt is called. This should not happen, we need all properties (including hasbeenpaid, cashupReportInformation, and the json itself) to be completely computed before the OBPOS_PreSyncReceipt hook is called; otherwise we will be missing these properties when computing the hash which always needs to include all properties.
(0102122)
aferraz   
2018-02-01 18:48   
This hook should be also executed when synchronizing removed tickets in case "Web POS Save Removed Tickets" preference is configured.
(0102167)
hgbot   
2018-02-05 09:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6956dba51f4e3a651acff90c04e08e77ed7f95e3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 05 14:02:31 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6956dba51f4e3a651acff90c04e08e77ed7f95e3 [^]

Fixed issue 37507 : Refactor PreSyncReceipt for receipts and multiorders

* Added PreSyncReceipt for deleting ticket if savedelete ticket prefernece is enabled

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0102363)
ranjith_qualiantech_com   
2018-02-13 14:47   
In Pay Open Tickets, OBPOS_PreSyncReceipt should be called before Save and runSyncProcess
(0102384)
hgbot   
2018-02-14 08:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 493a942155e187815771d1c271e45188ee860396
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 14 13:07:29 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/493a942155e187815771d1c271e45188ee860396 [^]

Fixed issue 37507 : Refactor PreSyncReceipt in multiorders

* PreSyncReceipt should be called before receipt save and sync process
* PreSyncReceipt should be called for each receipt in multiorders

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0102398)
ranjith_qualiantech_com   
2018-02-14 12:11   
receipt json should be updated after preSyncReceipt
(0102543)
hgbot   
2018-02-21 08:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 928a4741ef6907df1ebbccfa6af04035229a00c9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 21 12:54:38 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/928a4741ef6907df1ebbccfa6af04035229a00c9 [^]

Fixed issue 37507 : Refactor PreSyncReceipt in receipt, multiorders

* receipt json should be set after PreSyncReceipt hook
* Seperate transaction for saving receipt since hook PreSyncReceipt is async
* successCallbck for transaction is called after PreSyncReceipt completes

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---