Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037501Openbravo ERPA. Platformpublic2017-12-16 18:282018-02-22 18:18
Reportershuehner 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037501: About popup shows hg revision id of core repo which is not useful and should be removed.
DescriptionIssue 37500 tracks removal of running 'hg id' during build.

The About popup is one of the few places using that information to show hg commit it (of core repo).

As that is not useful anyway (because of modules) that should be removed as a blocker for removal of calling 'hg id'.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0037770 closed alostale API change: some removals in very old and obsolete code 
blocks feature request 0037500 closed shuehner Stop running 'hg id' during ant tasks (install.source & compilation) 
Attached Filespatch bug-37501.patch (3,668) 2018-01-04 11:11
https://issues.openbravo.com/file_download.php?file_id=11418&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-12-16 18:28shuehnerNew Issue
2017-12-16 18:28shuehnerAssigned To => platform
2017-12-16 18:28shuehnerModules => Core
2017-12-16 18:28shuehnerTriggers an Emergency Pack => No
2017-12-16 18:28shuehnerRelationship addedblocks 0037500
2017-12-21 09:17caristuAssigned Toplatform => jarmendariz
2017-12-21 09:17caristuStatusnew => acknowledged
2018-01-03 12:10jarmendarizStatusacknowledged => scheduled
2018-01-04 11:11jarmendarizFile Added: bug-37501.patch
2018-01-04 11:11jarmendarizFile Added: bug-37501-remove-versionId.patch
2018-01-04 11:13jarmendarizReview Assigned To => caristu
2018-01-22 11:45caristuFile Deleted: bug-37501-remove-versionId.patch
2018-01-22 11:57hgbotCheckin
2018-01-22 11:57hgbotNote Added: 0101832
2018-01-22 11:57hgbotStatusscheduled => resolved
2018-01-22 11:57hgbotResolutionopen => fixed
2018-01-22 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d92f078ccb580e680c46613defbd98ff07624dd1 [^]
2018-01-22 11:59hgbotCheckin
2018-01-22 11:59hgbotNote Added: 0101833
2018-01-22 12:03caristuNote Added: 0101834
2018-01-22 12:03caristuStatusresolved => closed
2018-01-22 12:03caristuFixed in Version => 3.0PR18Q2
2018-01-22 13:10hgbotCheckin
2018-01-22 13:10hgbotNote Added: 0101838
2018-01-30 12:59alostaleRelationship addeddepends on 0037770
2018-01-30 13:03hgbotCheckin
2018-01-30 13:03hgbotNote Added: 0102050
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102673
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102674
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102676
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102695

Notes
(0101832)
hgbot   
2018-01-22 11:57   
Repository: erp/devel/pi
Changeset: d92f078ccb580e680c46613defbd98ff07624dd1
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu Jan 04 11:04:20 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d92f078ccb580e680c46613defbd98ff07624dd1 [^]

Fixes bug 37501: Remove hg revision reference in About screen.

Removed all references to current hg revision in About screen, so this won't appear on the About popup.

---
M src/org/openbravo/erpCommon/ad_forms/About.html
M src/org/openbravo/erpCommon/ad_forms/About.java
M src/org/openbravo/erpCommon/ad_forms/About.xml
---
(0101833)
hgbot   
2018-01-22 11:59   
Repository: erp/devel/pi
Changeset: 2e0174fb00124760371ef667328aaf25f5c1af52
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 22 11:59:27 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2e0174fb00124760371ef667328aaf25f5c1af52 [^]

related to issue 37501: add missing final modifier for the constants

---
M src/org/openbravo/erpCommon/utility/OBVersion.java
---
(0101834)
caristu   
2018-01-22 12:03   
Code reviewed + tested OK.
(0101838)
hgbot   
2018-01-22 13:10   
Repository: erp/devel/pi
Changeset: bd9e41d5528fd0ec434b69e13d1e9533b9564671
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 22 13:09:53 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bd9e41d5528fd0ec434b69e13d1e9533b9564671 [^]

related to issue 37501: remove unused text interface

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0102050)
hgbot   
2018-01-30 13:03   
Repository: erp/devel/pi
Changeset: 83aa5e45d4c8d5b81143e10d3b07651acf9fc66e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 18:40:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/83aa5e45d4c8d5b81143e10d3b07651acf9fc66e [^]

related to issue 37501. Removed not used OBVersion.getVersionId method

Showing hg id output alone of core repo is not useful nowadays as there are
many modules present in any typical install.

Remove that output as preparation to fix 37500 issue.

---
M src/org/openbravo/erpCommon/utility/OBVersion.java
---
(0102673)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102674)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102676)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test
(0102695)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test