Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037499Openbravo ERPA. Platformpublic2017-12-16 18:152018-01-30 13:07
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037499: Remove unused feature to export ob_version + code_revision into xml files
DescriptionThe EntityXmlConverter has a feature to add 3 attributes to root 'Openbravo'
element of files it is creating (ob-version, ob-revision, created). That is
done by calling addSystemAttributes of the class.

However the rewrite of the xml export done in commit (102ba22a81ca, 2009-02-12)
did stop calling that method.

No other caller of that protectod method can be found in pi or search in
getAllModules.

Apart the only code requesting that optional feature was the dataset xml export
That export later has been switched over to a checksum of the exported content.
    
As that is now dead code since 8 years remove that feature. As that removes the
3 attributes from the export also remove those from the generated XML-Schema
which can be requested via /ws/dal/schema and the constants naming those
attributes from XMLConstants.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0037770 closed alostale API change: some removals in very old and obsolete code 
related to design defect 0032688 acknowledged Triage Platform Base remove unused resources 
blocks feature request 0037500 closed shuehner Stop running 'hg id' during ant tasks (install.source & compilation) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-16 18:15shuehnerNew Issue
2017-12-16 18:15shuehnerAssigned To => platform
2017-12-16 18:15shuehnerModules => Core
2017-12-16 18:15shuehnerTriggers an Emergency Pack => No
2017-12-16 18:15shuehnerRelationship addedrelated to 0032688
2017-12-16 18:19shuehnerRelationship addedblocks 0037500
2018-01-30 12:59alostaleRelationship addeddepends on 0037770
2018-01-30 13:01alostaleAssigned Toplatform => shuehner
2018-01-30 13:03hgbotCheckin
2018-01-30 13:03hgbotNote Added: 0102049
2018-01-30 13:03hgbotStatusnew => resolved
2018-01-30 13:03hgbotResolutionopen => fixed
2018-01-30 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/66c4a0c6f9c127775455a0d330453c0f67e0a7b3 [^]
2018-01-30 13:07alostaleReview Assigned To => alostale
2018-01-30 13:07alostaleNote Added: 0102052
2018-01-30 13:07alostaleStatusresolved => closed
2018-01-30 13:07alostaleFixed in Version => 3.0PR18Q2

Notes
(0102049)
hgbot   
2018-01-30 13:03   
Repository: erp/devel/pi
Changeset: 66c4a0c6f9c127775455a0d330453c0f67e0a7b3
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 18:26:08 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/66c4a0c6f9c127775455a0d330453c0f67e0a7b3 [^]

Fixed 37499. Remove unused feature to export code_revision to xml files.

EntityXmlConverter has a feature to add 3 attributes to root 'Openbravo'
element of files it is creating (ob-version, ob-revision, crated), by calling
addSystemAttributes method.
However rewrite of the xml export done in commit (102ba22a81ca, 2009-02-12)
stopped calling that method.
No other caller of that protected method can be found in pi or search in
getAllModules today.
Apart even before the only code requesting those attributes was the dataset
xml export. That has been later switched over to checksum for exported content.

As that is now dead code since 8 years remove that unused feature.

---
M src-test/src/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java
M src-test/src/org/openbravo/test/xml/EntityXMLImportTestSingle.java
M src-test/src/org/openbravo/test/xml/UniqueConstraintImportTest.java
M src-test/src/org/openbravo/test/xml/XMLBaseTest.java
M src/org/openbravo/dal/xml/EntityXMLConverter.java
M src/org/openbravo/dal/xml/ModelXMLConverter.java
M src/org/openbravo/dal/xml/XMLConstants.java
M src/org/openbravo/service/db/DataExportService.java
---
(0102052)
alostale   
2018-01-30 13:07   
reviewed