Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037498Openbravo ERPA. Platformpublic2017-12-16 17:452021-06-23 13:30
Reportershuehner 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037498: org.openbravo.businessUtility.Email class is deprecated since 3.0MP9 and should be removed.
DescriptionThat class is deprecated since 3.0MP9 release (from March 2012).

It is still used in compatibility code in AlertProcess.java

That compat code should be removed to allow deletion of this long obsolete code.

Note:
Probably a check needs to be added to catch and advise any users who still did not update/fix their configuration in the last 5 years.

Either:
- buildvalidation
- WARN message in alert processing and/or tomcat startup
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 00195453.0MP9 closed dbaz Email server configuration is in different places 
has duplicate design defect 0037028 closed Triage Platform Base AlertProcess should be refactored 
related to design defect 0047214 acknowledged Triage Platform Base remove deprecated email config columns in AD_Client 
related to defect 0047229 closed shuehner api-change removal of old EMail, EMailAuthenticator, Email_data.xsql files 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-16 17:45shuehnerNew Issue
2017-12-16 17:45shuehnerAssigned To => platform
2017-12-16 17:45shuehnerModules => Core
2017-12-16 17:45shuehnerTriggers an Emergency Pack => No
2017-12-16 17:45shuehnerRelationship addedblocks 0032688
2018-02-09 10:41alostaleStatusnew => acknowledged
2021-06-21 11:17shuehnerRelationship addedrelated to 0019545
2021-06-21 11:56hgbotNote Added: 0129683
2021-06-23 08:13alostaleRelationship addedrelated to 0047214
2021-06-23 13:25shuehnerRelationship addedrelated to 0047229
2021-06-23 13:30hgbotResolutionopen => fixed
2021-06-23 13:30hgbotStatusacknowledged => closed
2021-06-23 13:30hgbotFixed in Version => PR21Q3
2021-06-23 13:30hgbotNote Added: 0129740
2021-06-23 13:30hgbotNote Added: 0129741
2021-06-23 13:30hgbotNote Added: 0129742
2022-03-03 17:15shuehnerRelationship addedhas duplicate 0037028

Notes
(0129683)
hgbot   
2021-06-21 11:56   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/402 [^]
(0129740)
hgbot   
2021-06-23 13:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 093d9330046c90a820f6cd06561360fde0a01712
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-22T16:10:21+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/093d9330046c90a820f6cd06561360fde0a01712 [^]

Fixes ISSUE-37498. Remove deprecated EMAil class.

That old class was make obsolete and deprecated in MP9.
However code in AlertProcess was left using it as a fallback.

However the modulescript UpgradeToPoc email (added back then) was
auto-upgrading the config from ad_client to c_poc_configuration already.

That made this fallback code kind of obsolete already, remove it
completely.
That allows to delete the obsolete files.

---
M legal/CompiereAddendum.txt
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
M src/org/openbravo/erpCommon/ad_process/AlertProcess_data.xsql
R src/org/openbravo/erpCommon/businessUtility/ByteArrayDataSource.java
R src/org/openbravo/erpCommon/businessUtility/EMail.java
R src/org/openbravo/erpCommon/businessUtility/EMailAuthenticator.java
R src/org/openbravo/erpCommon/businessUtility/Email_data.xsql
---
(0129741)
hgbot   
2021-06-23 13:30   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 97b406e18c8f466f969730af4089fc990c262ca9
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-22T16:10:21+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/97b406e18c8f466f969730af4089fc990c262ca9 [^]

ISSUE-37498: Deprecate long obsolete ad_client email columns

- Since 3.0MP9 the email related column in ad_client table were no longer
  used (and instead the ones in c_poc_configuration).
  However the change in MP9 did not mark the columns as deprecated. Do
  that now to make it more visible in code (i.e. src-gen).
- One of the columns smtphost has also still stored into the HttpSession
  under the #Client_SMTP name. Checking across all published modules +
  gitlab.com/openbravo/* did not find any user.
  So stop storing that deprecated column value in the session.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/base/secureApp/Seguridad_data.xsql
---
(0129742)
hgbot   
2021-06-23 13:30   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/402 [^]