0037430: Wrong "line_id" generated in Remittance posting when several remittance lines are related with same payment

Openbravo Issue Tracking System - Modules
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0037430	Modules	Remittance	public	2017-12-01 10:49	2017-12-19 09:19

Reporter	maite
Assigned To	collazoandy4
Priority	urgent	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To	dmiguelez
Support ticket
OBNetwork customer
Regression introduced in release

Summary	0037430: Wrong "line_id" generated in Remittance posting when several remittance lines are related with same payment
Description	Incorrect "line_id" is being generated when posting a remittance which has several lines related with same payment. All accounting details (fact_acct records) are generated with first line_id associated instead of specific line_id of each remittance line
Steps To Reproduce	0. Access as System Administrator to "Windows tabs and fields" and show field "SQL Description" for General Ledger Configuration window, Active Tables tab 1. Access to "F&B International Group US/A/US Dollar" general ledger and define following description for "REM_Remittance" table: select rl.rem_remittanceline_id \|\| ' - ' \|\| rl.line \|\| ' hola ' from rem_remittanceline rl where rem_remittanceline_id = @Line@ 2. Register Sales Order for any org and BP. Set Invoice terms= immediate. Add any line. Set qty=10 and process 3. Register Sales Invoice for same org and BP. Run "Create lines from" and select previous order. Edit line qty to 2 and process 4. Register Sales Invoice for same org and BP. Run "Create lines from" and select previous order and process (line qty should be 8) 5. Register Remittance header. Set Expected Date=01-06-2018, run "Select orders or invoices" and select previous invoices. Process remittance using "grouping by business partner" option 6. Post remittance, go to "Detail" and verify that same description has been generated for all the lines: 2824FC712BD6469892128E16EC1633BA - 10 hola This is not correct as each line should have specific line no Moreover, you can select accounting details directly in database to verify that "Line_id" is wrong as same identifier has been set for all lines (select line_id from fact_acct where record_id='remittance_id')
Proposed Solution	Problem is in "loadLinesFieldProvider" method of DocREMRemittance file: "remmitanceLineID" is loaded for first line but as all remittance lines are related to same payment document, then rest of lines are skipped
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2017-12-01 10:49	maite	New Issue
2017-12-01 10:49	maite	Assigned To	=> Triage Finance
2017-12-01 10:49	maite	Resolution time	=> 1513897200
2017-12-01 14:00	dmiguelez	Assigned To	Triage Finance => nonofrancisco
2017-12-01 16:02	nonofrancisco	Status	new => scheduled
2017-12-12 16:53	vmromanos	Assigned To	nonofrancisco => collazoandy4
2017-12-13 22:54	collazoandy4	Note Added: 0101027
2017-12-19 09:09	dmiguelez	Note Added: 0101116
2017-12-19 09:14	hgbot	Checkin
2017-12-19 09:14	hgbot	Note Added: 0101117
2017-12-19 09:14	hgbot	Status	scheduled => resolved
2017-12-19 09:14	hgbot	Resolution	open => fixed
2017-12-19 09:14	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/7b170efb992b4eae405fc92eb75b5aa9354174e2 [^]
2017-12-19 09:14	hgbot	Checkin
2017-12-19 09:14	hgbot	Note Added: 0101118
2017-12-19 09:14	hgbot	Checkin
2017-12-19 09:14	hgbot	Note Added: 0101119
2017-12-19 09:19	dmiguelez	Review Assigned To	=> dmiguelez
2017-12-19 09:19	dmiguelez	Note Added: 0101120
2017-12-19 09:19	dmiguelez	Status	resolved => closed

Notes

Remittance configuration
  As System Admin Role
    Set Core Module as In Development: Y
    Go to Windows Tab and Fields window and select General Ledger Configuration record
      Set SQL Description field of Active Tables tab as Displayed: Y
  As F&B International Group Admin Role
    Go to General Ledger Configuration window and select F&B International Group US/A/US Dollar record
      Select the REM_Remittance record of Active Tables tab:
        SQL Description: select rl.rem_remittanceline_id || ' - ' || rl.line || ' hola ' from rem_remittanceline rl where rem_remittanceline_id = @Line@
    Applied the remittance dataset for * organization in Enterprise Module Management window
    Log out and Log in
    Go to Financial Account window and select Cuenta de Banco record:
      Create a new record in Payment Method tab:
        Payment Method: Remittance
        Upon Deposit Use: Cleared Payment Account
        Upon Reconciliation Use: Deposited Payment Account
        Upon Receipt Use: In Transit Payment Account
    Go to Remittance Type window and select Printable Remittance record:
      Create a new record in Accounting tab:
        General Ledger: F&B España, S.A. US/A/Euro
        Settlement Account / Sent Account: 52080
      Create a new record in Accounting tab:
        General Ledger: F&B International Group US/A/US Dollar
        Settlement Account / Sent Account: 1190
Test Plan I
    Go to Sales Order and create a new record for Alimentos y Supermercados, S.A bp
      Invoice Terms: Immediate
      Create a new record in Lines tab:
        Product: Zumo de Piña
        Ordered Quantity: 10
      Complete the order
    Create two Sales Invoice from the previous order created, one with invoiced qty of 2 and other with qty 8 and Complete it
    Go to Remittance window and create a new record:
      Name: TestPlanI
      Expected date: 01-06-2018
      Clic on Select Order or Invoices button:
        Show payments for alternative payment methods: Y
        Select the two record asociated to the previous order created
        Clic on Process button
        Check new Lines was added
      Clic on Process button and select Grouping by Business Partner
      Post the remittance document
      In the Journal Entries of F&B International Group US/A/US Dollar clic on Details link and check that the two remittance lines ids appears as entry description
Test Plan II
    Create to Sales Invoice for Alimentos y Supermercados, S.A bp and complete it
    Go to Remittance window and create a new record:
      Name: TestPlan2
      Expected date: Two months from now
      Clic on Select Order or Invoices button:
        Show payments for alternative payment methods: Y
        Select the two record asociated to the previous invoices created
        Clic on Process button
        Check new Lines was added
      Clic on Process button and no grouping option
      Post the remittance document
      In the Journal Entries of F&B International Group US/A/US Dollar clic on Details link and check that the two remittance lines ids appears as entry description