Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0037411Openbravo ERPA. Platformpublic2017-11-28 16:342018-01-03 12:39
shuehner 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR18Q1 
caristu
Core
No
0037411: TreeTablesEventHandler.getDataSource does useless ad_table read
  private DataSourceService getDataSource(String tableId) {
    Table table = OBDal.getInstance().get(Table.class, tableId);
    OBCriteria<TableTree> obq = OBDal.getInstance().createCriteria(TableTree.class);
    obq.add(Restrictions.eq(TableTree.PROPERTY_TABLE, table));

That code is uselessly reading from ad_table and should use a getProxy instead.

-
Performance
Issue History
2017-11-28 16:34shuehnerNew Issue
2017-11-28 16:34shuehnerAssigned To => platform
2017-11-28 16:34shuehnerModules => Core
2017-11-28 16:34shuehnerTriggers an Emergency Pack => No
2017-11-28 16:34shuehnerTag Attached: Performance
2017-11-29 12:16alostaleAssigned Toplatform => alostale
2017-11-29 12:16hgbotCheckin
2017-11-29 12:16hgbotNote Added: 0100810
2017-11-29 12:16hgbotStatusnew => resolved
2017-11-29 12:16hgbotResolutionopen => fixed
2017-11-29 12:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/94f270f9358c66b98a1b103ba4789d1212d4a6d5 [^]
2017-11-29 12:16alostaleReview Assigned To => caristu
2017-12-15 09:11caristuNote Added: 0101051
2017-12-15 09:11caristuStatusresolved => closed
2017-12-15 09:11caristuFixed in Version => 3.0PR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101496

Notes
(0100810)
hgbot   
2017-11-29 12:16   
Repository: erp/devel/pi
Changeset: 94f270f9358c66b98a1b103ba4789d1212d4a6d5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Nov 29 12:15:58 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/94f270f9358c66b98a1b103ba4789d1212d4a6d5 [^]

fixed bug 37411: useless ad_table query in TreeTablesEventHandler.getDataSource

  Use proxy as table value is never used.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TreeTablesEventHandler.java
---
(0101051)
caristu   
2017-12-15 09:11   
Code reviewed + tested OK.
(0101496)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test