Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037403Retail ModulesWeb POSpublic2017-11-28 10:092018-01-08 12:23
guillermogil 
jorge-garcia 
highmajoralways
closedfixed 
5
 
RR18Q1RR18Q2 
marvintm
No
0037403: Log Client should have all the information of the logs, not a substring
Log Client should have all the information of the logs, not a substring.
Maybe it makes sense to keep it as it is but for ticket closed massage it is needed to have it all as a backup
Make a ticket of 10 lines
See its log client
Change the column at database level from varchar to clob
No tags attached.
depends on backport 0037597RR18Q1 closed jorge-garcia Log Client should have all the information of the logs, not a substring 
depends on backport 0037598RR17Q4.1 closed jorge-garcia Log Client should have all the information of the logs, not a substring 
depends on backport 0037599RR17Q3.3 closed jorge-garcia Log Client should have all the information of the logs, not a substring 
causes defect 0037468RR18Q1 closed jorge-garcia API change: msg column from obmobc_logclient should be clob type instead of varchar 
diff exportSizeIncrease.diff (1,325) 2017-12-27 14:58
https://issues.openbravo.com/file_download.php?file_id=11396&type=bug
diff commit_fix_multiorder_37403.diff (1,169) 2017-12-28 18:48
https://issues.openbravo.com/file_download.php?file_id=11400&type=bug
Issue History
2017-11-28 10:09guillermogilNew Issue
2017-11-28 10:09guillermogilAssigned To => Retail
2017-11-28 10:09guillermogilResolution time => 1513638000
2017-11-28 10:09guillermogilTriggers an Emergency Pack => No
2017-11-29 21:49rqueraltaAssigned ToRetail => rqueralta
2017-11-29 21:50rqueraltaStatusnew => scheduled
2017-12-12 14:59jorge-garciaAssigned Torqueralta => jorge-garcia
2017-12-13 09:07jorge-garciaRelationship addedcauses 0037468
2017-12-14 10:10hgbotCheckin
2017-12-14 10:10hgbotNote Added: 0101032
2017-12-14 10:10hgbotStatusscheduled => resolved
2017-12-14 10:10hgbotResolutionopen => fixed
2017-12-14 10:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6eb4436882d0af405b701cd862ec01b8bab89f33 [^]
2017-12-15 13:03hgbotCheckin
2017-12-15 13:03hgbotNote Added: 0101060
2017-12-20 19:15marvintmNote Added: 0101175
2017-12-20 19:15marvintmStatusresolved => new
2017-12-20 19:15marvintmResolutionfixed => open
2017-12-27 14:58jorgewederagoNote Added: 0101262
2017-12-27 14:58jorgewederagoFile Added: exportSizeIncrease.diff
2017-12-27 16:18jorgewederagoNote Edited: 0101262bug_revision_view_page.php?bugnote_id=0101262#r16499
2017-12-28 18:48gorka_gilFile Added: commit_fix_multiorder_37403.diff
2017-12-28 18:52hgbotCheckin
2017-12-28 18:52hgbotNote Added: 0101283
2017-12-28 18:52hgbotCheckin
2017-12-28 18:52hgbotNote Added: 0101284
2017-12-28 18:58gorka_gilNote Added: 0101285
2017-12-28 19:05gorka_gilStatusnew => scheduled
2017-12-28 19:06gorka_gilTarget Version => RR18Q1
2018-01-04 12:53hgbotCheckin
2018-01-04 12:53hgbotNote Added: 0101554
2018-01-04 12:54hgbotCheckin
2018-01-04 12:54hgbotNote Added: 0101555
2018-01-04 12:54hgbotStatusscheduled => resolved
2018-01-04 12:54hgbotResolutionopen => fixed
2018-01-04 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6eb4436882d0af405b701cd862ec01b8bab89f33 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/59443e3d54a3e61189fa16ab4cb3582d68f1438e [^]
2018-01-08 12:06hgbotCheckin
2018-01-08 12:06hgbotNote Added: 0101617
2018-01-08 12:22marvintmReview Assigned To => marvintm
2018-01-08 12:22marvintmStatusresolved => closed
2018-01-08 12:22marvintmFixed in Version => RR18Q2
2018-01-08 12:22marvintmStatusclosed => new
2018-01-08 12:22marvintmResolutionfixed => open
2018-01-08 12:22marvintmFixed in VersionRR18Q2 =>
2018-01-08 12:22marvintmStatusnew => acknowledged
2018-01-08 12:23marvintmStatusacknowledged => scheduled
2018-01-08 12:23marvintmStatusscheduled => resolved
2018-01-08 12:23marvintmFixed in Version => RR18Q2
2018-01-08 12:23marvintmResolutionopen => fixed
2018-01-08 12:23marvintmStatusresolved => closed

Notes
(0101032)
hgbot   
2017-12-14 10:10   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6eb4436882d0af405b701cd862ec01b8bab89f33
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 11 13:28:39 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6eb4436882d0af405b701cd862ec01b8bab89f33 [^]

Fixed issue 37403: Log Client should have all the information of the logs, not
a substring

Msg field has been change from varchar to clob.

In order to work with oracle, it is necessary to define a sort field in
log client window differnet from msg field. Created has been defined to
sort in log client window.

---
M src-db/database/model/tables/OBMOBC_LOGCLIENT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0101060)
hgbot   
2017-12-15 13:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fc74a985a0d40bb210e292bad4ff7fc5d46aad0d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Dec 14 17:41:51 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc74a985a0d40bb210e292bad4ff7fc5d46aad0d [^]

Related to issue 37403: Log Client should have all the information of the logs, not
a substring

Ticket closed message should show all the receipt in logclient instead of a summary.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0101175)
marvintm   
2017-12-20 19:15   
Current changes are correct. However, one thing needs to be reviewed: the "multiorders ticket closed" message includes the whole json, which itself includes the binary data of the product images. This can now lead to bandwidth problems as we are no longer truncating the ticket, and doesn't make sense, the image data should be removed from the json before it is added to the log client (like it currently happens in the normal receipts).
(0101262)
jorgewederago   
2017-12-27 14:58   
(edited on: 2017-12-27 16:18)
In certain situations the new defined size might not be enough causing the log client not to be saved. My suggestion is to set the new size to at least 10000000. Check the exported attachment.

Also just to avoid future issues it might be good idea to recover the truncate if the length is too big for the field.

(0101283)
hgbot   
2017-12-28 18:52   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 53abc4332b891bf0c16ef3d77cea9de74e297963
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Dec 28 18:50:34 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/53abc4332b891bf0c16ef3d77cea9de74e297963 [^]

Related to issue 37403. Backed out changeset 6eb4436882d0

---
M src-db/database/model/tables/OBMOBC_LOGCLIENT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0101284)
hgbot   
2017-12-28 18:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4623a770b2225d8be6ed911ac2f9344d71594d59
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Dec 28 18:51:16 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4623a770b2225d8be6ed911ac2f9344d71594d59 [^]

Related to issue 37403. Backed out changeset fc74a985a0d4

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0101285)
gorka_gil   
2017-12-28 18:58   
Because the problem reported by Jorge Wederago, and after talk with QA, we have backout the fix, and we will try to fix it before the Jan 15 that is the repackage of 18q1.

For the fix of only save the json for multiorder, added the attachment: commit_fix_multiorder_37403.diff
(0101554)
hgbot   
2018-01-04 12:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 16c18de2a7a9888325a1ce8278a91ec4a61e688a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 02 16:40:32 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16c18de2a7a9888325a1ce8278a91ec4a61e688a [^]

Related to issue 37403: Log Client should have all the information of the logs, not
a substring

Ticket closed message should show all the receipt in logclient instead of a summary.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0101555)
hgbot   
2018-01-04 12:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 59443e3d54a3e61189fa16ab4cb3582d68f1438e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jan 03 09:40:22 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/59443e3d54a3e61189fa16ab4cb3582d68f1438e [^]

Fixed issue 37403: Log Client should have all the information of the logs, not
a substring

Msg field has been change from varchar to clob.

In order to work with oracle, it is necessary to define a sort field in
log client window differnet from msg field. Created has been defined to
sort in log client window.

---
M src-db/database/model/tables/OBMOBC_LOGCLIENT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0101617)
hgbot   
2018-01-08 12:06   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9c1327052c97eff0e3a6e1f0a1cd179315951627
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 08 12:01:35 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9c1327052c97eff0e3a6e1f0a1cd179315951627 [^]

Related to issue 37403: Log Client should have all the information of the logs, not
a substring

Increse msg length from one million characters to one hundred million of
characters.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---