Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037401Retail ModulesWeb POSpublic2017-11-27 19:002018-01-16 14:07
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037401: It is necessary to add a hook in the process which closes the store
DescriptionWhen the Sessions module is installed, there is a process which closes the store.

It is necessary to add some additional logic to this process, so some extensibility via hook should be added.
Steps To Reproduce,
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0037147 closed Retail A new hook to be added after Close Store process happens 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-27 19:00marvintmNew Issue
2017-11-27 19:00marvintmAssigned To => Retail
2017-11-27 19:00marvintmTriggers an Emergency Pack => No
2017-12-12 15:55ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-12-12 15:55ranjith_qualiantech_comStatusnew => scheduled
2017-12-12 17:08aferrazIssue Monitored: aferraz
2017-12-16 08:27hgbotCheckin
2017-12-16 08:27hgbotNote Added: 0101079
2017-12-16 12:54ranjith_qualiantech_comStatusscheduled => resolved
2017-12-16 12:54ranjith_qualiantech_comResolutionopen => fixed
2017-12-19 16:04marvintmNote Added: 0101135
2017-12-19 16:04marvintmStatusresolved => new
2017-12-19 16:04marvintmResolutionfixed => open
2017-12-21 07:06ranjith_qualiantech_comStatusnew => scheduled
2017-12-21 07:19hgbotCheckin
2017-12-21 07:19hgbotNote Added: 0101176
2017-12-21 10:09ranjith_qualiantech_comStatusscheduled => resolved
2017-12-21 10:09ranjith_qualiantech_comResolutionopen => fixed
2017-12-22 13:35migueldejuanaReview Assigned To => migueldejuana
2017-12-22 13:35migueldejuanaNote Added: 0101234
2017-12-22 13:35migueldejuanaStatusresolved => closed
2018-01-16 14:07hgbotCheckin
2018-01-16 14:07hgbotNote Added: 0101725
2018-01-17 09:52aferrazNote Deleted: 0101725
2019-06-06 10:35umartirenaRelationship addedhas duplicate 0037147

Notes
(0101079)
hgbot   
2017-12-16 08:27   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 0a042fde6ee4a547072cda3bc8b74ea6ffae0630
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Dec 16 12:57:22 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/0a042fde6ee4a547072cda3bc8b74ea6ffae0630 [^]

Related to issue 37401 : Added hook for Close Store

---
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
A src/org/openbravo/retail/sessions/WebPOSCloseStoreHook.java
---
(0101135)
marvintm   
2017-12-19 16:04   
There are two problems with the fix:

- The hook is executed when the store is closed from the WebPOS, but not when it is closed from the backend. It needs to be executed also in the class CloseStoreProcess
- The hook currently accepts a JSON which comes from the WebPOS, but this will be a problem if we execute it also from the backend process. I think in this case it would be better to send just the Organization object of the store that is being closed, because this is essentially the only relevant information in this process.
(0101176)
hgbot   
2017-12-21 07:19   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: d0c2a6d290aa4d9c913b987cbaf9bc4a6ffc4441
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 21 11:49:10 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/d0c2a6d290aa4d9c913b987cbaf9bc4a6ffc4441 [^]

Related to issue 37401 : Added hook for Close Store from WEBPOS and Backoffice

---
M src/org/openbravo/retail/sessions/CloseStoreActionHandler.java
M src/org/openbravo/retail/sessions/CloseStoreProcess.java
M src/org/openbravo/retail/sessions/WebPOSCloseStore.java
M src/org/openbravo/retail/sessions/WebPOSCloseStoreHook.java
A src/org/openbravo/retail/sessions/CloseStoreUtils.java
---
(0101234)
migueldejuana   
2017-12-22 13:35   
Tested and reviewed