Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037379Retail ModulesStoreServerpublic2017-11-24 07:102017-11-29 15:57
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037379: In mobile server request executor when read time out occurs then do not go offline
DescriptionSee the related issue for details of code location. Currently the store server will transition to offline also if the CS can be reached but is very slow. The idea is to change this and only transition to offline in case of connection time outs.
Steps To ReproduceSee related issue
Proposed SolutionCatch the specific exception, retry but do not transition to offline.
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0037249pi closed mtaal For server to server requests set read and connection time out 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-24 07:10mtaalNew Issue
2017-11-24 07:10mtaalAssigned To => mtaal
2017-11-24 07:10mtaalTriggers an Emergency Pack => No
2017-11-24 07:11mtaalRelationship addeddepends on 0037249
2017-11-26 13:22mtaalNote Added: 0100714
2017-11-26 13:29mtaalNote Added: 0100715
2017-11-26 17:48mtaalNote Edited: 0100715bug_revision_view_page.php?bugnote_id=0100715#r16383
2017-11-26 18:43mtaalNote Edited: 0100715bug_revision_view_page.php?bugnote_id=0100715#r16384
2017-11-26 18:44mtaalNote Edited: 0100715bug_revision_view_page.php?bugnote_id=0100715#r16385
2017-11-26 23:09mtaalReview Assigned To => AugustoMauch
2017-11-26 23:10hgbotCheckin
2017-11-26 23:10hgbotNote Added: 0100717
2017-11-26 23:10hgbotStatusnew => resolved
2017-11-26 23:10hgbotResolutionopen => fixed
2017-11-26 23:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f637adf4814f52a51f216804a530274af8a126a6 [^]
2017-11-27 10:18mtaalReview Assigned ToAugustoMauch => migueldejuana
2017-11-29 15:57migueldejuanaNote Added: 0100814
2017-11-29 15:57migueldejuanaStatusresolved => closed

Notes
(0100714)
mtaal   
2017-11-26 13:22   
Added preference and docs:
http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences#Behavioral_Preferences [^]

See: Read timeout forces offline preference
(0100715)
mtaal   
2017-11-26 13:29   
(edited on: 2017-11-26 18:44)
For get a readtime out do the following:
- install/run multiserver
- set the read time out preference to a low value (1 minute) to make it easier to test
- set a breakpoint in the MobileService class in the CS
- enter a ticket in webpos, check the SS code that it read times out but does not go offline

Do the above test also with the preference set to Y to check the preference logic.

Note also the comments in the code (see diff) that subsequent requests are handled with readtimeout depending on where you put the breakpoint.
(0100717)
hgbot   
2017-11-26 23:10   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f637adf4814f52a51f216804a530274af8a126a6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 26 23:09:02 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f637adf4814f52a51f216804a530274af8a126a6 [^]

Fixes issue 37379: In mobile server request executor when read time out occurs then do not go offline
In case of read time out then do not go offline, help to control this using a preference

Note: the changeset is somewhat larger because it includes changing from a recursive call to a while loop

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0100814)
migueldejuana   
2017-11-29 15:57   
Reviewed