Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037376Openbravo ERP04. Warehouse managementpublic2017-11-23 14:042018-01-03 12:39
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket49477
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037376: Stock Reservation of partially invoiced and not shipped order line is Closed when closing the sales order and it can be edited
DescriptionStock Reservation of partially invoiced and not shipped order line is Closed when closing the sales order and it can be edited

Closed reservations are usually the ones with Quantity = Reserved Qty = Released Qty and they cannot be edited
Steps To ReproduceAs group admin role:
   Set Enable Stock Reservations to Y
   Log out and log in
   Create a Sales Order and set is Invoice Terms = Immediate
   Add 5 units of a stocked product
   Complete it
   Select the line, click on Manage Reservation and reserve it completely
   Create a Sales Invoice header and select the sales order line in Create Lines From process
   Decrease the quantity to 3
   Complete it
   Close the Sales Order and check the ordered quantity changes from 5 to 3
   Check the Stock reservation is updated to:
      Quantity: 3
      Reserved Qty: 0
      Released: 0
      Status: Closed
   and do not have lines. It cannot be edited from Stock Reservations window
   
   Go to Sales order, select the line and click on Manage Reservations
   Reserve the quantity pending to be shipped (3)

   Check the Stock reservation is updated to:
      Quantity: 3
      Reserved Qty: 3
      Released: 0
      Status: Closed
   and a new line is added. It cannot be edited from Stock Reservations window
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-23 14:04ngarciaNew Issue
2017-11-23 14:04ngarciaAssigned To => Triage Finance
2017-11-23 14:04ngarciaOBNetwork customer => Yes
2017-11-23 14:04ngarciaModules => Core
2017-11-23 14:04ngarciaSupport ticket => 49477
2017-11-23 14:04ngarciaResolution time => 1513206000
2017-11-23 14:04ngarciaTriggers an Emergency Pack => No
2017-11-23 14:05ngarciaIssue Monitored: networkb
2017-11-23 16:24PracticsIssue Monitored: Practics
2017-11-23 18:50vmromanosAssigned ToTriage Finance => collazoandy4
2017-11-24 23:58collazoandy4Statusnew => scheduled
2017-11-27 17:38collazoandy4Note Added: 0100744
2017-12-12 17:31collazoandy4Note Added: 0101002
2017-12-14 12:34hgbotCheckin
2017-12-14 12:34hgbotNote Added: 0101037
2017-12-14 12:34hgbotStatusscheduled => resolved
2017-12-14 12:34hgbotResolutionopen => fixed
2017-12-14 12:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ecd83704f4fc4bd152a1df4b69ece9dc57b50407 [^]
2017-12-14 12:34dmiguelezReview Assigned To => dmiguelez
2017-12-14 12:34dmiguelezNote Added: 0101038
2017-12-14 12:34dmiguelezStatusresolved => closed
2017-12-14 12:34dmiguelezFixed in Version => 3.0PR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101524

Notes
(0100744)
collazoandy4   
2017-11-27 17:38   
Test Plan
  As F&B International Group Admin Role
    Go to Preference window and create a new record:
      Property: Enable Stock Reservations
      Value: Y
    Log out and log in
    Go to Sales Order window and create a new record:
      Business Partner: Alimentos y Supermercados, S.A
      Invoice Terms: Immediate
      Create a new record in Lines tab:
        Product: Zumo de Piña 0,5L
        Ordered Quantity: 5
      Complete the order
      Select the previous line create and click on Manage Reservation and reserve it completely
    Go to Sales Invoice window and create a new record for Alimentos bp:
      Create Lines from previous order created
      Edit the line quantity to 3
    Complete it
    Close the Sales Order and check the ordered quantity changes from 5 to 3
    Check the Stock reservation is updated to:
      Quantity: 3
      Reserved Qty: 0
      Released: 0
      Status: Closed
    The reservation doesn't have lines. It cannot be edited from Stock Reservations window
    Go to Sales order, select the line and check Manage Reservations is not shown
(0101002)
collazoandy4   
2017-12-12 17:31   
Test Plan II
  Go to Sales Order window and create a new record:
      Business Partner: Alimentos y Supermercados, S.A
      Invoice Terms: Immediate
      Create a new record in Lines tab:
        Product: Zumo de Piña 0,5L
        Ordered Quantity: 10
      Complete the order
      Select the previous line create and click on Manage Reservation and reserve it completely
  Go to Stock reservation window and close the reservation created
  Go to Sales Order and check you can reserve the line
(0101037)
hgbot   
2017-12-14 12:34   
Repository: erp/devel/pi
Changeset: ecd83704f4fc4bd152a1df4b69ece9dc57b50407
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Nov 24 17:36:51 2017 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/ecd83704f4fc4bd152a1df4b69ece9dc57b50407 [^]

Fixes issue 37376: Stock Reservation of partially invoiced and not shipped order
line is Closed when closing the sales order and it can be edited

When an order is closed all the reservation's made to lines are closed but you
still can manage the reservation stock from sales order window

Now the Manage Reservation button is shown when the order is not closed

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0101038)
dmiguelez   
2017-12-14 12:34   
Code Review + Testing Ok
(0101524)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test