Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037355ModulesAdvanced Warehouse Operationspublic2017-11-22 11:312018-01-05 12:41
Reporterdmiguelez 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0037355: It is possible to launch the Picking/Issue Process for a Closed Sales Order
DescriptionIt is possible to launch the Picking/Issue Process for a Closed Sales Order
Steps To ReproduceLogin as AWO-QA Admin

Go to Sales Order window and create a new record with:
  * Organization: US
  * BusinessPartner: Healthy Food Supermarkets
  * Warehouse: US West Coast
Move to Lines tab and create a new record with:
  * Product: Ale Beer
  * Operative Quantity: 5
Book the Sales Order
Click on close button and close the Sales Order

Realize that the Picking and Issue buttons are still shown and it is able to launch the picking or issue process
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039256 closed Triage Omni WMS [AWOBE][PCRVW] Receipt button is shown when Purchase order is closed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-22 11:31dmiguelezNew Issue
2017-11-22 11:31dmiguelezAssigned To => dmiguelez
2017-11-27 12:09dmiguelezSeverityminor => major
2017-11-30 16:03dmiguelezAssigned Todmiguelez => nonofrancisco
2017-11-30 16:12nonofranciscoStatusnew => scheduled
2017-11-30 18:00nonofranciscoNote Added: 0100842
2017-11-30 18:01nonofranciscoNote Edited: 0100842bug_revision_view_page.php?bugnote_id=0100842#r16411
2018-01-05 12:39hgbotCheckin
2018-01-05 12:39hgbotNote Added: 0101581
2018-01-05 12:39hgbotStatusscheduled => resolved
2018-01-05 12:39hgbotResolutionopen => fixed
2018-01-05 12:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/2ae09e56fe0db59e2cec06389c0a38b08bfa1fce [^]
2018-01-05 12:39hgbotCheckin
2018-01-05 12:39hgbotNote Added: 0101582
2018-01-05 12:39hgbotCheckin
2018-01-05 12:39hgbotNote Added: 0101583
2018-01-05 12:41dmiguelezReview Assigned To => dmiguelez
2018-01-05 12:41dmiguelezNote Added: 0101584
2018-01-05 12:41dmiguelezStatusresolved => closed
2018-09-17 17:21dmiguelezRelationship addedrelated to 0039256
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0100842)
nonofrancisco   
2017-11-30 18:00   
(edited on: 2017-11-30 18:01)
Login as AWO-QA Admin

Go to Sales Order window and create a new record with:
  * Organization: US
  * BusinessPartner: Healthy Food Supermarkets
  * Warehouse: US West Coast
Move to Lines tab and create a new record with:
  * Product: Ale Beer
  * Operative Quantity: 5
Book the Sales Order
Click on close button and close the Sales Order

Notice that Pick and Issue buttons are not shown.
(0101581)
hgbot   
2018-01-05 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 2ae09e56fe0db59e2cec06389c0a38b08bfa1fce
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Jan 05 11:45:40 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/2ae09e56fe0db59e2cec06389c0a38b08bfa1fce [^]

Fixes issue 37355: It is possible to launch the Picking/Issue Process for a
Closed Sales Order

- A new PL has been created and registered as extension point of C_Order_Post
  procedure. This PL verifies that lines belonging to the order being closed
  does not have any task in status 'AV' or 'RE'; if this is the case, an
  exception is thrown notifyind the user, otherwise, the
  em_obawo_incomplete_picking field is set to 0.
- Buttons 'Pick' and 'Issue' are shown only if order is in status 'Booked' and
  AWO Flow is enabled.

---
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
A src-db/database/sourcedata/AD_EP_PROCEDURES.xml
---
(0101582)
hgbot   
2018-01-05 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 529019315e1bfc6100c6f78f5bd28811df412e3b
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Tue Dec 05 17:26:10 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/529019315e1bfc6100c6f78f5bd28811df412e3b [^]

Adds test for issue 37355

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOc_AWOFunctionalFlows.java
---
(0101583)
hgbot   
2018-01-05 12:39   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: d9dd2058ab0de6785f0e05dd2981db341bd5d253
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 05 12:38:52 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/d9dd2058ab0de6785f0e05dd2981db341bd5d253 [^]

Relate to Issue 37355. Code Review changes:

* Updated license years
* Renamed method removeGeneratedTasks to removeFirstGeneratedTask
* Changes due to export.database

---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOc_AWOFunctionalFlows.java
---
(0101584)
dmiguelez   
2018-01-05 12:41   
Code Review + Testing Ok