Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037344Retail ModulesWeb POSpublic2017-11-21 13:152018-01-03 12:39
asiermartirena 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
RR18Q1 
marvintm
No
0037344: Credit notes are always printed, even if they are not configured in the organization
There is not a OBPOS_PRINT_TEMPLATE record defined for the credit notes, so the creditnote.xml template is not selectable by default in the organization configuration.
To be able to print, in the GiftCardDetails.js and printGiftCardPrePrintHook.js files, the template is read directly from the route (using "../org.openbravo.retail.giftcards/res/creditnote.xml"). This is not correct. The template to print must always be taken from the organization, so a record must be defined in the OBPOS_PRINT_TEMPLATE file to add it by default.
Go to the organization window having the giftcards module installed and the credit notes configured.

Check that the 'Credit Note Template' field is empty.

Load the Web POS and create a credit note.

Check that the credit note template is printed.
No tags attached.
Issue History
2017-11-21 13:15asiermartirenaNew Issue
2017-11-21 13:15asiermartirenaAssigned To => Retail
2017-11-21 13:15asiermartirenaResolution time => 1512428400
2017-11-21 13:15asiermartirenaTriggers an Emergency Pack => No
2017-11-21 13:24asiermartirenaDescription Updatedbug_revision_view_page.php?rev_id=16331#r16331
2017-11-30 18:37hgbotCheckin
2017-11-30 18:37hgbotNote Added: 0100844
2017-11-30 18:37hgbotStatusnew => resolved
2017-11-30 18:37hgbotResolutionopen => fixed
2017-11-30 18:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e5b78d273dd8115535fd5114d91ad3df2e3af2fe [^]
2017-11-30 18:37hgbotCheckin
2017-11-30 18:37hgbotNote Added: 0100845
2017-11-30 18:40dmiguelezNote Added: 0100846
2017-11-30 18:40dmiguelezStatusresolved => new
2017-11-30 18:40dmiguelezResolutionfixed => open
2017-12-05 18:01marvintmCategoryGift cards and gift vouchers => Web POS
2017-12-06 13:03ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-12-06 13:03ranjith_qualiantech_comStatusnew => scheduled
2017-12-07 12:03hgbotCheckin
2017-12-07 12:03hgbotNote Added: 0100935
2017-12-08 07:04ranjith_qualiantech_comStatusscheduled => resolved
2017-12-08 07:04ranjith_qualiantech_comResolutionopen => fixed
2017-12-11 09:58marvintmReview Assigned To => marvintm
2017-12-11 09:58marvintmStatusresolved => closed
2017-12-11 09:58marvintmFixed in Version => RR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101504
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101505

Notes
(0100844)
hgbot   
2017-11-30 18:37   
Repository: erp/devel/pi
Changeset: e5b78d273dd8115535fd5114d91ad3df2e3af2fe
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Nov 30 18:02:35 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e5b78d273dd8115535fd5114d91ad3df2e3af2fe [^]

Fixes issue 37344: If same product is consumed and produced in same BOM
Production, produced transaction cost is calculated first

Before calculating the cost of a BOMPart transaction, cost of BOMProduction
transactions for the same product in previous production plans are calculated.

This fix is a contribution of Support Team.

---
M src/org/openbravo/costing/CostingAlgorithm.java
---
(0100845)
hgbot   
2017-11-30 18:37   
Repository: erp/devel/pi
Changeset: 1fde3c15b1a67f46b932af0561e070db8bb35e0b
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Nov 30 18:31:38 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1fde3c15b1a67f46b932af0561e070db8bb35e0b [^]

Related to Issue 37344. Code Review changes.

Moved query logic into it's own method.

---
M src/org/openbravo/costing/CostingAlgorithm.java
---
(0100846)
dmiguelez   
2017-11-30 18:40   
Wrong commit message
(0100935)
hgbot   
2017-12-07 12:03   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: cc456d6165c416f8552f43e58529b00080a19bb7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 07 16:33:21 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/cc456d6165c416f8552f43e58529b00080a19bb7 [^]

Related to issue 37344 : Added CreditNote to print templates

---
M src-db/database/sourcedata/OBPOS_PRINT_TEMPLATE.xml
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---
(0101504)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101505)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test