Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037333Retail ModulesWeb POSpublic2017-11-20 17:592017-12-20 18:58
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037333: Improve performance of characteristic query
DescriptionImprove the performance of characteristic query when no filter by name and upc has been applied.
Steps To ReproduceUsing remote mode for products
Login WebPOS
Tap on product clear button, characteristic request is done
Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-20 17:59SandrahuguetNew Issue
2017-11-20 17:59SandrahuguetAssigned To => Sandrahuguet
2017-11-20 17:59SandrahuguetTriggers an Emergency Pack => No
2017-11-20 18:00SandrahuguetReview Assigned To => marvintm
2017-11-20 18:00SandrahuguetTag Attached: Performance
2017-11-21 16:18hgbotCheckin
2017-11-21 16:18hgbotNote Added: 0100654
2017-11-21 16:18hgbotStatusnew => resolved
2017-11-21 16:18hgbotResolutionopen => fixed
2017-11-21 16:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3123e163d6261a2bf045aa6efe5be799321a566 [^]
2017-11-30 11:53SandrahuguetStatusresolved => new
2017-11-30 11:53SandrahuguetResolutionfixed => open
2017-12-15 08:11hgbotCheckin
2017-12-15 08:11hgbotNote Added: 0101048
2017-12-15 08:18SandrahuguetStatusnew => scheduled
2017-12-15 08:18SandrahuguetStatusscheduled => resolved
2017-12-15 08:18SandrahuguetResolutionopen => fixed
2017-12-19 16:02SandrahuguetStatusresolved => new
2017-12-19 16:02SandrahuguetResolutionfixed => open
2017-12-19 16:12SandrahuguetNote Added: 0101136
2017-12-19 16:12SandrahuguetNote Added: 0101137
2017-12-19 16:16SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=16474#r16474
2017-12-20 08:49hgbotCheckin
2017-12-20 08:49hgbotNote Added: 0101156
2017-12-20 08:49hgbotStatusnew => resolved
2017-12-20 08:49hgbotResolutionopen => fixed
2017-12-20 08:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3123e163d6261a2bf045aa6efe5be799321a566 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3488eeea5c3f2c71d63d455ac5e03faefa40876e [^]
2017-12-20 08:49hgbotCheckin
2017-12-20 08:49hgbotNote Added: 0101158
2017-12-20 18:58marvintmStatusresolved => closed
2017-12-20 18:58marvintmFixed in Version => RR18Q1

Notes
(0100654)
hgbot   
2017-11-21 16:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3123e163d6261a2bf045aa6efe5be799321a566
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Nov 20 18:04:06 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3123e163d6261a2bf045aa6efe5be799321a566 [^]

fixed issue 37333 delete unnecessary join and filter in characteristic query

---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
---
(0101048)
hgbot   
2017-12-15 08:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 94453199f2b046271938bcd9a3b2e907873a649d
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Nov 29 10:31:53 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/94453199f2b046271938bcd9a3b2e907873a649d [^]

related to issue 37333 fixed when remote filter use contains

---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
---
(0101136)
Sandrahuguet   
2017-12-19 16:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3123e163d6261a2bf045aa6efe5be799321a566
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue, 19 Dec 2017 16:08:19 +0100
URL: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/47adaa02a309 [^]

Backed out changeset 94453199f2b0
---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
(0101137)
Sandrahuguet   
2017-12-19 16:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3123e163d6261a2bf045aa6efe5be799321a566
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue, 19 Dec 2017 16:08:19 +0100
URL: https: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8bae066b78c [^]

Backed out changeset e3123e163d62---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
(0101156)
hgbot   
2017-12-20 08:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3488eeea5c3f2c71d63d455ac5e03faefa40876e
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Dec 19 16:31:56 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3488eeea5c3f2c71d63d455ac5e03faefa40876e [^]

Fixed bug 37333 filter by name only when is necessary in characteristics

Filter by name and upc only when is necessary, when this filter is not send
we should avoid this filter and the join with m_product table. The performance
of characteristic query improves considerably.

---
M src/org/openbravo/retail/posterminal/BrandProductHQLCriteria.java
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
M src/org/openbravo/retail/posterminal/ProductCharacteristicHQLCriteria.java
---
(0101158)
hgbot   
2017-12-20 08:49   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: b7be2ec5446519b25256faa121d829d95d51261f
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Dec 19 16:46:02 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/b7be2ec5446519b25256faa121d829d95d51261f [^]

related to bug 37333 filter by name only when is necessary in characteristics

Filter by name and upc only when is necessary, when this filter is not send
we should avoid this filter and the join with m_product table. The performance
of characteristic query improves considerably.

---
M src/org/openbravo/retail/bestsellers/BrandBestSellerHQLCriteria.java
M src/org/openbravo/retail/bestsellers/PCharacteristicBestSellerHQLCriteria.java
M src/org/openbravo/retail/bestsellers/PCharacteristicValueBestSellerHQLCriteria.java
---