Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037278Openbravo ERPA. Platformpublic2017-11-13 10:582018-01-03 12:39
Reportermalsasua 
Assigned Toinigosanchez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-04-06
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c4a5973bba10 [^]
Triggers an Emergency PackNo
Summary0037278: Deactivated roles are displayed in the role dropdown of user section
DescriptionThe deactivated roles are displayed in the dropdown of roles availables to the user.
Steps To Reproduce1. Login as "F&B International Group Admin" role with "Openbravo" user.
2. Go to [User] window and select Openbravo user.
3. Go to [User Roles] subtab and deactivated a role.(e.g. "F&B US, Inc. - Employee").
4. Do logout and login with previous user.
5. Open [User profile widget] and open the role dropdown.
  --> Check than deactivated rol is shown.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00372813.0PR17Q4 closed inigosanchez Deactivated roles are displayed in the role dropdown of user section 
depends on backport 00372823.0PR17Q3.2 closed inigosanchez Deactivated roles are displayed in the role dropdown of user section 
caused by feature request 0035553 closed caristu Improve scalability of the login process 
related to defect 0037289 closed inigosanchez It is not possible to do login using a role if the role has got a deactivated organization 
Attached Filespng errorRol.png (155,616) 2017-11-13 12:57
https://issues.openbravo.com/file_download.php?file_id=11282&type=bug
png

png errorRol2.png (190,564) 2017-11-13 12:57
https://issues.openbravo.com/file_download.php?file_id=11283&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-11-13 10:58malsasuaNew Issue
2017-11-13 10:58malsasuaAssigned To => platform
2017-11-13 10:58malsasuaOBNetwork customer => Yes
2017-11-13 10:58malsasuaModules => Core
2017-11-13 10:58malsasuaTriggers an Emergency Pack => No
2017-11-13 12:24inigosanchezStatusnew => scheduled
2017-11-13 12:24inigosanchezAssigned Toplatform => inigosanchez
2017-11-13 12:57malsasuaFile Added: errorRol.png
2017-11-13 12:57malsasuaFile Added: errorRol2.png
2017-11-13 12:58inigosanchezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16275#r16275
2017-11-13 12:59caristuNote Added: 0100479
2017-11-13 13:01caristuNote Edited: 0100479bug_revision_view_page.php?bugnote_id=0100479#r16277
2017-11-13 13:04caristuRegression level => Production - QA Approved
2017-11-13 13:04caristuRegression date => 2017-04-06
2017-11-13 13:04caristuRegression introduced in release => 3.0PR17Q3
2017-11-13 13:04caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c4a5973bba10 [^]
2017-11-13 13:07caristuRelationship addedcaused by 0035553
2017-11-13 13:29inigosanchezStatusscheduled => acknowledged
2017-11-13 13:29inigosanchezStatusacknowledged => scheduled
2017-11-13 15:15inigosanchezReview Assigned To => caristu
2017-11-14 14:13hgbotCheckin
2017-11-14 14:13hgbotNote Added: 0100518
2017-11-14 14:16hgbotCheckin
2017-11-14 14:16hgbotNote Added: 0100519
2017-11-14 14:16hgbotStatusscheduled => resolved
2017-11-14 14:16hgbotResolutionopen => fixed
2017-11-14 14:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/50ec19da3e97d69075825368d2b4add0f95eacc1 [^]
2017-11-14 17:09caristuNote Added: 0100521
2017-11-14 17:30caristuRelationship addedrelated to 0037289
2017-11-14 18:44hgbotCheckin
2017-11-14 18:44hgbotNote Added: 0100524
2017-11-15 14:19hgbotCheckin
2017-11-15 14:19hgbotNote Added: 0100528
2017-11-15 14:19hgbotCheckin
2017-11-15 14:19hgbotNote Added: 0100529
2017-11-16 09:53hgbotCheckin
2017-11-16 09:53hgbotNote Added: 0100542
2017-11-16 10:37caristuNote Added: 0100545
2017-11-16 10:37caristuStatusresolved => closed
2017-11-16 10:37caristuFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101418
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101419
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101421
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101422
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101423
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101425

Notes
(0100479)
caristu   
2017-11-13 12:59   
(edited on: 2017-11-13 13:01)
The problem is caused by this changeset: https://code.openbravo.com/erp/devel/pi/diff/c4a5973bba10/modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java [^]

When improving the performance of the query, the OBQuery instance used to generate it was replaced with a Query instance. The first includes by default the filter by is active. To fix the problem this filter must be added manually.
(0100518)
hgbot   
2017-11-14 14:13   
Repository: erp/devel/pi
Changeset: e93ad7f316fcbb91f7a65428f8102544132dff09
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 14:13:19 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e93ad7f316fcbb91f7a65428f8102544132dff09 [^]

Related with issue 37278: Added test case

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
A src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100519)
hgbot   
2017-11-14 14:16   
Repository: erp/devel/pi
Changeset: 50ec19da3e97d69075825368d2b4add0f95eacc1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 14:15:07 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/50ec19da3e97d69075825368d2b4add0f95eacc1 [^]

Fixed issue 37278: Deactivated roles are displayed in the user profile widget

The problem was caused by the "Improve scalability of the login process" project. When improving the performance
of the query that return the complete role list for the current user, the OBQuery instance used to generate it was
replaced with a Query instance. The first includes by default the filter by is active.

To fix the problem this filter must be added manually in the query. Now the problem has been resolved by take into
account this filter.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java
---
(0100521)
caristu   
2017-11-14 17:09   
Some code review improvements for the new test case: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0100524)
hgbot   
2017-11-14 18:44   
Repository: erp/devel/pi
Changeset: 7660b737bf80dd735a9e7765e4c541e97b00bacd
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Nov 14 18:43:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7660b737bf80dd735a9e7765e4c541e97b00bacd [^]

Related with issue 37278: Code review improvements for the test case

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100528)
hgbot   
2017-11-15 14:19   
Repository: erp/devel/pi
Changeset: f8d496311f36bda45a1d46d08b680ee6cda23e0b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Nov 15 14:15:27 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f8d496311f36bda45a1d46d08b680ee6cda23e0b [^]

Related with issue 37278: Test is defined in the wrong suite

Moved test case to the AllWebserviceTests suite.

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/AllWebserviceTests.java
---
(0100529)
hgbot   
2017-11-15 14:19   
Repository: erp/devel/pi
Changeset: 69bfa2a635a4fae471eaf849698020971c2284c4
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Nov 15 14:18:09 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/69bfa2a635a4fae471eaf849698020971c2284c4 [^]

Related with issue 37278: Improve log errors in the testcase

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100542)
hgbot   
2017-11-16 09:53   
Repository: erp/devel/pi
Changeset: 73796483a567e952d4d4b22e7463c212d338df88
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Nov 16 09:53:06 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/73796483a567e952d4d4b22e7463c212d338df88 [^]

Related with issue 37278: improvement in the message of the assertion

---
M src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
---
(0100545)
caristu   
2017-11-16 10:37   
Code reviewed + tested OK.
(0101418)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101419)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101421)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101422)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101423)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101425)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test