Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037261Openbravo ERPA. Platformpublic2017-11-08 11:572017-11-10 13:08
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q4Fixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-05-08
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/554d8c055ea2e7cb078c405634e41c14079bd61e [^]
Triggers an Emergency PackNo
Summary0037261: Some labels are not properly translated after switching the language
DescriptionSome labels are not properly translated after switching the language. This can be reproduced when there are not modules in "in development" status because in that case the labels are being cached in the client since the changes introduced with the issue 0035852
Steps To Reproduce1) Install the Spanish Localization pack
2) Ensure that there are not modules in "in development" status
3) Log-in as F&B International Group (it has English language by default)
4) Switch to the Spanish language
5) Note that some labels do no appear translated: in the toolbar, profile widget or in the workspace (see attached image).
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037259 closed caristu Some labels are not properly translated after switching the language 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-08 12:29caristuTypedefect => backport
2017-11-08 12:29caristuTarget Version => 3.0PR17Q4
2017-11-08 19:23hgbotCheckin
2017-11-08 19:23hgbotNote Added: 0100366
2017-11-08 19:23hgbotStatusscheduled => resolved
2017-11-08 19:23hgbotResolutionopen => fixed
2017-11-08 19:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q4/rev/126e6c88713390cfce4ba9808d08ec93b2cc8fce [^]
2017-11-08 19:23hgbotCheckin
2017-11-08 19:23hgbotNote Added: 0100367
2017-11-08 19:23caristuReview Assigned To => alostale
2017-11-10 13:08alostaleNote Added: 0100434
2017-11-10 13:08alostaleStatusresolved => closed
2017-11-10 13:08alostaleFixed in Version => 3.0PR17Q4

Notes
(0100366)
hgbot   
2017-11-08 19:23   
Repository: erp/backports/3.0PR17Q4
Changeset: 126e6c88713390cfce4ba9808d08ec93b2cc8fce
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 08 19:21:16 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4/rev/126e6c88713390cfce4ba9808d08ec93b2cc8fce [^]

fixes issue 37261: Some labels are not translated after switching the language

  After the changes introduced on issue 0035852 the labels were being cached together with the rest of the static javascript code. Thus, being in an environment not in "in development" status, the labels were being cached in the language of the first login avoiding the translation when switching to another language afterwards.

  To fix the problem now the component responsible of collecting the labels has been defined as a session dynamic component. This way the labels will be retrieved on every login. And to avoid querying to the database on each login request, the labels are now being cached in the server per language.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/I18NComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
---
(0100367)
hgbot   
2017-11-08 19:23   
Repository: erp/backports/3.0PR17Q4
Changeset: a0defd938236b5e013ffb8c03707a5a0165cfa1b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 08 19:22:12 2017 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4/rev/a0defd938236b5e013ffb8c03707a5a0165cfa1b [^]

related to issue 37261: adapt test cases to the new component's definition

---
M modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/GenerateComponentTest.java
M modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/LabelTest.java
---
(0100434)
alostale   
2017-11-10 13:08   
tested + reviewed