Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037260Retail ModulesWeb POSpublic2017-11-08 12:132024-02-08 14:46
jorge-garcia 
rqueralta 
normalmajorsometimes
closedout of date 
5
 
 
No
0037260: Combos and Pack are not working properly in some cases
Depending on configuration of combos/pack if the user tries to add a combo or a pack from the Browse category it's possible that the discount engine add another combo or pack.
1) Go to backend and go to Discount & Promotions window
 1.1) Configure Camping Pack with priority 10
 1.2) Configure Camping Pack Plus with priority 20
2) Go to webPOS and login
 2.1) Go to Browse tab and select the record Camping Pack Plus in Pack category.
 2.2) Realize the products are added, but the promotion applied is Camping Pack instead of Camping Pack Plus (this is wrong)
No tags attached.
related to defect 0037114 closed jorge-garcia By total discounts should ignore discount priority and be calculated at the end 
diff fix_I37260.diff (1,115) 2018-01-10 15:34
https://issues.openbravo.com/file_download.php?file_id=11437&type=bug
Issue History
2017-11-08 12:13jorge-garciaNew Issue
2017-11-08 12:13jorge-garciaAssigned To => Retail
2017-11-08 12:13jorge-garciaTriggers an Emergency Pack => No
2017-11-08 12:38jorge-garciaRelationship addedrelated to 0037114
2017-11-08 15:53hgbotCheckin
2017-11-08 15:53hgbotNote Added: 0100356
2017-12-29 14:59rqueraltaAssigned ToRetail => rqueralta
2017-12-29 14:59rqueraltaStatusnew => scheduled
2018-01-05 15:46hgbotCheckin
2018-01-05 15:46hgbotNote Added: 0101603
2018-01-05 15:46hgbotStatusscheduled => resolved
2018-01-05 15:46hgbotResolutionopen => fixed
2018-01-05 15:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e06a666ec44168e1a444fe33e59e1f7d1cdd276d [^]
2018-01-08 15:31hgbotCheckin
2018-01-08 15:31hgbotNote Added: 0101622
2018-01-08 21:06rqueraltaStatusresolved => new
2018-01-08 21:06rqueraltaResolutionfixed => open
2018-01-08 21:06rqueraltaStatusnew => scheduled
2018-01-10 15:33rqueraltaNote Added: 0101656
2018-01-10 15:34rqueraltaFile Added: fix_I37260.diff
2024-02-08 14:46shuehnerNote Added: 0160466
2024-02-08 14:46shuehnerStatusscheduled => closed
2024-02-08 14:46shuehnerResolutionopen => out of date

Notes
(0100356)
hgbot   
2017-11-08 15:53   
Repository: tools/automation/pi-mobile
Changeset: 63440baf06468b280d0b3a528f551e28921bfc39
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 08 12:16:28 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/63440baf06468b280d0b3a528f551e28921bfc39 [^]

Related to issue 37260: Combos and Pack are not working properly in some cases

Deactivate test until it's fixed

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28120_SameProductInTwoPacks.java
---
(0101603)
hgbot   
2018-01-05 15:46   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: e06a666ec44168e1a444fe33e59e1f7d1cdd276d
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Fri Dec 29 07:29:19 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e06a666ec44168e1a444fe33e59e1f7d1cdd276d [^]

Fixed issue 37260: Combos and Pack are not working properly in some cases

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0101622)
hgbot   
2018-01-08 15:31   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: ae0aef42b3c4d168e8a428604ffe5421d43ab168
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Mon Jan 08 09:28:48 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/ae0aef42b3c4d168e8a428604ffe5421d43ab168 [^]

Related to issue 37260: Combos and Pack are not working properly in some cases

- Backed out changeset: e06a666ec441

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0101656)
rqueralta   
2018-01-10 15:33   
Attached diff with incomplete solution for this issue. The steps to reproduce of this issue are solved, but the following case is not covered with this solution:

Go to webPOS and login
 Add Camping Pack Plus pack to the receipt
 Realize the products are added and Camping Pack Plus promotion is applied (is correct)
 Add Camping Pack pack to the receipt
 Realize the products are added and just (2x)Camping Pack promotion is applied(this is wrong)
(0160466)
shuehner   
2024-02-08 14:46   
After mass reviewing old pos issues in 52891 => Closing as out of date