Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037255Openbravo ERPA. Platformpublic2017-11-08 08:452018-01-03 12:38
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket49188
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037255: Wrong behavior when filtering in tree grid view of a child tab and pressing 'Enter' key to confirm the filter
DescriptionThe record disappears on the grid tree view of a child tab when applying a filter in a drop down and pressing the 'Enter' key to confirm.
Steps To Reproduce1) Open [Product Characteristic] window
2) Create a record in the header
3) Move to the [Value] subtab
  3a) Create a summary level value
  3b) Create a non summary level value
4) Switch to 'tree grid view' (press the button on the toolbar)
5) Drag and drop the non-summary level value as child of the summary level value
6) Filter by 'Name' to show the child value. Then press 'Enter' key (do not press any other key). Note that the tree is collapsed.
Proposed SolutionThe problem is that fix for issue 0037181 does not cover the case of trees displayed in subtabs because of the fact that the filtering criteria in those cases includes the id of the parent record.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037181 closed caristu Wrong behavior when filtering in tree grid view and pressing 'Enter' key to confirm the filter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-08 08:45caristuNew Issue
2017-11-08 08:45caristuAssigned To => caristu
2017-11-08 08:45caristuOBNetwork customer => Yes
2017-11-08 08:45caristuModules => Core
2017-11-08 08:45caristuSupport ticket => 49188
2017-11-08 08:45caristuTriggers an Emergency Pack => No
2017-11-08 08:45caristuIssue generated from0037181
2017-11-08 08:45caristuDescription Updatedbug_revision_view_page.php?rev_id=16249#r16249
2017-11-08 08:47caristuProposed Solution updated
2017-11-08 08:47caristuRelationship addedrelated to 0037181
2017-11-08 09:14hgbotCheckin
2017-11-08 09:14hgbotNote Added: 0100330
2017-11-08 09:14hgbotStatusnew => resolved
2017-11-08 09:14hgbotResolutionopen => fixed
2017-11-08 09:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7f4ca5834b80791b3e668feb4a94c887d41daeaf [^]
2017-11-08 09:26hgbotCheckin
2017-11-08 09:26hgbotNote Added: 0100331
2017-11-08 16:14caristuReview Assigned To => alostale
2017-11-10 13:33alostaleNote Added: 0100444
2017-11-10 13:33alostaleStatusresolved => closed
2017-11-10 13:33alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101379
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101380

Notes
(0100330)
hgbot   
2017-11-08 09:14   
Repository: erp/devel/pi
Changeset: 7f4ca5834b80791b3e668feb4a94c887d41daeaf
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 08 08:52:55 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f4ca5834b80791b3e668feb4a94c887d41daeaf [^]

fixes bug 37255: Tree in subtab is closed after pressing 'Enter' key to filter

Being on a child tab, the fix for issue 0037181 was not complete because it was comparing the entered criteria without including the criterion with the parent record id. Thus when comparing the current criteria and the entered criteria they were always different.

Now we are completing the fix by converting the entered criteria in order to include the filtering criterion by parent id.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-tree-grid.js
---
(0100331)
hgbot   
2017-11-08 09:26   
Repository: erp/devel/pi
Changeset: 8cb4ac05194f9dd9c2f914cc6dea814353d7ea1c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Nov 08 09:24:36 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8cb4ac05194f9dd9c2f914cc6dea814353d7ea1c [^]

related to issue 37255: Do not call convertCriteria twice

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-tree-grid.js
---
(0100444)
alostale   
2017-11-10 13:33   
reviewed + tested
(0101379)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101380)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test