Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037240Retail ModulesWeb POSpublic2017-11-07 12:132017-11-30 17:11
Reporterguilleaer 
Assigned Togorka_gil 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037240: Layaways and attributes. Allow to work without attributes until layaway is completely paid
DescriptionCurrent implementation of attributes support forces to the user to provide an attribute value to the products which are configured to use attributes even when a layaway is being created.

This is not correct. A layaway can be created without any attribute or veen more, it can be created with one attribute and change the value of this attribute in following revisions of the layaway.

for sure, it is mandatory to provide information about attributes when the layaway is going to be completely paid. At this point a process should check that attribute information is provided.
Steps To ReproduceN/A
Proposed Solution1. Using layaways when value for att must be added... the user can close the popup
2. Later on, using an orange button the user can reopen this popup and modify or fill (if it is empty) the att values
   -> It requires changes in order loader to detect these attValue changes
3. When layaway is paid, validate in the client side that all lines wich uses atts are properly informed
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0036966 closed guilleaer When entering the attribute value, the user shouldn't need to follow internal Openbravo format 
Attached Filesdiff patch-i37240-for-3.0RR17Q3.1.diff (23,222) 2017-11-17 14:35
https://issues.openbravo.com/file_download.php?file_id=11300&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-11-07 12:13guilleaerNew Issue
2017-11-07 12:13guilleaerAssigned To => gorka_gil
2017-11-07 12:13guilleaerTriggers an Emergency Pack => No
2017-11-07 12:15gorka_gilStatusnew => scheduled
2017-11-07 13:18guilleaerProposed Solution updated
2017-11-13 11:36gorka_gilRelationship addedrelated to 0036966
2017-11-17 14:35gorka_gilFile Added: patch-i37240-for-3.0RR17Q3.1.diff
2017-11-17 14:48plujanSummaryLayawayas and attributes. Allow to work without attributes until layaway is completely paid => Layaways and attributes. Allow to work without attributes until layaway is completely paid
2017-11-20 14:05hgbotCheckin
2017-11-20 14:05hgbotNote Added: 0100623
2017-11-20 14:05hgbotStatusscheduled => resolved
2017-11-20 14:05hgbotResolutionopen => fixed
2017-11-20 14:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/87752d6cee0547e43bc7d7f3e20be48cf6e413d7 [^]
2017-11-30 17:11marvintmReview Assigned To => marvintm
2017-11-30 17:11marvintmStatusresolved => closed
2017-11-30 17:11marvintmFixed in Version => RR18Q1

Notes
(0100623)
hgbot   
2017-11-20 14:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 87752d6cee0547e43bc7d7f3e20be48cf6e413d7
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Nov 16 19:26:27 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/87752d6cee0547e43bc7d7f3e20be48cf6e413d7 [^]

Fixes issue 37240: Layawayas and attributes. Allow to work without attributes until layaway is completely paid

- Allow attributes popup to save empty values, only when is a layaway
- In the receipt lines, show attribute information with missing value in red
- Add button to edit attributes, in the edit lines mode
- Move to a function the code to check the serial attributes duplicated,
  so can be called when adding new line and when modifiying an attribute of a line
- This check of serial number duplicated now is not executed with null attribute values
- Change modal attribute product
   - on hide don't show execute the callback, since no needed
   - added cancelled parame in the callback of cancel, so we can do nothing on cancel
   - on start load the value of the current line attribute value
   - change read always from attSetInstanceDesc if set, and write to attributeValue.
     When writing also unset the attSetInstanceDesc
- Modify order loader to edit attributes in each execution, instead only in the creation of the ticket
- Added validations in client, that when layaway is fully paid, all attributes must have value,
  if not the done button is disabled
- Added validation when changing from layaway to receipt, to check that all attributes has value
- The checks done changing from layaway to recipt are now warnings instead errors

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalproductattribute.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---