Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037227Retail ModulesStoreServerpublic2017-11-06 10:182017-11-08 12:33
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR18Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037227: Prevent incorrect setting of max retries to stop any requests from happening between store and central
DescriptionIf the preference OBMOBC_NumberOfRequestRetries is set to zero then the code here [1] will prevent any request from happening between store and central server.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/421de0d299e9/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l172 [^]
Steps To ReproduceInstall multiserver
Run it
Set preference OBMOBC_NumberOfRequestRetries to zero
Goto window store server version overview, see that no results are obtained (status unknown is shown)
Proposed Solutionlog an error and use minimum max-retries of 1
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-06 10:18mtaalNew Issue
2017-11-06 10:18mtaalAssigned To => mtaal
2017-11-06 10:18mtaalOBNetwork customer => No
2017-11-06 10:18mtaalTriggers an Emergency Pack => No
2017-11-07 15:12mtaalStatusnew => acknowledged
2017-11-07 15:12mtaalReview Assigned To => AugustoMauch
2017-11-08 09:01hgbotCheckin
2017-11-08 09:01hgbotNote Added: 0100329
2017-11-08 09:01hgbotStatusacknowledged => resolved
2017-11-08 09:01hgbotResolutionopen => fixed
2017-11-08 09:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f21e14b092a045a017abaf9b5d96ed76e14c7dd0 [^]
2017-11-08 12:33AugustoMauchNote Added: 0100347
2017-11-08 12:33AugustoMauchStatusresolved => closed
2017-11-08 12:33AugustoMauchFixed in Version => RR18Q1

Notes
(0100329)
hgbot   
2017-11-08 09:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f21e14b092a045a017abaf9b5d96ed76e14c7dd0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Nov 08 09:00:45 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f21e14b092a045a017abaf9b5d96ed76e14c7dd0 [^]

fixes issue 37249, fixes issue 37227: For server to server requests set read and connection time out
Set defaults for read and connection timeout and make them configurable
Make sure max retries has minimum value of 1

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0100347)
AugustoMauch   
2017-11-08 12:33   
Code reviewed and verified