Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037222Openbravo ERP03. Procurement managementpublic2017-11-03 15:082021-08-09 15:09
Reporterngarcia 
Assigned Tononofrancisco 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket49286
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037222: Goods receipt created with Generate Receipt From Invoice still linked to the invoice after reactivating and deleting its lines
DescriptionGoods receipt created with Generate Receipt From Invoice still linked to the invoice after reactivating and deleting its lines

C_INVOICE_ID column of M_INOUT table keeps the relation with the original invoice
Steps To ReproduceAs system admin role:
   Set as Generate Receipt From Invoice field displayed in Purchase Invoice window
   Compile and restart tomcat

As group admin role:
   Create a Purchase Invoice, add a line to it and complete it
   Generate Receipt From Invoice
   Reactivate the Purchase Invoice, delete its lines and change its business partner
   Add a new product and complete it
   Go to Goods Receipt window, create a header and select this invoice in Create Lines From process
   Complete the goods receipt

   Check the Purchase Invoice is linked to both Goods Receipts (Linked Items)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-03 15:08ngarciaNew Issue
2017-11-03 15:08ngarciaAssigned To => Triage Finance
2017-11-03 15:08ngarciaOBNetwork customer => Yes
2017-11-03 15:08ngarciaModules => Core
2017-11-03 15:08ngarciaSupport ticket => 49286
2017-11-03 15:08ngarciaResolution time => 1511478000
2017-11-03 15:08ngarciaTriggers an Emergency Pack => No
2017-11-03 15:09ngarciaIssue Monitored: networkb
2017-11-06 11:00dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2017-11-06 21:07nonofranciscoAssigned ToAtulOpenbravo => nonofrancisco
2017-11-06 21:08nonofranciscoStatusnew => scheduled
2017-11-07 15:47nonofranciscoNote Added: 0100310
2017-11-13 16:38hgbotCheckin
2017-11-13 16:38hgbotNote Added: 0100497
2017-11-13 16:38hgbotStatusscheduled => resolved
2017-11-13 16:38hgbotResolutionopen => fixed
2017-11-13 16:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d8e4486f08d768a164cfcaba0d766a956465d680 [^]
2017-11-13 16:39dmiguelezReview Assigned To => dmiguelez
2017-11-13 16:39dmiguelezNote Added: 0100498
2017-11-13 16:39dmiguelezStatusresolved => closed
2017-11-13 16:39dmiguelezFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101416
2021-07-21 10:57hgbotNote Added: 0130643
2021-08-09 15:09hgbotNote Added: 0131044

Notes
(0100310)
nonofrancisco   
2017-11-07 15:47   
Test Plan:

As system admin role:
   Set as Generate Receipt From Invoice field displayed in Purchase Invoice window
   Do ant compile.complete and restart tomcat

As group admin role:
- Create a Purchase Invoice
  Organization: F&B España - Región Norte
  Business Partner: Bebidas Alegres, S.L.
  - Create a line
    Product: Cerveza Ale 0,5L
- Complete the document
- Generate Receipt From Invoice
- Go to Linked Item section of Purchase Invoice and verify there is only one link to Goods Receipt - Header pointing to the receipt created previously
- Reactivate the Purchase Invoice, delete its lines and change its business partner to Refrescos Naturales, S.A.
  - Create a line
     Product: Agua sin Gas 1L
- Complete the document
- Go to Linked Item section of Purchase Invoice and verify there is no link to Goods Receipt
- Create a new Goods Receipt
  Business Partner: Refrescos Naturales, S.A.
  - Use Create Lines From process to add a line to Goods Receipt
    Business Partner: Refrescos Naturales, S.A.
    Invoice: The one previously created
- Complete the goods receipt
- Go to Purchase Invoice Window
- Go to Linked Item section of previously created Purchase Invoice and verify there is only one link to Goods Receipt - Header pointing to the last receipt created
(0100497)
hgbot   
2017-11-13 16:38   
Repository: erp/devel/pi
Changeset: d8e4486f08d768a164cfcaba0d766a956465d680
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Mon Nov 13 13:27:49 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d8e4486f08d768a164cfcaba0d766a956465d680 [^]

Fixes issue 37222: Goods receipt created with Generate Receipt From Invoice still
linked to the invoice after reactivating and deleting its lines

When deleting all lines of Purchase Invoice, if exists a Good Receipt referencing
that invoice, the reference is removed.

---
M src/org/openbravo/event/InvoiceLineEventHandler.java
---
(0100498)
dmiguelez   
2017-11-13 16:39   
Code Review + Testing Ok
(0101416)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0130643)
hgbot   
2021-07-21 10:57   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c51d47c0401a38e1df9549b772d11f9a43683b01
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-07-21T10:07:12+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c51d47c0401a38e1df9549b772d11f9a43683b01 [^]

Related to ISSUE-37222. Remove 2 more useless ad_process entries

Both processes had the procedurename (pl-function) field filled but no
funtion with those name exist.

---
M src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/sourcedata/AD_PROCESS_PARA.xml
---
(0131044)
hgbot   
2021-08-09 15:09   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4e657f4c8846bc1356bed791d72a453ab7beb4e3
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-08-09T15:03:34+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4e657f4c8846bc1356bed791d72a453ab7beb4e3 [^]

Related to ISSUE-37222: Adapted test to use another Process Param

The process param's term "Target Payment Rule" used in the testAdProcessParaExcludedTranslation
test was deleted, making the test to fail.

Changed the test's term to another one to test the same scenario.

---
M src-test/src/org/openbravo/test/reducedtranslation/ReducedTranslationExportTests.java
---