Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037219Openbravo ERP09. Financial managementpublic2017-11-03 13:302018-01-08 18:25
Reporterdmiguelez 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037219: Remove function getPeriod from TransactionsDao class
DescriptionRemove function getPeriod from TransactionsDao class. When related issue is fixed, this function is no longer used.

Also, it should have been declared as private in the first place.

It should not be public API.
Steps To ReproduceRemove function getPeriod from TransactionsDao class. When related issue is fixed, this function is no longer used.

Also, it should have been declared as private in the first place.

It should not be public API.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037156 closed AtulOpenbravo Cannot unpost a financial account transaction reconciled with a previous period's date: c_period_id is null in fact_acct 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-11-03 13:30dmiguelezNew Issue
2017-11-03 13:30dmiguelezAssigned To => Triage Finance
2017-11-03 13:30dmiguelezOBNetwork customer => No
2017-11-03 13:30dmiguelezModules => Core
2017-11-03 13:30dmiguelezTriggers an Emergency Pack => No
2017-11-03 13:30dmiguelezRelationship addedrelated to 0037156
2017-11-06 08:34AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2017-11-06 08:34AtulOpenbravoStatusnew => scheduled
2017-11-06 09:17hgbotCheckin
2017-11-06 09:17hgbotNote Added: 0100278
2017-11-06 09:17hgbotStatusscheduled => resolved
2017-11-06 09:17hgbotResolutionopen => fixed
2017-11-06 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/bb327498eb9d2af7deb735147d36df942309f814 [^]
2017-11-06 09:18dmiguelezNote Added: 0100279
2017-11-06 10:37dmiguelezReview Assigned To => dmiguelez
2017-11-06 10:37dmiguelezNote Added: 0100283
2017-11-06 10:37dmiguelezStatusresolved => closed
2018-01-08 18:25dmiguelezFixed in Version => 3.0PR18Q1

Notes
(0100278)
hgbot   
2017-11-06 09:17   
Repository: erp/devel/api-checks
Changeset: bb327498eb9d2af7deb735147d36df942309f814
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Nov 06 09:16:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/bb327498eb9d2af7deb735147d36df942309f814 [^]

Fixes Issue 0037219:Remove function getPeriod from
TransactionsDao class

As AccDefUtility.getCurrentPeriod to get the perid for
financial account transaction date is used in
TransactionsDao, getPeriod is no more used.

---
M java/reference/java.japi.gz
---
(0100279)
dmiguelez   
2017-11-06 09:18   
https://code.openbravo.com/erp/devel/pi/rev/28d8fe1517d7212b0ac707cfad8f555c510002ae [^]
(0100283)
dmiguelez   
2017-11-06 10:37   
Code Review + Testing Ok