Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0037205Openbravo ERPA. Platformpublic2017-11-02 07:442018-01-03 12:38
alostale 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR18Q1 
caristu
Core
No
0037205: DB connections leaked executing IssuesTest
When org.openbravo.test.dal.IssuesTest.test21360 is executed 2 connections are borrowed from pool and never returned.
1. Set up DB pool to log abandoned connections (db.pool.logAbandoned=true)
2. Execute IssuesTest
  -> check log:
[junit] Nov 01, 2017 9:17:30 AM org.apache.tomcat.jdbc.pool.ConnectionPool suspect
    [junit] WARNING: Connection has been marked suspect, possibly abandoned PooledConnection[org.postgresql.jdbc.PgConnection@7138d695][104281 ms.]:java.lang.Exception
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:1096)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:799)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:648)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:200)
    [junit] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:128)
    [junit] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnectionFromDS(JdbcExternalConnectionPool.java:130)
    [junit] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnection(JdbcExternalConnectionPool.java:110)
    [junit] at org.openbravo.dal.core.SessionHandler.getNewConnection(SessionHandler.java:300)
    [junit] at org.openbravo.service.db.DalConnectionProvider.getTransactionConnection(DalConnectionProvider.java:136)
    [junit] at org.openbravo.test.dal.IssuesTest.test21360(IssuesTest.java:827)
    ...

    [junit] Nov 01, 2017 9:17:30 AM org.apache.tomcat.jdbc.pool.ConnectionPool suspect
    [junit] WARNING: Connection has been marked suspect, possibly abandoned PooledConnection[org.postgresql.jdbc.PgConnection@1a21463f][104285 ms.]:java.lang.Exception
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getThreadDump(ConnectionPool.java:1096)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.createConnection(ConnectionPool.java:735)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:664)
    [junit] at org.apache.tomcat.jdbc.pool.ConnectionPool.getConnection(ConnectionPool.java:200)
    [junit] at org.apache.tomcat.jdbc.pool.DataSourceProxy.getConnection(DataSourceProxy.java:128)
    [junit] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnectionFromDS(JdbcExternalConnectionPool.java:130)
    [junit] at org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool.getConnection(JdbcExternalConnectionPool.java:110)
    [junit] at org.openbravo.dal.core.SessionHandler.getNewConnection(SessionHandler.java:300)
    [junit] at org.openbravo.service.db.DalConnectionProvider.getTransactionConnection(DalConnectionProvider.java:136)
    [junit] at org.openbravo.test.dal.IssuesTest.test21360(IssuesTest.java:828)
    ...
No tags attached.
related to defect 0021360 closed mtaal DalConnectionProvider getTransactionConnection() should be equal than ConnectionProviderImpl getTransactionConnection() 
Issue History
2017-11-02 07:44alostaleNew Issue
2017-11-02 07:44alostaleAssigned To => alostale
2017-11-02 07:44alostaleModules => Core
2017-11-02 07:44alostaleTriggers an Emergency Pack => No
2017-11-02 07:52alostaleReview Assigned To => caristu
2017-11-02 08:55hgbotCheckin
2017-11-02 08:55hgbotNote Added: 0100209
2017-11-02 08:55hgbotStatusnew => resolved
2017-11-02 08:55hgbotResolutionopen => fixed
2017-11-02 08:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ae1e2a4620047aa034a1f9a4ab7d6cc350556e44 [^]
2017-11-10 09:35caristuRelationship addedrelated to 0021360
2017-11-10 09:36caristuNote Added: 0100414
2017-11-10 09:36caristuStatusresolved => closed
2017-11-10 09:36caristuFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101366

Notes
(0100209)
hgbot   
2017-11-02 08:55   
Repository: erp/devel/pi
Changeset: ae1e2a4620047aa034a1f9a4ab7d6cc350556e44
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Nov 02 08:54:07 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ae1e2a4620047aa034a1f9a4ab7d6cc350556e44 [^]

fixed bug 37205: DB connections leaked executing IssuesTest

  * Return transactional connections to pool to prevent them to be leaked
  * Prevent Hibernate flush when getting DAL session's connection

---
M src-test/src/org/openbravo/test/dal/IssuesTest.java
---
(0100414)
caristu   
2017-11-10 09:36   
Code reviewed + tested OK.
(0101366)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test