Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037199Openbravo ERP09. Financial managementpublic2017-10-31 12:592018-01-03 12:38
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket49203
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037199: Date filtering criteria not properly carried when navigating from General Ledger Report to Journal Entries Report
Description"Date From" and "Date to" values are not properly carried when user navigates from General Ledger Report to an specific accounting entry (visualized in Journal Entries Report). However "Account no" value is properly carried
Steps To Reproduce1. Access General Ledger Report and set "Date from"= 30-06-2017, "Date to"= 30-06-2017, Organization= F&B España, From Account= 40000 Proveedores (euros) a corto plazo, To Account=40000 Proveedores (euros) a corto plazo
2. Run report in HTML format
3. Click on line with description "10001064 # SI Rapid, SA"
4. You will be carried to Journal Entries Report and invoice's accounting entry will be shown (which is ok)
5. Press "PDF" button to print this entry and realize that not only this entry is printed but all entries related with this account are printed as report is executed filtered by account by not by date from and date to

NOTE: in case of a real environment with huge amount of data server can even crash due to missed date filtering criteria
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-31 12:59maiteNew Issue
2017-10-31 12:59maiteAssigned To => Triage Finance
2017-10-31 12:59maiteOBNetwork customer => Yes
2017-10-31 12:59maiteModules => Core
2017-10-31 12:59maiteSupport ticket => 49203
2017-10-31 12:59maiteResolution time => 1511218800
2017-10-31 12:59maiteTriggers an Emergency Pack => No
2017-10-31 12:59maiteIssue Monitored: networkb
2017-10-31 13:00maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16211#r16211
2017-10-31 20:35AtulOpenbravoStatusnew => scheduled
2017-10-31 20:58AtulOpenbravoNote Added: 0100202
2017-10-31 21:04AtulOpenbravoNote Added: 0100203
2017-11-02 16:59dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2017-11-08 18:08dmiguelezNote Added: 0100359
2017-11-08 18:34hgbotCheckin
2017-11-08 18:34hgbotNote Added: 0100360
2017-11-08 18:34hgbotStatusscheduled => resolved
2017-11-08 18:34hgbotResolutionopen => fixed
2017-11-08 18:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ba2441f5afa4ef7cbc71787d258c3a64c835975 [^]
2017-11-08 18:34hgbotCheckin
2017-11-08 18:34hgbotNote Added: 0100361
2017-11-08 18:35dmiguelezReview Assigned To => dmiguelez
2017-11-08 18:35dmiguelezNote Added: 0100362
2017-11-08 18:35dmiguelezStatusresolved => closed
2017-11-08 18:35dmiguelezFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101385
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101386

Notes
(0100202)
AtulOpenbravo   
2017-10-31 20:58   
As Accounting Schema filter is mandatory, the isEmpty check does not allow to fetch the input parameter strFactAcctGroupId. Hence reports filter for the current record being opened from General Ledger Report is lost.

Applying date filters from General Ledger Report would not be the proper solution to this problem as records other than current record would be still printed whose accounting date is within the range of From Date and To Date applied.
(0100203)
AtulOpenbravo   
2017-10-31 21:04   
Test Plan

- Login as F&B International Group Admin
- Navigate to General Ledger Report,
  set From Date = 31-03-2017,
      To Date = 31-03-2017,
      Organization= F&B España,
      From Account= 40000 Proveedores (euros) a corto plazo,
      To Account=40000 Proveedores (euros) a corto plazo

- Run report in HTML format
- Click on line with description "<Document No># SI Rapid, SA"
- Realize Journal Entries Report is opened and invoice's accounting entry will be shown

- Press "PDF" button to print this entry and realize that only this entry is printed. This is OK. (Only one time single record is printed)

- Try to print again using PDF button. This time as command is set to Default, all records would get printed. This is as expected.

/*
       * Scenario 1: We will have FactAcctGroupId while the request redirect from
       * ReportGeneralLedger Report. Otherwise we don't need to use FactAcctGroupId for PDF or Excel
       * report. So we have to check the immediate history command has DIRECT2 (It means previous
       * request from ReportGeneralLedger Report) Scenario 2: If we print once in PDF, it will reset
       * the history of COMMAND with DEFAULT, so same record of redirect wont print more than one
       * time. It will consider as default in second time.Scenario 3: If user change the filter
       * criteria, however he has come from ReportGeneralLedger Report(DIRECT2) We don't take
       * strFactAcctGroupId(will take care of criteria from current screen)
       */
(0100359)
dmiguelez   
2017-11-08 18:08   
Test Plan

- Login as System Administrator
- Naviate to Preferences Window
  Filter to see the Preference With Attribute: ReportsLimit
  Change the value to 1000

Log out

- Login as F&B International Group Admin
- Navigate to General Ledger Report,
  set From Date = 31-03-2017,
      To Date = 31-03-2017,
      Organization= F&B España,
      From Account= 40000 Proveedores (euros) a corto plazo,
      To Account=40000 Proveedores (euros) a corto plazo

- Run report in HTML format
- Click on line with description "<Document No># SI Rapid, SA"
- Realize Journal Entries Report is opened and invoice's accounting entry will be shown

- Press "PDF" button to print this entry and realize that only this entry is printed. This is OK. (Only one time single record is printed)

- Try to print again using PDF button. A warning message is shown stating that the number or records to be printed is too high
(0100360)
hgbot   
2017-11-08 18:34   
Repository: erp/devel/pi
Changeset: 7ba2441f5afa4ef7cbc71787d258c3a64c835975
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Nov 07 23:31:08 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7ba2441f5afa4ef7cbc71787d258c3a64c835975 [^]

Fixes Issue 37199:Date filtering criteria not properly carried when
navigating from General Ledger Report to Journal Entries Report

** Accounting Schema Filter is mandatory in Journal Entries Report
so far fetching strFactAcctGroupId is it necessary to remove
the isEmpty check for strcAcctSchemaId as it wont be empty
in any case.

** In case of printing pdf or xls report when factacctgroup id or
record id is not passed (default), a reportslimit check is done to
avoid performance problem.

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---
(0100361)
hgbot   
2017-11-08 18:34   
Repository: erp/devel/pi
Changeset: f1b82b7deb61116080fb87b590db105cf925b45f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Nov 08 18:32:01 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f1b82b7deb61116080fb87b590db105cf925b45f [^]

Related to Issue 37199. Added comments and changed method name
to something more meaningful

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---
(0100362)
dmiguelez   
2017-11-08 18:35   
Code Review + Testing Ok
(0101385)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101386)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test