Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037170Openbravo ERPB. User interfacepublic2017-10-26 19:302018-02-22 18:18
Reportercaristu 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037170: SQL Query window has unneeded buttons
DescriptionThe SQL Query window is displaying some buttons which are useless (see attached image):

- Go to First Record
- Go Back One Record
- Go Forward One Record
- Go to Last Record
- Linked Items

Besides, when clicking on any of these buttons JS errors are thrown.
Steps To Reproduce1) Login in as System Administrator
2) Open the [SQL Query] window
3) Click on any of the buttons mentioned in the description. A JS error will be thrown in the browser's console.
Proposed SolutionDo not display those buttons
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037604 closed jarmendariz Clean up unused methods and parameters in ToolBar 
related to defect 00382583.0PR19Q2 closed shuehner Remove lots of old obsolete code from ToolBar class 
Attached Filespng sqlQueryUnusedButtons.png (76,572) 2017-10-26 19:30
https://issues.openbravo.com/file_download.php?file_id=11240&type=bug
png

patch bug-37170.patch (2,351) 2018-01-11 10:21
https://issues.openbravo.com/file_download.php?file_id=11442&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-10-26 19:30caristuNew Issue
2017-10-26 19:30caristuAssigned To => platform
2017-10-26 19:30caristuFile Added: sqlQueryUnusedButtons.png
2017-10-26 19:30caristuOBNetwork customer => No
2017-10-26 19:30caristuModules => Core
2017-10-26 19:30caristuTriggers an Emergency Pack => No
2017-10-26 19:30caristuStatusnew => acknowledged
2017-10-26 19:36caristuProposed Solution updated
2017-12-13 19:29caristuAssigned Toplatform => jarmendariz
2018-01-09 11:59jarmendarizStatusacknowledged => scheduled
2018-01-10 09:32jarmendarizRelationship addedrelated to 0037604
2018-01-11 10:21jarmendarizFile Added: bug-37170.patch
2018-01-19 14:38jarmendarizReview Assigned To => caristu
2018-01-22 11:15hgbotCheckin
2018-01-22 11:15hgbotNote Added: 0101823
2018-01-22 11:15hgbotStatusscheduled => resolved
2018-01-22 11:15hgbotResolutionopen => fixed
2018-01-22 11:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/27839f3cbb2737b2fbab3337b33aa5c084d82112 [^]
2018-01-22 11:15caristuNote Added: 0101824
2018-01-22 11:15caristuStatusresolved => closed
2018-01-22 11:15caristuFixed in Version => 3.0PR18Q1
2018-01-22 11:18caristuFixed in Version3.0PR18Q1 => 3.0PR18Q2
2018-02-22 18:18hudsonbotCheckin
2018-02-22 18:18hudsonbotNote Added: 0102671
2019-01-31 10:00alostaleRelationship addedrelated to 0038258

Notes
(0101823)
hgbot   
2018-01-22 11:15   
Repository: erp/devel/pi
Changeset: 27839f3cbb2737b2fbab3337b33aa5c084d82112
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Thu Jan 11 10:20:02 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/27839f3cbb2737b2fbab3337b33aa5c084d82112 [^]

Fixed bug 37170: Remove unneeded toolbar buttons in SQL Query window.

This removes some navigation buttons in SQL Query Window that currently has no functionality.

---
M src/org/openbravo/erpCommon/utility/ToolBar.java
---
(0101824)
caristu   
2018-01-22 11:15   
Code reviewed + tested OK.
(0102671)
hudsonbot   
2018-02-22 18:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/980a6ad5bbf5 [^]
Maturity status: Test