Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037153Openbravo ERP02. Master data managementpublic2017-10-24 11:452018-01-03 12:38
ReporterAtulOpenbravo 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037153: Characteristics Configuration tab display logic does not work properly
DescriptionCharacteristics Configuration tab appears before selecting any of the product. in the product window. After selecting product, tab name disappears but the tab still exists user can select the tab and enter the characteristics configuration.
Steps To Reproduce- Navigate to "Product" window.
- Without selecting any product from the list click on "Characteristics" tab and verify that "Characteristic Configuration" tab appears below.
- This is Ok.
- Select product "Cerveza Ale 0,5L" from the "Product" tab list.
- Realize that "Characteristic Configuration" tab disappears below.
- Realize that Generic flag is set as No.
- Navigate to Characteristics Tab. Double click on this tab.
- Realize that only the "Characteristic Configuration" name is not seen on the tab. But the tab exists.
- Double click on below tab without name.
- Realize that Characteristic configuration grid view appears.

This is not correct. It seems that display logic on the tab only hides the tab name instead of entire tab.

Attached screen shots for reference.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037137 closed AtulOpenbravo Modules Intrastat breaks Products window 
related to feature request 00052023.0MP19 closed AugustoMauch Openbravo ERP Implement display logic for tabs [No new BOM creation possible] 
Attached Filespng Issue37153_1.png (77,013) 2017-10-26 10:45
https://issues.openbravo.com/file_download.php?file_id=11236&type=bug
png

png Issue37153_2.png (62,925) 2017-10-26 10:46
https://issues.openbravo.com/file_download.php?file_id=11237&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-10-24 11:45AtulOpenbravoNew Issue
2017-10-24 11:45AtulOpenbravoAssigned To => Triage Finance
2017-10-24 11:45AtulOpenbravoModules => Core
2017-10-24 11:45AtulOpenbravoTriggers an Emergency Pack => No
2017-10-24 11:45AtulOpenbravoRelationship addedrelated to 0037137
2017-10-24 12:07AtulOpenbravoSummaryCharacteristics Configuration tab disappears after selecting product in the product window => Characteristics Configuration tab display logic does not work properly
2017-10-24 12:07AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=16174#r16174
2017-10-24 12:07AtulOpenbravoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16176#r16176
2017-10-24 12:09AtulOpenbravoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16177#r16177
2017-10-24 13:50rbianchiniIssue Monitored: szapata
2017-10-26 10:45AtulOpenbravoAssigned ToTriage Finance => platform
2017-10-26 10:45AtulOpenbravoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16184#r16184
2017-10-26 10:45AtulOpenbravoFile Added: Issue37153_1.png
2017-10-26 10:46AtulOpenbravoFile Added: Issue37153_2.png
2017-10-26 17:47caristuAssigned Toplatform => caristu
2017-10-26 17:47caristuStatusnew => acknowledged
2017-10-26 17:47caristuStatusacknowledged => scheduled
2017-10-27 08:32hgbotCheckin
2017-10-27 08:32hgbotNote Added: 0100089
2017-10-27 08:32hgbotStatusscheduled => resolved
2017-10-27 08:32hgbotResolutionopen => fixed
2017-10-27 08:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c0e3b98902110b79be7f7588240f986e0beecace [^]
2017-10-27 08:32caristuReview Assigned To => alostale
2017-10-27 10:21alostaleRelationship addedrelated to 0005202
2017-10-27 10:27hgbotCheckin
2017-10-27 10:27hgbotNote Added: 0100095
2017-10-27 10:28alostaleNote Added: 0100096
2017-10-27 10:28alostaleStatusresolved => closed
2017-10-27 10:28alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101349
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101350

Notes
(0100089)
hgbot   
2017-10-27 08:32   
Repository: erp/devel/pi
Changeset: c0e3b98902110b79be7f7588240f986e0beecace
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Oct 27 08:26:19 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c0e3b98902110b79be7f7588240f986e0beecace [^]

fixes bug 37153: Do not show tab sets when they have all of its tabs hidden

When double-clicking on a tab, its child tab set was always being shown. In case all the tabs in the child tab set were hidden (because of their respective display logics), then the child tab set was being displayed empty.

To prevent this error, now in that case, the child tab set is displayed when any of its tabs should be visible. Otherwise, the child tab set will not be displayed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
---
(0100095)
hgbot   
2017-10-27 10:27   
Repository: erp/devel/pi
Changeset: e84582858b866a30c32e717a3dcdf9b837f0fe1f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Oct 27 10:26:59 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e84582858b866a30c32e717a3dcdf9b837f0fe1f [^]

related to bug 37153: removed unneded if nesting

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
---
(0100096)
alostale   
2017-10-27 10:28   
reviewed

tested from grid and form views
(0101349)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101350)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test