Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037108Openbravo ERPY. DBSourceManagerpublic2017-10-18 12:562017-10-24 12:43
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q3.1Fixed in Version3.0PR17Q3.1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-04-26
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Triggers an Emergency PackNo
Summary0037108: Import.sample.data does not immediately stop when a file cannot be imported
DescriptionWhen import.sample.data is not able to import a particular file, the process should stop immediately stop, and the task should fail (see attached file properImportSampleData.log).

That was the behaviour before this changeset [1] was introduced. After that changeset was applied, an error is shown but the process keeps going, and will only fail if a foreign key cannot be satisfied (see attached file wrongImportSampleData.log).

[1] https://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Steps To Reproduce- Break the XML syntax of referencedata/sampledata/F_B_International_Group/AD_TREENODE.xml by removing a </AD_TREENODE> tag
- Run install.source. The process should stop the moment the import of AD_TREENODE fails, but instead it keeps going and it ends with a build successful message.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037103 closed AugustoMauch Import.sample.data does not immediately stop when a file cannot be imported 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-18 18:43AugustoMauchTypedefect => backport
2017-10-18 18:43AugustoMauchTarget Version => 3.0PR17Q3.2
2017-10-19 09:54AugustoMauchTarget Version3.0PR17Q3.2 => 3.0PR17Q3.1
2017-10-19 10:20hgbotCheckin
2017-10-19 10:20hgbotNote Added: 0099953
2017-10-19 10:20hgbotStatusscheduled => resolved
2017-10-19 10:20hgbotResolutionopen => fixed
2017-10-19 10:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/a6b6565a165c27af6158283d705815f12043026c [^]
2017-10-19 10:22AugustoMauchReview Assigned To => alostale
2017-10-19 10:33hgbotCheckin
2017-10-19 10:33hgbotNote Added: 0099954
2017-10-19 10:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/a6b6565a165c27af6158283d705815f12043026c [^] => http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/b80542e893dabd0c01111e9d5ac3210b7b55104b [^]
2017-10-24 12:43alostaleNote Added: 0100021
2017-10-24 12:43alostaleStatusresolved => closed
2017-10-24 12:43alostaleFixed in Version => 3.0PR17Q3.1

Notes
(0099953)
hgbot   
2017-10-19 10:20   
Repository: erp/devel/dbsm-main
Changeset: a6b6565a165c27af6158283d705815f12043026c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 19 09:40:51 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/a6b6565a165c27af6158283d705815f12043026c [^]

Fixes issue 37108: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlDatabaseDataIO.java
M src/org/openbravo/ddlutils/task/ImportSampledata.java
---
(0099954)
hgbot   
2017-10-19 10:33   
Repository: erp/backports/3.0PR17Q3.1
Changeset: b80542e893dabd0c01111e9d5ac3210b7b55104b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 19 10:20:46 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/b80542e893dabd0c01111e9d5ac3210b7b55104b [^]

Fixes issue 37108: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0100021)
alostale   
2017-10-24 12:43   
reviewed + tested