Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037107Openbravo ERPY. DBSourceManagerpublic2017-10-18 12:562017-10-24 12:43
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q4Fixed in Version3.0PR17Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-04-26
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Triggers an Emergency PackNo
Summary0037107: Import.sample.data does not immediately stop when a file cannot be imported
DescriptionWhen import.sample.data is not able to import a particular file, the process should stop immediately stop, and the task should fail (see attached file properImportSampleData.log).

That was the behaviour before this changeset [1] was introduced. After that changeset was applied, an error is shown but the process keeps going, and will only fail if a foreign key cannot be satisfied (see attached file wrongImportSampleData.log).

[1] https://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Steps To Reproduce- Break the XML syntax of referencedata/sampledata/F_B_International_Group/AD_TREENODE.xml by removing a </AD_TREENODE> tag
- Run install.source. The process should stop the moment the import of AD_TREENODE fails, but instead it keeps going and it ends with a build successful message.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037103 closed AugustoMauch Import.sample.data does not immediately stop when a file cannot be imported 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-18 18:43AugustoMauchTypedefect => backport
2017-10-18 18:43AugustoMauchTarget Version => 3.0PR17Q4
2017-10-19 10:34hgbotCheckin
2017-10-19 10:34hgbotNote Added: 0099955
2017-10-19 10:34hgbotStatusscheduled => resolved
2017-10-19 10:34hgbotResolutionopen => fixed
2017-10-19 10:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/8089c66b5970304269aa72058ec05ebb97ec7b06 [^]
2017-10-19 10:36hgbotCheckin
2017-10-19 10:36hgbotNote Added: 0099956
2017-10-19 10:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/8089c66b5970304269aa72058ec05ebb97ec7b06 [^] => http://code.openbravo.com/erp/backports/3.0PR17Q4/rev/190499832b684ab91453f5b372a9a6fc680e119a [^]
2017-10-24 12:43alostaleReview Assigned To => alostale
2017-10-24 12:43alostaleStatusresolved => closed
2017-10-24 12:43alostaleFixed in Version => 3.0PR17Q4

Notes
(0099955)
hgbot   
2017-10-19 10:34   
Repository: erp/devel/dbsm-main
Changeset: 8089c66b5970304269aa72058ec05ebb97ec7b06
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 19 10:10:32 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/8089c66b5970304269aa72058ec05ebb97ec7b06 [^]

Fixes issue 37107: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlDatabaseDataIO.java
M src/org/openbravo/ddlutils/task/ImportSampledata.java
---
(0099956)
hgbot   
2017-10-19 10:36   
Repository: erp/backports/3.0PR17Q4
Changeset: 190499832b684ab91453f5b372a9a6fc680e119a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 19 10:23:06 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q4/rev/190499832b684ab91453f5b372a9a6fc680e119a [^]

Fixes issue 37107: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M src-db/database/lib/dbsourcemanager.jar
---