Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037103Openbravo ERPY. DBSourceManagerpublic2017-10-18 12:562018-01-24 09:07
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2017-04-26
Regression introduced in release3.0PR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Triggers an Emergency PackNo
Summary0037103: Import.sample.data does not immediately stop when a file cannot be imported
DescriptionWhen import.sample.data is not able to import a particular file, the process should stop immediately stop, and the task should fail (see attached file properImportSampleData.log).

That was the behaviour before this changeset [1] was introduced. After that changeset was applied, an error is shown but the process keeps going, and will only fail if a foreign key cannot be satisfied (see attached file wrongImportSampleData.log).

[1] https://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
Steps To Reproduce- Break the XML syntax of referencedata/sampledata/F_B_International_Group/AD_TREENODE.xml by removing a </AD_TREENODE> tag
- Run install.source. The process should stop the moment the import of AD_TREENODE fails, but instead it keeps going and it ends with a build successful message.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00371073.0PR17Q4 closed AugustoMauch Import.sample.data does not immediately stop when a file cannot be imported 
depends on backport 00371083.0PR17Q3.1 closed AugustoMauch Import.sample.data does not immediately stop when a file cannot be imported 
caused by feature request 0035832 closed AugustoMauch Support using several threads to import and export the sample data 
Attached Fileslog properImportSampleData.log (10,546) 2017-10-18 12:57
https://issues.openbravo.com/file_download.php?file_id=11197&type=bug
log wrongImportSampleData.log (9,758) 2017-10-18 12:57
https://issues.openbravo.com/file_download.php?file_id=11198&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-10-18 12:56AugustoMauchNew Issue
2017-10-18 12:56AugustoMauchAssigned To => AugustoMauch
2017-10-18 12:56AugustoMauchOBNetwork customer => No
2017-10-18 12:56AugustoMauchModules => Core
2017-10-18 12:56AugustoMauchRegression level => Production - QA Approved
2017-10-18 12:56AugustoMauchRegression date => 2017-04-26
2017-10-18 12:56AugustoMauchRegression introduced in release => 3.0PR17Q3
2017-10-18 12:56AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/dbsm-main/rev/c6fa7da9db9bca6babcdb7e1f95accfb73ed1da8 [^]
2017-10-18 12:56AugustoMauchTriggers an Emergency Pack => No
2017-10-18 12:57AugustoMauchFile Added: properImportSampleData.log
2017-10-18 12:57AugustoMauchFile Added: wrongImportSampleData.log
2017-10-18 12:58AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=16135#r16135
2017-10-18 18:43AugustoMauchStatusnew => scheduled
2017-10-18 18:56hgbotCheckin
2017-10-18 18:56hgbotNote Added: 0099946
2017-10-18 18:56hgbotStatusscheduled => resolved
2017-10-18 18:56hgbotResolutionopen => fixed
2017-10-18 18:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/b29eb5be4cfe743c2c6021cf4c66e97698fe08bd [^]
2017-10-18 18:56hgbotCheckin
2017-10-18 18:56hgbotNote Added: 0099947
2017-10-18 18:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/b29eb5be4cfe743c2c6021cf4c66e97698fe08bd [^] => http://code.openbravo.com/erp/devel/pi/rev/b2d14bbc54372b9bcece476d8e3871b117e3d00f [^]
2017-10-18 18:57AugustoMauchReview Assigned To => alostale
2017-10-18 18:57AugustoMauchFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b2d14bbc54372b9bcece476d8e3871b117e3d00f [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/b29eb5be4cfe743c2c6021cf4c66e97698fe08bd [^]
2017-10-18 19:02hgbotCheckin
2017-10-18 19:02hgbotNote Added: 0099948
2017-10-18 19:02hgbotCheckin
2017-10-18 19:02hgbotNote Added: 0099949
2017-10-24 12:39alostaleNote Added: 0100020
2017-10-24 12:39alostaleStatusresolved => closed
2017-10-24 12:39alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101336
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101337
2018-01-24 09:07alostaleRelationship addedcaused by 0035832

Notes
(0099946)
hgbot   
2017-10-18 18:56   
Repository: erp/devel/dbsm-main
Changeset: b29eb5be4cfe743c2c6021cf4c66e97698fe08bd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 18 15:58:11 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/b29eb5be4cfe743c2c6021cf4c66e97698fe08bd [^]

Fixes issue 37103: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M .classpath
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlDatabaseDataIO.java
M src/org/openbravo/ddlutils/task/ImportSampledata.java
---
(0099947)
hgbot   
2017-10-18 18:56   
Repository: erp/devel/pi
Changeset: b2d14bbc54372b9bcece476d8e3871b117e3d00f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 18 18:43:04 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b2d14bbc54372b9bcece476d8e3871b117e3d00f [^]

Fixes issue 37103: import.sample.data fails if a file cannot be imported

If a file cannot be imported the import.sample.data process will stop immediately and will show log describing the problem.

To be able to catch the exceptions thrown in another thread, now the logic to import files is wrapped in a Callable instead of a Runnable.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0099948)
hgbot   
2017-10-18 19:02   
Repository: erp/devel/dbsm-main
Changeset: 7c34d0f9910175614ce9040ccc3288be28683a58
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 18 18:48:57 2017 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/7c34d0f9910175614ce9040ccc3288be28683a58 [^]

Related with issue 37103: Unneeded change is backed out

The change done in .classpath was not meant to be pushed.

---
M .classpath
---
(0099949)
hgbot   
2017-10-18 19:02   
Repository: erp/devel/pi
Changeset: c77412df1f7e134dae3ed3ef3f4f9496d1d789f5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Oct 18 18:49:31 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c77412df1f7e134dae3ed3ef3f4f9496d1d789f5 [^]

Related with issue 37103: Unneeded change is backed out

The change done in .classpath was not meant to be pushed.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0100020)
alostale   
2017-10-24 12:39   
reviewed + tested
(0101336)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101337)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test