0037098: It is possible to click on Void Layaway before the calculateReceipt of the loaded layaway has finished

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0037098

Retail Modules

Web POS

public

2017-10-18 11:06

2017-11-09 14:32

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0037098: It is possible to click on Void Layaway before the calculateReceipt of the loaded layaway has finished

Description

When a layaway is loaded in the POS, the calculateReceipt function is executed to generate the totals of the layaway.
When the Void Layaway menu option is used, the gross of the void layaway (total cash to return) is calculated based on the current total of the layaway and the payments added previously.
If the first calculateReceipt finishes after the void layaway has been clicked, then the calculatereceipt resets the gross of the layaway and the POS asks the cashier to return money when it should not.

Steps To Reproduce

Login in webpos
Create a new layaway, add some products, and synchronize the Layaway without payments by clicking on Layaway.
Open the browser console and execute this[1] code to implement a hook and make the calculateReceipt slow.
Go to the menu and load the previously created layaway.
Quickly, go to the menu and click on Void Layaway.
The POS will change to the payments tab, and after a few seconds the payment tab will show "<amount_of_the_layaway>€ remaining to return." instead of "Total is zero. No payment needed".

[1] OB.UTIL.HookManager.registerHook('OBPOS_PreCheckDiscount', function(args, callback){
setTimeout(function(){
OB.UTIL.HookManager.callbackExecutor(args, callback);
}, 5000)
})

Proposed Solution

It should not be possible to click on the menu while the calculateReceipt of the loaded layaway is being executed.

Additional Information