Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037090Openbravo ERPZ. Otherspublic2017-10-17 18:092018-01-03 12:38
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket48958
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037090: Error when processing payment generating credit and business partner has no currency defined
DescriptionOnly "Error" red message is shown to end-user. But according with NullPointerException error shown in openbravo.log problem is related with business partner currency
Steps To Reproduce0. Create new Business Partner, define it as "vendor": fill Payment Method, Payment Terms and Financial Account fields but left Price List field empty (so business partner currency is not initialized)
1. Create new Payment Out document for previous vendor. Set any "Generated credit" amount and run "Add details". Try to process payment and error will be reised
Proposed SolutionError is in:
ERROR org.openbravo.advpaymentmngt.actionHandler.AddPaymentOnProcessActionHandler -
java.lang.NullPointerException
    at org.openbravo.advpaymentmngt.actionHandler.AddPaymentOnProcessActionHandler.execute(AddPaymentOnProcessActionHandler.java:75)

NullPointerException should be controlled to raise proper error "'Please initialize # business partner currency before processing the document.'" (value 'InitBPCurrencyLnk')
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028077 closed fsoto82 In case business partner's currency is not defined, an error should be raised asking user to initialize it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-17 18:09maiteNew Issue
2017-10-17 18:09maiteAssigned To => Triage Finance
2017-10-17 18:09maiteOBNetwork customer => Yes
2017-10-17 18:09maiteModules => Advanced Payables and Receivables Mngmt
2017-10-17 18:09maiteSupport ticket => 48958
2017-10-17 18:09maiteResolution time => 1510009200
2017-10-17 18:09maiteTriggers an Emergency Pack => No
2017-10-17 18:13maiteProposed Solution updated
2017-10-17 18:18maiteRelationship addedrelated to 0028077
2017-10-17 18:46PracticsIssue Monitored: Practics
2017-10-18 11:04vmromanosAssigned ToTriage Finance => AtulOpenbravo
2017-10-20 08:37AtulOpenbravoStatusnew => scheduled
2017-10-20 08:37AtulOpenbravoNote Added: 0099973
2017-10-27 14:01hgbotCheckin
2017-10-27 14:01hgbotNote Added: 0100120
2017-10-27 14:01hgbotStatusscheduled => resolved
2017-10-27 14:01hgbotResolutionopen => fixed
2017-10-27 14:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8071a84ccfe201e382955678d7a1c04976f0cfa0 [^]
2017-10-27 14:02dmiguelezReview Assigned To => dmiguelez
2017-10-27 14:02dmiguelezNote Added: 0100121
2017-10-27 14:02dmiguelezStatusresolved => closed
2017-10-31 18:18dmiguelezFixed in Version => 3.0PR18Q1
2018-01-03 12:38hudsonbotCheckin
2018-01-03 12:38hudsonbotNote Added: 0101351

Notes
(0099973)
AtulOpenbravo   
2017-10-20 08:37   
- Login as F&B International Group Admin
- Create new Business Partner, define it as "vendor": fill Payment Method, Payment Terms and Financial Account fields but left Price List field empty (so business partner currency is not initialized)
- Create new Payment Out document for previous vendor. Set any "Generated credit" amount and run "Add details".
- Try to process payment and error will be raised as
  "Error
   Please initialize <Name of business partner> business partner currency before processing the
   document."
(0100120)
hgbot   
2017-10-27 14:01   
Repository: erp/devel/pi
Changeset: 8071a84ccfe201e382955678d7a1c04976f0cfa0
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Oct 20 11:58:31 2017 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8071a84ccfe201e382955678d7a1c04976f0cfa0 [^]

Fixes Issue 37090: Error when processing payment generating credit and business partner
has no currency defined

Before APRM_CreditCurrency check in AddPaymentOnProcessActionHandler,
check whether currency of business partner is null and raise
InitBPCurrencyLnk error message

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentOnProcessActionHandler.java
---
(0100121)
dmiguelez   
2017-10-27 14:02   
Code Review + Testing Ok
(0101351)
hudsonbot   
2018-01-03 12:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test