Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037082Retail ModulesWeb POSpublic2017-10-16 18:412017-10-23 09:47
Reporteregoitz 
Assigned Toguilleaer 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037082: The orderby of the product masterdata query is ordering by name but not needed
DescriptionThe order by name is needed only when using remote server so can be removed to reduce the performance.

Steps To ReproduceExecute the masterdata query order by name and product id and only with product id to see that the order by name affects to the execution time.
Proposed Solution
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-16 18:41egoitzNew Issue
2017-10-16 18:41egoitzAssigned To => Retail
2017-10-16 18:41egoitzOBNetwork customer => Yes
2017-10-16 18:41egoitzResolution time => 1508450400
2017-10-16 18:41egoitzTriggers an Emergency Pack => No
2017-10-16 18:41egoitzIssue Monitored: malsasua
2017-10-17 09:26guillermogilTag Attached: Performance
2017-10-18 09:34guilleaerStatusnew => scheduled
2017-10-18 09:34guilleaerAssigned ToRetail => guilleaer
2017-10-18 13:47hgbotCheckin
2017-10-18 13:47hgbotNote Added: 0099936
2017-10-18 13:47hgbotStatusscheduled => resolved
2017-10-18 13:47hgbotResolutionopen => fixed
2017-10-18 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26327855ced8a596639875b7c49b63f6372803f8 [^]
2017-10-18 18:13hgbotCheckin
2017-10-18 18:13hgbotNote Added: 0099945
2017-10-23 09:47marvintmReview Assigned To => marvintm
2017-10-23 09:47marvintmStatusresolved => closed
2017-10-23 09:47marvintmFixed in Version => RR18Q1

Notes
(0099936)
hgbot   
2017-10-18 13:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26327855ced8a596639875b7c49b63f6372803f8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 18 13:30:53 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26327855ced8a596639875b7c49b63f6372803f8 [^]

Fixed issue 37082, 37081: Adjust product query to improve performance

1. Remove order by when remote mode for product query is not enebaled
2. Remove join with images when prefrenece to get images from server is enabled

---
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ProductDiscProperties.java
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
---
(0099945)
hgbot   
2017-10-18 18:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bdf2b64608c6eb7c564d802a3fa709f9af3c7a5b
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Oct 18 18:00:21 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bdf2b64608c6eb7c564d802a3fa709f9af3c7a5b [^]

Related to issue 37082. Order by id should be preserved so that pagination works correctly

---
M src/org/openbravo/retail/posterminal/master/Product.java
---