Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037079Openbravo ERPA. Platformpublic2017-10-16 18:152018-01-03 12:39
ReporterJONHM 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037079: more records than expected are fetched when filtering by date ranges
DescriptionIt shows more records than expected when filtering by date in grid mode
Steps To ReproduceOpen "Process Monitor" window and filter by 'Start time':
 - From: "Tomorrow"
 - To: "Tomorrow"

-> It shows also records from today
Proposed SolutionON file
./modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java

change
 calendar.set(Calendar.HOUR, 23);
with
 calendar.set(Calendar.HOUR_OF_DAY, 23);
Additional Information
TagsNo tags attached.
Relationships
related to defect 00180793.0MP4 closed mtaal Date filter is not working correctly 
related to defect 0032600 closed NaroaIriarte Wrong data in csv file exported on different timezone on the client side 
related to defect 0023203 closed AugustoMauch filter does not work with creation date fields 
related to defect 00257553.0PR14Q3 closed guillermogil Grid can not be filtered by creation date adding the filter manually using the keyboard 
related to design defect 0040794 new Triage Platform Base Is not possible to filter a DateTime column by time 
causes defect 0040735 closed caristu Records can not be exported to CSV 
causes defect 0040802 closed caristu Use as filter option is not working properly with date columns 
Attached Filespng Screenshot from 2017-10-16 18-01-46.png (259,407) 2017-10-16 18:15
https://issues.openbravo.com/file_download.php?file_id=11185&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2017-10-16 18:15JONHMNew Issue
2017-10-16 18:15JONHMAssigned To => platform
2017-10-16 18:15JONHMFile Added: Screenshot from 2017-10-16 18-01-46.png
2017-10-16 18:15JONHMModules => Core
2017-10-16 18:15JONHMTriggers an Emergency Pack => No
2017-10-16 18:18JONHMSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16107#r16107
2017-10-16 18:31JONHMDescription Updatedbug_revision_view_page.php?rev_id=16109#r16109
2017-10-17 08:17alostaleStatusnew => acknowledged
2017-10-17 08:18alostaleSummaryIt shows more records than expected when filtering by date in grid mode => more records than expected are fetched when filtering by date ranges
2017-11-07 11:57egoitzProposed Solution updated
2017-11-09 15:39inigosanchezStatusacknowledged => scheduled
2017-11-09 15:39inigosanchezAssigned Toplatform => inigosanchez
2017-11-13 13:30inigosanchezAssigned Toinigosanchez => platform
2017-11-13 13:30inigosanchezStatusscheduled => acknowledged
2017-11-27 09:37alostalePrioritynormal => high
2017-11-28 11:02caristuRelationship addedrelated to 0018079
2017-11-28 11:02caristuRelationship addedrelated to 0032600
2017-11-28 12:48caristuRelationship addedrelated to 0023203
2017-11-28 12:59caristuRelationship addedrelated to 0025755
2017-11-28 16:09caristuStatusacknowledged => scheduled
2017-11-28 16:09caristuAssigned Toplatform => caristu
2017-11-28 16:22hgbotCheckin
2017-11-28 16:22hgbotNote Added: 0100788
2017-11-28 16:22hgbotStatusscheduled => resolved
2017-11-28 16:22hgbotResolutionopen => fixed
2017-11-28 16:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/90ee5c965823996a7b4c0ae17d3a3ca71e3fc703 [^]
2017-11-28 16:23caristuReview Assigned To => alostale
2017-12-01 11:21alostaleNote Added: 0100885
2017-12-01 11:21alostaleStatusresolved => closed
2017-12-01 11:21alostaleFixed in Version => 3.0PR18Q1
2018-01-03 12:39hudsonbotCheckin
2018-01-03 12:39hudsonbotNote Added: 0101491
2019-05-02 11:19caristuRelationship addedcauses 0040735
2019-05-07 11:21caristuRelationship addedrelated to 0040794
2019-05-20 16:25caristuRelationship addedcauses 0040802

Notes
(0100788)
hgbot   
2017-11-28 16:22   
Repository: erp/devel/pi
Changeset: 90ee5c965823996a7b4c0ae17d3a3ca71e3fc703
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Nov 28 13:50:04 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/90ee5c965823996a7b4c0ae17d3a3ca71e3fc703 [^]

fixes bug 37079: wrong result when filtering by a range of a DateTime column

  When filtering by a range of dates, the time is set to 0 or 24 hours (depending on the operator) in order to retrieve properly all the records within the same date range.

  However, when filtering by range of a column based in a reference that includes the time (DateTime/AbsoluteDateTime), it is also needed to compare and therefore it should not be modified

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0100885)
alostale   
2017-12-01 11:21   
fixed + reviewed
(0101491)
hudsonbot   
2018-01-03 12:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test