Openbravo Issue Tracking System - Retail Modules |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0037062 | Retail Modules | Web POS | public | 2017-09-27 17:57 | 2017-11-07 07:08 |
|
Reporter | marvintm | |
Assigned To | guilleaer | |
Priority | normal | Severity | major | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | RR17Q3.1 | Fixed in Version | RR17Q3.1 | |
Merge Request Status | |
Review Assigned To | marvintm |
OBNetwork customer | |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0037062: When entering the attribute value, the user shouldn't need to follow internal Openbravo format |
Description | When support for attributes is enabled, the Web POS prompts the user to add the attribute values whenever a product which has associated attribute set is added to the ticket.
However, as of now the value needs to follow internal Openbravo rules (such as starting with # if it's serial number, or L if it's lot), and this is confusing for the user.
In some cases the codes will be generated and the products labelled directly by the company using Openbravo, but in many cases, the codes may be scanned directly from the original goods, and therefore it's quite a hassle for the user to have to correct these codes.
Ideally, the user should only have to scan the value as it is, and Openbravo should handle the conversion to its internal format automatically. |
Steps To Reproduce | Use Support for Attributes functionality, and verify that the serial number cannot be entered as it is, and # is required for the Web POS to recognize it properly. |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | blocks | design defect | 0036966 | | closed | guilleaer | When entering the attribute value, the user shouldn't need to follow internal Openbravo format |
|
Attached Files | 0_pi_q3.patch (5,316) 2017-10-13 11:37 https://issues.openbravo.com/file_download.php?file_id=11176&type=bug 1_posterminal_q3.patch (23,523) 2017-10-13 11:37 https://issues.openbravo.com/file_download.php?file_id=11177&type=bug 2_mobilecore_q3.patch (1,450) 2017-10-13 11:37 https://issues.openbravo.com/file_download.php?file_id=11178&type=bug 3_returns_q3.patch (3,809) 2017-10-13 11:37 https://issues.openbravo.com/file_download.php?file_id=11179&type=bug 1_posterminal_q3_2.patch (5,245) 2017-10-25 08:58 https://issues.openbravo.com/file_download.php?file_id=11228&type=bug 0_pi_q3_2.patch (4,569) 2017-10-25 08:58 https://issues.openbravo.com/file_download.php?file_id=11229&type=bug 4_stockvalidation_q3.patch (13,308) 2017-10-25 08:59 https://issues.openbravo.com/file_download.php?file_id=11230&type=bug 4_stockvalidation_q3_2.patch (1,050) 2017-10-25 09:00 https://issues.openbravo.com/file_download.php?file_id=11231&type=bug 3_returns_q3_2.patch (2,536) 2017-10-25 09:00 https://issues.openbravo.com/file_download.php?file_id=11232&type=bug |
|
Issue History |
Date Modified | Username | Field | Change |
2017-10-13 11:36 | guilleaer | Type | design defect => backport |
2017-10-13 11:36 | guilleaer | Target Version | => RR17Q3.1 |
2017-10-13 11:37 | guilleaer | File Added: 0_pi_q3.patch | |
2017-10-13 11:37 | guilleaer | File Added: 1_posterminal_q3.patch | |
2017-10-13 11:37 | guilleaer | File Added: 2_mobilecore_q3.patch | |
2017-10-13 11:37 | guilleaer | File Added: 3_returns_q3.patch | |
2017-10-13 11:39 | guilleaer | Note Added: 0099897 | |
2017-10-13 11:42 | guilleaer | Note Added: 0099898 | |
2017-10-13 12:22 | guilleaer | File Added: 4_stockvalidation.patch | |
2017-10-25 08:58 | guilleaer | File Added: 4_stockvalidation_2.patch | |
2017-10-25 08:58 | guilleaer | File Added: 3_returns_2.patch | |
2017-10-25 08:58 | guilleaer | File Added: 1_posterminal_q3_2.patch | |
2017-10-25 08:58 | guilleaer | File Added: 0_pi_q3_2.patch | |
2017-10-25 08:59 | guilleaer | File Deleted: 4_stockvalidation_2.patch | |
2017-10-25 08:59 | guilleaer | File Deleted: 3_returns_2.patch | |
2017-10-25 08:59 | guilleaer | File Deleted: 4_stockvalidation.patch | |
2017-10-25 08:59 | guilleaer | File Added: 4_stockvalidation_q3.patch | |
2017-10-25 09:00 | guilleaer | File Added: 4_stockvalidation_q3_2.patch | |
2017-10-25 09:00 | guilleaer | File Added: 3_returns_q3_2.patch | |
2017-10-25 09:54 | guilleaer | Note Edited: 0099897 | bug_revision_view_page.php?bugnote_id=0099897#r16179 |
2017-10-25 12:25 | hgbot | Checkin | |
2017-10-25 12:25 | hgbot | Note Added: 0100054 | |
2017-10-25 12:25 | hgbot | Status | scheduled => resolved |
2017-10-25 12:25 | hgbot | Resolution | open => fixed |
2017-10-25 12:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15 [^] |
2017-10-25 12:25 | hgbot | Checkin | |
2017-10-25 12:25 | hgbot | Note Added: 0100055 | |
2017-10-25 12:26 | hgbot | Checkin | |
2017-10-25 12:26 | hgbot | Note Added: 0100056 | |
2017-10-25 12:26 | hgbot | Checkin | |
2017-10-25 12:26 | hgbot | Note Added: 0100057 | |
2017-10-25 12:27 | hgbot | Checkin | |
2017-10-25 12:27 | hgbot | Note Added: 0100059 | |
2017-10-25 13:02 | hgbot | Checkin | |
2017-10-25 13:02 | hgbot | Note Added: 0100061 | |
2017-10-25 13:02 | guilleaer | Note Edited: 0099898 | bug_revision_view_page.php?bugnote_id=0099898#r16181 |
2017-10-30 18:13 | hgbot | Checkin | |
2017-10-30 18:13 | hgbot | Note Added: 0100161 | |
2017-10-31 09:41 | marvintm | Assigned To | Retail => guilleaer |
2017-11-02 11:41 | hgbot | Checkin | |
2017-11-02 11:41 | hgbot | Note Added: 0100212 | |
2017-11-02 12:51 | marvintm | Review Assigned To | => marvintm |
2017-11-02 12:51 | marvintm | Status | resolved => closed |
2017-11-02 12:51 | marvintm | Fixed in Version | => RR17Q3.1 |
2017-11-03 13:20 | hgbot | Checkin | |
2017-11-03 13:20 | hgbot | Note Added: 0100263 | |
2017-11-07 07:08 | hgbot | Checkin | |
2017-11-07 07:08 | hgbot | Note Added: 0100295 | |
Notes |
|
(0099897)
|
guilleaer
|
2017-10-13 11:39
(edited on: 2017-10-25 09:54) |
|
|
|
(0099898)
|
guilleaer
|
2017-10-13 11:42
(edited on: 2017-10-25 13:02) |
|
|
|
(0100054)
|
hgbot
|
2017-10-25 12:25
|
|
Repository: erp/backports/3.0PR17Q3.1
Changeset: 1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:36:17 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15 [^]
Fixed issue 37062 Backport of 36966: Retrieve AttSetIntance JSON info using PL
-Added PL function to retrieve json details about certain m_attsetinstance_id
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelApplicationInitializer.java
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/functions/M_GETJSONDESCRIPTION.xml
---
|
|
|
(0100055)
|
hgbot
|
2017-10-25 12:25
|
|
Repository: retail/backports/3.0RR17Q3.1/pi-mobile
Changeset: a4c00d5aa6d6305c988355a5fa7163865c763a70
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:54:25 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/pi-mobile/rev/a4c00d5aa6d6305c988355a5fa7163865c763a70 [^]
related to issue 37062 backport of 36966: Update attrs tests
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/CheckStockValidation.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA004SerialNumberMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA005NonSerialMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA006AddUnitToSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA007AddUnitToNonSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA008VerifiedReturns.java
---
|
|
|
(0100056)
|
hgbot
|
2017-10-25 12:26
|
|
|
|
(0100057)
|
hgbot
|
2017-10-25 12:26
|
|
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal
Changeset: 5139f2081509e902117962a4ab21dc0a88f98db5
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 12:12:32 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/5139f2081509e902117962a4ab21dc0a88f98db5 [^]
Related to issue 37062, Backport of issue 36966: Improvements to better support of attributes
- Now attributes are received without symbols and processed in the backend
- Now custom attributes are supported
- AttributeInstance is created when it is required
- When AttributeSetInstance is created every field is correctly populated
- New utility class created to work with attributes
- Added client side utility function
- When attr preference is enabled and order is loaded in web POS from ERP, read att values an generate description. Store it in attSetInstanceDesc property
- When processing an order prevously loaded in webPOS from ERP use attSetInstanceDesc property in backend
---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
A src/org/openbravo/retail/posterminal/utility/AttributesUtils.java
A web/org.openbravo.retail.posterminal/js/utils/attributeUtils.js
---
|
|
|
(0100059)
|
hgbot
|
2017-10-25 12:27
|
|
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.returns
Changeset: 6067aa518e0d18cab76226e2bd8437f5c935a33b
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:43:59 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.returns/rev/6067aa518e0d18cab76226e2bd8437f5c935a33b [^]
Related to issue 37062 backport of 36966: AttValue info retrieved from server y now a json object
- Receive attValue information taking into account new format
- Generate attDescription based on json information using utility function
- Compare the input inserted by the user with the attDescription
---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/modalproductattributeverifiedreturns.js
---
|
|
|
(0100061)
|
hgbot
|
2017-10-25 13:02
|
|
|
|
(0100161)
|
hgbot
|
2017-10-30 18:13
|
|
|
|
(0100212)
|
hgbot
|
2017-11-02 11:41
|
|
|
|
(0100263)
|
hgbot
|
2017-11-03 13:20
|
|
|
|
(0100295)
|
hgbot
|
2017-11-07 07:08
|
|
Repository: tools/automation/pi-mobile
Changeset: a4c00d5aa6d6305c988355a5fa7163865c763a70
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:54:25 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a4c00d5aa6d6305c988355a5fa7163865c763a70 [^]
related to issue 37062 backport of 36966: Update attrs tests
---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/CheckStockValidation.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA004SerialNumberMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA005NonSerialMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA006AddUnitToSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA007AddUnitToNonSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA008VerifiedReturns.java
---
|
|