Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037062Retail ModulesWeb POSpublic2017-09-27 17:572017-11-07 07:08
marvintm 
guilleaer 
normalmajorhave not tried
closedfixed 
5
 
RR17Q3.1RR17Q3.1 
marvintm
No
0037062: When entering the attribute value, the user shouldn't need to follow internal Openbravo format
When support for attributes is enabled, the Web POS prompts the user to add the attribute values whenever a product which has associated attribute set is added to the ticket.

However, as of now the value needs to follow internal Openbravo rules (such as starting with # if it's serial number, or L if it's lot), and this is confusing for the user.

In some cases the codes will be generated and the products labelled directly by the company using Openbravo, but in many cases, the codes may be scanned directly from the original goods, and therefore it's quite a hassle for the user to have to correct these codes.

Ideally, the user should only have to scan the value as it is, and Openbravo should handle the conversion to its internal format automatically.
Use Support for Attributes functionality, and verify that the serial number cannot be entered as it is, and # is required for the Web POS to recognize it properly.
No tags attached.
blocks design defect 0036966 closed guilleaer When entering the attribute value, the user shouldn't need to follow internal Openbravo format 
patch 0_pi_q3.patch (5,316) 2017-10-13 11:37
https://issues.openbravo.com/file_download.php?file_id=11176&type=bug
patch 1_posterminal_q3.patch (23,523) 2017-10-13 11:37
https://issues.openbravo.com/file_download.php?file_id=11177&type=bug
patch 2_mobilecore_q3.patch (1,450) 2017-10-13 11:37
https://issues.openbravo.com/file_download.php?file_id=11178&type=bug
patch 3_returns_q3.patch (3,809) 2017-10-13 11:37
https://issues.openbravo.com/file_download.php?file_id=11179&type=bug
patch 1_posterminal_q3_2.patch (5,245) 2017-10-25 08:58
https://issues.openbravo.com/file_download.php?file_id=11228&type=bug
patch 0_pi_q3_2.patch (4,569) 2017-10-25 08:58
https://issues.openbravo.com/file_download.php?file_id=11229&type=bug
patch 4_stockvalidation_q3.patch (13,308) 2017-10-25 08:59
https://issues.openbravo.com/file_download.php?file_id=11230&type=bug
patch 4_stockvalidation_q3_2.patch (1,050) 2017-10-25 09:00
https://issues.openbravo.com/file_download.php?file_id=11231&type=bug
patch 3_returns_q3_2.patch (2,536) 2017-10-25 09:00
https://issues.openbravo.com/file_download.php?file_id=11232&type=bug
Issue History
2017-10-13 11:36guilleaerTypedesign defect => backport
2017-10-13 11:36guilleaerTarget Version => RR17Q3.1
2017-10-13 11:37guilleaerFile Added: 0_pi_q3.patch
2017-10-13 11:37guilleaerFile Added: 1_posterminal_q3.patch
2017-10-13 11:37guilleaerFile Added: 2_mobilecore_q3.patch
2017-10-13 11:37guilleaerFile Added: 3_returns_q3.patch
2017-10-13 11:39guilleaerNote Added: 0099897
2017-10-13 11:42guilleaerNote Added: 0099898
2017-10-13 12:22guilleaerFile Added: 4_stockvalidation.patch
2017-10-25 08:58guilleaerFile Added: 4_stockvalidation_2.patch
2017-10-25 08:58guilleaerFile Added: 3_returns_2.patch
2017-10-25 08:58guilleaerFile Added: 1_posterminal_q3_2.patch
2017-10-25 08:58guilleaerFile Added: 0_pi_q3_2.patch
2017-10-25 08:59guilleaerFile Deleted: 4_stockvalidation_2.patch
2017-10-25 08:59guilleaerFile Deleted: 3_returns_2.patch
2017-10-25 08:59guilleaerFile Deleted: 4_stockvalidation.patch
2017-10-25 08:59guilleaerFile Added: 4_stockvalidation_q3.patch
2017-10-25 09:00guilleaerFile Added: 4_stockvalidation_q3_2.patch
2017-10-25 09:00guilleaerFile Added: 3_returns_q3_2.patch
2017-10-25 09:54guilleaerNote Edited: 0099897bug_revision_view_page.php?bugnote_id=0099897#r16179
2017-10-25 12:25hgbotCheckin
2017-10-25 12:25hgbotNote Added: 0100054
2017-10-25 12:25hgbotStatusscheduled => resolved
2017-10-25 12:25hgbotResolutionopen => fixed
2017-10-25 12:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15 [^]
2017-10-25 12:25hgbotCheckin
2017-10-25 12:25hgbotNote Added: 0100055
2017-10-25 12:26hgbotCheckin
2017-10-25 12:26hgbotNote Added: 0100056
2017-10-25 12:26hgbotCheckin
2017-10-25 12:26hgbotNote Added: 0100057
2017-10-25 12:27hgbotCheckin
2017-10-25 12:27hgbotNote Added: 0100059
2017-10-25 13:02hgbotCheckin
2017-10-25 13:02hgbotNote Added: 0100061
2017-10-25 13:02guilleaerNote Edited: 0099898bug_revision_view_page.php?bugnote_id=0099898#r16181
2017-10-30 18:13hgbotCheckin
2017-10-30 18:13hgbotNote Added: 0100161
2017-10-31 09:41marvintmAssigned ToRetail => guilleaer
2017-11-02 11:41hgbotCheckin
2017-11-02 11:41hgbotNote Added: 0100212
2017-11-02 12:51marvintmReview Assigned To => marvintm
2017-11-02 12:51marvintmStatusresolved => closed
2017-11-02 12:51marvintmFixed in Version => RR17Q3.1
2017-11-03 13:20hgbotCheckin
2017-11-03 13:20hgbotNote Added: 0100263
2017-11-07 07:08hgbotCheckin
2017-11-07 07:08hgbotNote Added: 0100295

Notes
(0099897)
guilleaer   
2017-10-13 11:39   
(edited on: 2017-10-25 09:54)
commits done in stock validation module.

https://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/e25140ad0383 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/82bbac0defc1 [^]

(0099898)
guilleaer   
2017-10-13 11:42   
(edited on: 2017-10-25 13:02)
Modules Sample data changes

https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/2e34c16fe9a4 [^]

https://code.openbravo.com/erp/pmods-branches/org.openbravo.test.mobile.sampledata/rev/cca05b644d92 [^]

(0100054)
hgbot   
2017-10-25 12:25   
Repository: erp/backports/3.0PR17Q3.1
Changeset: 1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:36:17 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q3.1/rev/1fd64edf19cf6c0aa7c859ef26138dcbc4cbfd15 [^]

Fixed issue 37062 Backport of 36966: Retrieve AttSetIntance JSON info using PL

-Added PL function to retrieve json details about certain m_attsetinstance_id

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelApplicationInitializer.java
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/functions/M_GETJSONDESCRIPTION.xml
---
(0100055)
hgbot   
2017-10-25 12:25   
Repository: retail/backports/3.0RR17Q3.1/pi-mobile
Changeset: a4c00d5aa6d6305c988355a5fa7163865c763a70
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:54:25 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/pi-mobile/rev/a4c00d5aa6d6305c988355a5fa7163865c763a70 [^]

related to issue 37062 backport of 36966: Update attrs tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/CheckStockValidation.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA004SerialNumberMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA005NonSerialMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA006AddUnitToSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA007AddUnitToNonSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA008VerifiedReturns.java
---
(0100056)
hgbot   
2017-10-25 12:26   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.mobile.core
Changeset: 82874256183c899c51022584ecd8cbd14a22fc6c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:46:15 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.mobile.core/rev/82874256183c899c51022584ecd8cbd14a22fc6c [^]

related to issue 37062 backport of 36966: Add new utility function to make easy to validate a string property present in a json object

---
M src/org/openbravo/mobile/core/utils/OBMOBCUtils.java
---
(0100057)
hgbot   
2017-10-25 12:26   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal
Changeset: 5139f2081509e902117962a4ab21dc0a88f98db5
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 12:12:32 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/5139f2081509e902117962a4ab21dc0a88f98db5 [^]

Related to issue 37062, Backport of issue 36966: Improvements to better support of attributes

- Now attributes are received without symbols and processed in the backend
- Now custom attributes are supported
- AttributeInstance is created when it is required
- When AttributeSetInstance is created every field is correctly populated
- New utility class created to work with attributes
- Added client side utility function
- When attr preference is enabled and order is loaded in web POS from ERP, read att values an generate description. Store it in attSetInstanceDesc property
- When processing an order prevously loaded in webPOS from ERP use attSetInstanceDesc property in backend

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/PaidReceiptLinesProperties.java
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
A src/org/openbravo/retail/posterminal/utility/AttributesUtils.java
A web/org.openbravo.retail.posterminal/js/utils/attributeUtils.js
---
(0100059)
hgbot   
2017-10-25 12:27   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.returns
Changeset: 6067aa518e0d18cab76226e2bd8437f5c935a33b
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:43:59 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.returns/rev/6067aa518e0d18cab76226e2bd8437f5c935a33b [^]

Related to issue 37062 backport of 36966: AttValue info retrieved from server y now a json object

- Receive attValue information taking into account new format
- Generate attDescription based on json information using utility function
- Compare the input inserted by the user with the attDescription

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/modalproductattributeverifiedreturns.js
---
(0100061)
hgbot   
2017-10-25 13:02   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.sampledata
Changeset: 443974c237ed9a9a287a43e7ab78162cf7d620a2
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 12:50:42 2017 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.sampledata/rev/443974c237ed9a9a287a43e7ab78162cf7d620a2 [^]

Related to issue 37062: Add inventory status info to locators sample data

---
M referencedata/sampledata/The_White_Valley_Group/M_LOCATOR.xml
---
(0100161)
hgbot   
2017-10-30 18:13   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal
Changeset: 2143fc14285c9e5fa4200be21a9a1ec0830f90af
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 30 18:12:50 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/2143fc14285c9e5fa4200be21a9a1ec0830f90af [^]

Related to issue 37062, Backport of issue 36966: Fix copyright year

---
M web/org.openbravo.retail.posterminal/js/utils/attributeUtils.js
---
(0100212)
hgbot   
2017-11-02 11:41   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal
Changeset: 85304b50be6b437c63750ca776b44073af3e1885
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Nov 02 11:41:08 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/85304b50be6b437c63750ca776b44073af3e1885 [^]

Related to issue 37062, Backport of issue 36966: Verified returns are now working fine when return is synchronized

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/utility/AttributesUtils.java
---
(0100263)
hgbot   
2017-11-03 13:20   
Repository: retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal
Changeset: fcf2d1f0d554fd65c22a958b0c512f1d97e5c6b1
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Nov 03 13:20:21 2017 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR17Q3.1/org.openbravo.retail.posterminal/rev/fcf2d1f0d554fd65c22a958b0c512f1d97e5c6b1 [^]

Related to issue 37062, Backport of issue 36966: Increase maxLengh of attribute value input

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalproductattribute.js
---
(0100295)
hgbot   
2017-11-07 07:08   
Repository: tools/automation/pi-mobile
Changeset: a4c00d5aa6d6305c988355a5fa7163865c763a70
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Oct 25 11:54:25 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a4c00d5aa6d6305c988355a5fa7163865c763a70 [^]

related to issue 37062 backport of 36966: Update attrs tests

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/CheckStockValidation.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA001SerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA002NonSerialNumberProductWithoutStock.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA004SerialNumberMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA005NonSerialMoreThanOneQuantity.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA006AddUnitToSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA007AddUnitToNonSerialNumber.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/supportforattributes/SFA008VerifiedReturns.java
---