Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037044Retail ModulesWeb POSpublic2017-10-10 12:452018-06-26 11:43
Reporteravicente 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037044: [SER QA 3365] Wrong ticket amount when action made before ticke total amount calculated
DescriptionWrong ticket amount when user makes an action before the total amount has been calculated for a ticket. It is not easy to reproduce in quick environments.

Steps To Reproduce1. Create a ticket with a product.
2. Create a new ticket.
3. Add a product.
4. While the total amount button is grey and with 0.00, open the first ticket.
ERROR: wrong amount 0.00 in the second ticket.

See video https://drive.google.com/file/d/0BzvGPDyh8Nh4ZzE0SGF4VkhWNGs/view [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0037098 closed ranjith_qualiantech_com It is possible to click on Void Layaway before the calculateReceipt of the loaded layaway has finished 
causes defect 0037582 closed jorge-garcia Processing block screen CSS changes are necessary 
Attached Filespatch issue 37044 source posterminal 1stphase 8644.patch (2,756) 2017-10-13 15:24
https://issues.openbravo.com/file_download.php?file_id=11183&type=bug
patch issue 37044 source mobile.core 2962.patch (4,809) 2017-11-08 10:42
https://issues.openbravo.com/file_download.php?file_id=11270&type=bug
patch issue 37044 source posterminal 8686.patch (2,958) 2017-11-08 10:43
https://issues.openbravo.com/file_download.php?file_id=11271&type=bug
patch issue 37044 test pi-mobile 6838.patch (4,600) 2017-11-08 10:43
https://issues.openbravo.com/file_download.php?file_id=11272&type=bug
diff 37044_finalChanges.diff (1,413) 2018-01-03 15:29
https://issues.openbravo.com/file_download.php?file_id=11414&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-10-10 12:45avicenteNew Issue
2017-10-10 12:45avicenteAssigned To => Retail
2017-10-10 12:45avicenteResolution time => 1508882400
2017-10-10 12:45avicenteTriggers an Emergency Pack => No
2017-10-11 14:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-10-11 14:42ranjith_qualiantech_comStatusnew => scheduled
2017-10-13 15:24ranjith_qualiantech_comFile Added: issue 37044 source posterminal 1stphase 8644.patch
2017-10-23 12:45hgbotCheckin
2017-10-23 12:45hgbotNote Added: 0099989
2017-10-23 12:45hgbotStatusscheduled => resolved
2017-10-23 12:45hgbotResolutionopen => fixed
2017-10-23 12:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/18820777669846230d272d12d7509a311c6aa6c7 [^]
2017-10-26 10:50hgbotCheckin
2017-10-26 10:50hgbotNote Added: 0100075
2017-10-26 10:51marvintmStatusresolved => new
2017-10-26 10:51marvintmResolutionfixed => open
2017-10-26 10:51marvintmResolution time1508882400 =>
2017-10-26 10:51marvintmTypedefect => design defect
2017-10-26 10:51marvintmNote Added: 0100076
2017-10-26 11:51hgbotCheckin
2017-10-26 11:51hgbotNote Added: 0100078
2017-11-02 15:16ranjith_qualiantech_comStatusnew => scheduled
2017-11-02 15:20ranjith_qualiantech_comFile Added: issue 37044 posterminal 8680.patch
2017-11-02 15:20ranjith_qualiantech_comFile Added: issue 37044 mobile core 2954.patch
2017-11-08 10:41ranjith_qualiantech_comFile Deleted: issue 37044 mobile core 2954.patch
2017-11-08 10:41ranjith_qualiantech_comFile Deleted: issue 37044 posterminal 8680.patch
2017-11-08 10:42ranjith_qualiantech_comFile Added: issue 37044 source mobile.core 2962.patch
2017-11-08 10:43ranjith_qualiantech_comFile Added: issue 37044 source posterminal 8686.patch
2017-11-08 10:43ranjith_qualiantech_comFile Added: issue 37044 test pi-mobile 6838.patch
2017-11-09 14:32marvintmRelationship addedhas duplicate 0037098
2017-11-22 17:21asiermartirenaNote Added: 0100670
2017-12-19 15:32jorge-garciaAssigned Toranjith_qualiantech_com => jorge-garcia
2017-12-20 10:07hgbotCheckin
2017-12-20 10:07hgbotNote Added: 0101163
2017-12-20 12:11hgbotCheckin
2017-12-20 12:11hgbotNote Added: 0101164
2017-12-20 12:12hgbotCheckin
2017-12-20 12:12hgbotNote Added: 0101165
2017-12-20 12:12hgbotStatusscheduled => resolved
2017-12-20 12:12hgbotResolutionopen => fixed
2017-12-20 12:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/18820777669846230d272d12d7509a311c6aa6c7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9a9efaeae7432d9ac0903d4d3cdc9a6f15ffca64 [^]
2017-12-21 08:40hgbotCheckin
2017-12-21 08:40hgbotNote Added: 0101178
2017-12-22 13:05hgbotCheckin
2017-12-22 13:05hgbotNote Added: 0101232
2017-12-22 13:25marvintmReview Assigned To => marvintm
2017-12-22 13:25marvintmStatusresolved => closed
2017-12-22 13:25marvintmFixed in Version => RR18Q1
2018-01-03 15:29jorge-garciaFile Added: 37044_finalChanges.diff
2018-01-04 09:36jorge-garciaRelationship addedcauses 0037582
2018-06-26 11:31hgbotCheckin
2018-06-26 11:31hgbotNote Added: 0105392
2018-06-26 11:43hgbotCheckin
2018-06-26 11:43hgbotNote Added: 0105436
2018-06-26 13:45gorka_gilNote Deleted: 0105392
2018-06-26 13:45gorka_gilNote Deleted: 0105436

Notes
(0099989)
hgbot   
2017-10-23 12:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 18820777669846230d272d12d7509a311c6aa6c7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 23 16:01:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/18820777669846230d272d12d7509a311c6aa6c7 [^]

Fixed issue 37044 : Show scrim while calculating receipt for slower POS

* If benchMarkScore is less than 1000, then we need to show scrim for receipt calculations

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0100075)
hgbot   
2017-10-26 10:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 186578036a0ae4d4a986bfe098d61a266fab764c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Oct 26 10:39:39 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/186578036a0ae4d4a986bfe098d61a266fab764c [^]

Backout issue 37044.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0100076)
marvintm   
2017-10-26 10:51   
The solution as of now was a proof of concept. We are currently working on the final solution.
(0100078)
hgbot   
2017-10-26 11:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0fa0f13d0679cde0f74d7f5321c7ea1149342c4a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Oct 26 15:10:28 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0fa0f13d0679cde0f74d7f5321c7ea1149342c4a [^]

Related to issue 37044 : Added event handling for receipt calculation

* New event handling are added for recipt calculation start and end

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100670)
asiermartirena   
2017-11-22 17:21   
Feedback about this issue:
 - When the new popup is activated and at the same time the showLoading function of the Web POS is executed, the new loading popup appear up to the loading window, and the scrim is down. The old loading window should be the one with higher priority.
 - There are some flows in which an eyo.$.scrim.hide() is done in the middle of a calculateReceipt (probably due to some asynchronous process) which causes the situation in which the popup is enabled but the scrim is shown. Will be important to catch those flows. In BUT happens in deleteLine.
(0101163)
hgbot   
2017-12-20 10:07   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 109f4f7f350216973b13d8488c736262902e23c9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Dec 20 10:02:41 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/109f4f7f350216973b13d8488c736262902e23c9 [^]

Related to issue 37044: [SER QA 3365] Wrong ticket amount when action made
before ticket total amount calculated

Export sampledata for retail external modules.

---
M referencedata/sampledata/Retail_Test/OBPOS_TERMINALTYPE.xml
---
(0101164)
hgbot   
2017-12-20 12:11   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: d6cc804b821a95e0102b0229c44ef9e4a03cb9c4
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Dec 20 09:35:48 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/d6cc804b821a95e0102b0229c44ef9e4a03cb9c4 [^]

Related to issue 37044: [SER QA 3365] Wrong ticket amount when action made
before ticket total amount calculated

Export sampledata for retail pack modules.

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_TERMINALTYPE.xml
---
(0101165)
hgbot   
2017-12-20 12:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9a9efaeae7432d9ac0903d4d3cdc9a6f15ffca64
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Dec 19 15:45:04 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9a9efaeae7432d9ac0903d4d3cdc9a6f15ffca64 [^]

Fixed issue 37044: [SER QA 3365] Wrong ticket amount when action made
before ticket total amount calculated

The solution for this issue is to show a blocking screen during the calculation
of the ticket. Exists two ways to activate the new functionality:
  * At POS Terminal Type window, there is a new check called “Block screen
     when processing ticket”. By deafult is uncheked
  * At preference level, called "Block screen when processing ticket on slow
     devices". By default, is set to ‘Y’

If the conditions are met, a screen is shown during the calculation of the receipt
and the WebPOS is blocked. If one of these conditions are met, the blocking
screen is shown:
  * If the value Block screen when processing ticket” is checked
  * If the preference “Block screen when processing ticket on slow devices” is
     set to ‘Y’ and the benchmark is less than 1000.

When the calculateReceipt is started, a transparent blocking screen is show to
block the webPOS. If the receipt calculation takes more than one second, a
semitransparent screen with a popupmessage is show to indicate the calculation
is ongoing. At the end of the calculateReceipt, all blocking screen are removed.

---
M src-db/database/model/tables/OBPOS_TERMINALTYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/preScanningFocusHook.js
---
(0101178)
hgbot   
2017-12-21 08:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ef6e62471a3fd76e99258ee78006c47412f5911e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Dec 19 15:48:39 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ef6e62471a3fd76e99258ee78006c47412f5911e [^]

Related to issue 37044: [SER QA 3365] Wrong ticket amount when action made
before ticket total amount calculated

Implement the blocking screen component for webPOS.

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0101232)
hgbot   
2017-12-22 13:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cfd6e866308e34c4ef250437e57d67475cbaf487
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Dec 22 13:05:07 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cfd6e866308e34c4ef250437e57d67475cbaf487 [^]

Related to issue 37044: [SER QA 3365] Wrong ticket amount when action made
before ticket total amount calculated

Removed hardcoded message from processing block. Added instead a new message.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---