0037033: "Price Difference Correction" adjustment calculated when it should not

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0037033	Openbravo ERP	04. Warehouse management	public	2017-10-09 13:23	2018-01-08 18:19

Reporter	maite
Assigned To	nonofrancisco
Priority	urgent	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version	3.0PR18Q1
Merge Request Status
Review Assigned To	dmiguelez
OBNetwork customer	OBPS
Web browser
Modules	Core
Support ticket	48861
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0037033: "Price Difference Correction" adjustment calculated when it should not
Description	Although no differences between order's price and invoice's price have been registered, process creates "Price Difference Correction" adjustment (because user could invoice same order twice)
Steps To Reproduce	1. Register Purchase Order for "F&B España - Región Norte" and business partner "Bebidas Alegres, S.L." 2. Add line for "Cerveza Ale 0,5L" and qty=2. Process Order 3. Register Goods Receipt using "Create lines from" and selecting previous order line. Process receipt 4. Register Purchase Invoice using "Create lines from" and selecting previous order line. Leave it in Draft status 5. Register Purchase Invoice using "Create lines from" and selecting previous order line. Process invoice 6. Process invoice created in step 4) 7. Create new Preference "Enable automatic Price Difference Corrections" with value Y 8. Verify that next execution of "Costing Background process" finishes successfully 9. Access "Cerveza Ale 0,5L" product and realize that "Price Difference Correction" adjustment has been calculated when no difference between order's price and invoice's price has been registered
Proposed Solution
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2017-10-09 13:23	maite	New Issue
2017-10-09 13:23	maite	Assigned To	=> Triage Finance
2017-10-09 13:23	maite	OBNetwork customer	=> Yes
2017-10-09 13:23	maite	Modules	=> Core
2017-10-09 13:23	maite	Support ticket	=> 48861
2017-10-09 13:23	maite	Resolution time	=> 1509318000
2017-10-09 13:23	maite	Triggers an Emergency Pack	=> No
2017-10-09 13:24	maite	Issue Monitored: networkb
2017-10-09 13:57	Practics	Issue Monitored: Practics
2017-10-09 19:51	nonofrancisco	Assigned To	Triage Finance => nonofrancisco
2017-10-09 19:56	nonofrancisco	Status	new => scheduled
2017-10-10 19:41	nonofrancisco	Note Added: 0099858
2017-10-10 19:41	nonofrancisco	Note Edited: 0099858	bug_revision_view_page.php?bugnote_id=0099858#r16049
2017-10-11 15:11	nonofrancisco	Note Edited: 0099858	bug_revision_view_page.php?bugnote_id=0099858#r16062
2017-10-23 18:29	dmiguelez	Note Added: 0100006
2017-10-23 18:38	dmiguelez	Note Edited: 0100006	bug_revision_view_page.php?bugnote_id=0100006#r16167
2017-10-24 09:27	dmiguelez	Note Edited: 0100006	bug_revision_view_page.php?bugnote_id=0100006#r16170
2017-10-24 09:29	hgbot	Checkin
2017-10-24 09:29	hgbot	Note Added: 0100011
2017-10-24 09:29	hgbot	Status	scheduled => resolved
2017-10-24 09:29	hgbot	Resolution	open => fixed
2017-10-24 09:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/a5064f422fe0001ff4f12b5e7c054a2965a0667e [^]
2017-10-24 09:29	hgbot	Checkin
2017-10-24 09:29	hgbot	Note Added: 0100012
2017-10-24 09:29	dmiguelez	Review Assigned To	=> dmiguelez
2017-10-24 09:29	dmiguelez	Note Added: 0100013
2017-10-24 09:29	dmiguelez	Status	resolved => closed
2017-11-09 11:11	hgbot	Checkin
2017-11-09 11:11	hgbot	Note Added: 0100376
2018-01-03 12:38	hudsonbot	Checkin
2018-01-03 12:38	hudsonbot	Note Added: 0101341
2018-01-03 12:38	hudsonbot	Checkin
2018-01-03 12:38	hudsonbot	Note Added: 0101342
2018-01-03 12:38	hudsonbot	Checkin
2018-01-03 12:38	hudsonbot	Note Added: 0101390
2018-01-08 18:19	dmiguelez	Fixed in Version	=> 3.0PR18Q1

Notes

Test Plan

Go to Product Window and create a new Product
  - Organization: *
  - Search Key: TestCost
  - Name: TestCost
  - Other parameters with default values
Move to Price Tab and create a new record
  - Price List Version: Be Soft Drinker Price List
  - Unit Price: 10.00
  - List Price: 10.00
Create another record in the same Tab
  - Price List Version: General Sales
  - Unit Price: 10.00
  - List Price: 10.00

Go to Preference Window and create a new record:
  - Organization: *
  - Property: Enable automatic Price Difference Corrections
  - Vavlue: Y
  - Visibility fields: All empty

Test 1 (No Cost Adjustment):

1. Go to Purchase Order Window and create a new Purchase Order
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Move to Lines Tab and create a new record
  - Product: TestCost
  - Ordered Quantity: 1
  - Other parameters with default values
Click on Book button to complete the Purchase Order

2. Go to Goods Receipt Window and create a new Goods Receipt
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created (select also any Bin available)
Click on Complete button to complete the Goods Receipt

3. Go to Purchase Invoice Window and create a new Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Do not complte the Invoice yet

Create another Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created

Complete the two Invoices previously created

4. Execute the Costing Background Process (from Process Request Window)

5. Move to Product Window || Transactions Tab
Check that the last transaction created has:
  - Trx Original Cost: 10.00
  - Total Cost: 10.00
  - Unit Cost: 10.00

Test 2 (Cost adjustment to increase cost):

1. Go to Purchase Order Window and create a new Purchase Order
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Move to Lines Tab and create a new record
  - Product: TestCost
  - Ordered Quantity: 1
  - Other parameters with default values
Click on Book button to complete the Purchase Order

2. Go to Goods Receipt Window and create a new Goods Receipt
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created (select also any Bin available)
Click on Complete button to complete the Goods Receipt

3. Go to Purchase Invoice Window and create a new Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Do not complte the Invoice yet

Create another Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Select the line created and change the Net Unit Price to 20

Complete the two Invoices previously created

4. Execute the Costing Background Process (from Process Request Window)

5. Move to Product Window || Transactions Tab
Check that the last transaction created has:
  - Trx Original Cost: 10.00
  - Total Cost: 15.00
  - Unit Cost: 15.00

Test 3 (Cost adjustment to decrease cost):

1. Go to Purchase Order Window and create a new Purchase Order
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Move to Lines Tab and create a new record
  - Product: TestCost
  - Ordered Quantity: 1
  - Other parameters with default values
Click on Book button to complete the Purchase Order

2. Go to Goods Receipt Window and create a new Goods Receipt
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created (select also any Bin available)
Click on Complete button to complete the Goods Receipt

3. Go to Purchase Invoice Window and create a new Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Do not complte the Invoice yet

Create another Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Select the line created and change the Net Unit Price to 5

Complete the two Invoices previously created

4. Execute the Costing Background Process (from Process Request Window)

5. Move to Product Window || Transactions Tab
Check that the last transaction created has:
  - Trx Original Cost: 10.00
  - Total Cost: 7.50
  - Unit Cost: 7.50

Test 4 (Cost adjustment to increase cost with receipt partially invoiced):

1. Go to Purchase Order Window and create a new Purchase Order
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Move to Lines Tab and create a new record
  - Product: TestCost
  - Ordered Quantity: 2
  - Other parameters with default values
Click on Book button to complete the Purchase Order

2. Go to Goods Receipt Window and create a new Goods Receipt
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created (select also any Bin available)
Click on Complete button to complete the Goods Receipt

3. Go to Purchase Invoice Window and create a new Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Select the created line and change:
  - Invoiced Quantity: 1
  - Net Unit Price: 11
Complete the Purchase Invoice

4. Execute the Costing Background Process (from Process Request Window)

5. Move to Product Window || Transactions Tab
Check that the last transaction created has:
  - Trx Original Cost: 20.00
  - Total Cost: 21.00
  - Unit Cost: 21.00

Test 5 (Cost adjustment to decrease cost with receipt partially invoiced):

1. Go to Purchase Order Window and create a new Purchase Order
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Move to Lines Tab and create a new record
  - Product: TestCost
  - Ordered Quantity: 2
  - Other parameters with default values
Click on Book button to complete the Purchase Order

2. Go to Goods Receipt Window and create a new Goods Receipt
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created (select also any Bin available)
Click on Complete button to complete the Goods Receipt

3. Go to Purchase Invoice Window and create a new Purchase Invoice
  - Organization: F&B US
  - Business Partner: Be Soft Drinker
  - Other parameters with default values
Click on Create Lines From button and select the Order previously created
Select the created line and change:
  - Invoiced Quantity: 1
  - Net Unit Price: 9
Complete the Purchase Invoice

4. Execute the Costing Background Process (from Process Request Window)

5. Move to Product Window || Transactions Tab
Check that the last transaction created has:
  - Trx Original Cost: 20.00
  - Total Cost: 19.00
  - Unit Cost: 19.00