Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037025Retail ModulesWeb POSpublic2017-10-06 14:572018-03-22 14:09
Reportermalsasua 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037025: Perfromance problem in incremental refresh process, with product price query
Descriptionwith a big data, the query of incremental refresh process takes more that 5 secs
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0036312 closed migueldejuana Improve performance of ProducePrice masterdata loading 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-06 14:57malsasuaNew Issue
2017-10-06 14:57malsasuaAssigned To => Retail
2017-10-06 14:57malsasuaResolution time => 1509055200
2017-10-06 14:57malsasuaTriggers an Emergency Pack => No
2017-10-06 14:57malsasuaRelationship addedrelated to 0036312
2017-10-06 14:58malsasuaTag Attached: Performance
2017-10-30 09:48marvintmResolution time1509055200 =>
2017-10-30 09:48marvintmTypedefect => design defect
2018-02-22 19:42hgbotCheckin
2018-02-22 19:42hgbotNote Added: 0102803
2018-02-22 19:42hgbotStatusnew => resolved
2018-02-22 19:42hgbotResolutionopen => fixed
2018-02-22 19:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/715adcce7ca09cb744dc590670af82a5412cee89 [^]
2018-02-22 19:42hgbotCheckin
2018-02-22 19:42hgbotNote Added: 0102804
2018-02-22 19:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/715adcce7ca09cb744dc590670af82a5412cee89 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/983ec113cf9ebf83af257d4a8f0165a64a987fe3 [^]
2018-02-26 09:04marvintmAssigned ToRetail => gorka_gil
2018-03-06 17:31hgbotCheckin
2018-03-06 17:31hgbotNote Added: 0103038
2018-03-06 17:33hgbotCheckin
2018-03-06 17:33hgbotNote Added: 0103039
2018-03-12 13:36hgbotCheckin
2018-03-12 13:36hgbotNote Added: 0103159
2018-03-19 12:48marvintmReview Assigned To => marvintm
2018-03-19 12:48marvintmStatusresolved => closed
2018-03-19 12:48marvintmFixed in Version => RR18Q2
2018-03-19 18:39hgbotCheckin
2018-03-19 18:39hgbotNote Added: 0103355
2018-03-19 18:39hgbotCheckin
2018-03-19 18:39hgbotNote Added: 0103356
2018-03-22 14:09hgbotCheckin
2018-03-22 14:09hgbotNote Added: 0103429

Notes
(0102803)
hgbot   
2018-02-22 19:42   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 715adcce7ca09cb744dc590670af82a5412cee89
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Feb 22 19:41:20 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/715adcce7ca09cb744dc590670af82a5412cee89 [^]

Fixes issue 37025: add to master data load api the option to do pagination by id

The pagination by id, saves the last id of the current page, to send for next page to be greater than this id.

This filter makes each subsequent page query a bit faster since the amount of rows to work with is smaller.

To enable it:
- set paginationById:true in the model
- add $paginationByIdCriteria in the hql query
You can see an example in ProductPrice.java and productprice.js

---
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0102804)
hgbot   
2018-02-22 19:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 983ec113cf9ebf83af257d4a8f0165a64a987fe3
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Feb 22 19:31:37 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/983ec113cf9ebf83af257d4a8f0165a64a987fe3 [^]

Fixes issue 37025: added pagination by Id to product price

- Change the product price model to use the pagination by Id instead the old one by offset

- Change a bit the product price master data load query:
Put all possible inside the subquery
This toguther with the cange of paginate by id instead , gives half times loading many pages, in some scenarios.

Note: if separeted in two queries, it improves a lot, but in future versions of pg could give worse performance,
Also the number of parameters to the second query could be a problem.

- Fix ServiceProduct master data load query, since the ordering was not correct.

---
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
M src/org/openbravo/retail/posterminal/master/ServiceProduct.java
M web/org.openbravo.retail.posterminal/js/model/productprice.js
---
(0103038)
hgbot   
2018-03-06 17:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b2c78a68579b37f0a9047c45cc3c3f0f9475b130
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 05 11:58:50 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b2c78a68579b37f0a9047c45cc3c3f0f9475b130 [^]

Related to issue 37025: apply review: makes no sense to put this code inside a try/catch

If this code fails with an exception is becasue the json is malformed,
and in this case better to stop executing this code and
control the exception outside

---
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
---
(0103039)
hgbot   
2018-03-06 17:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a8829750a5d93857239a4150334f5e5655ccb84c
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 05 12:02:44 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8829750a5d93857239a4150334f5e5655ccb84c [^]

Related to issue 37025: change BPLocation master data load to use paginationById

---
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M web/org.openbravo.retail.posterminal/js/model/bplocation.js
---
(0103159)
hgbot   
2018-03-12 13:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d10d0c9c982d7e64264fab0da443dfc9a705934f
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 12 13:34:35 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d10d0c9c982d7e64264fab0da443dfc9a705934f [^]

Related to issue 37025: apply review: improve the query of productPrice

Change to use exists instead in, this gives a small improvement in performance

---
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
---
(0103355)
hgbot   
2018-03-19 18:39   
Repository: tools/automation/pi-mobile
Changeset: 30ca38e11b4804e3eb902730a47dba4200068cd7
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Mar 16 14:47:47 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/30ca38e11b4804e3eb902730a47dba4200068cd7 [^]

Related to issue 37025: added pagination test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37025_Pagination.java
---
(0103356)
hgbot   
2018-03-19 18:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 370c7d2734008883ce1a889624a78170bc25d877
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Mar 19 18:37:13 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/370c7d2734008883ce1a889624a78170bc25d877 [^]

Related to issue 37025: fix order by of DicountFilter* models

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterProduct.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProductCategory.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterRole.java
---
(0103429)
hgbot   
2018-03-22 14:09   
Repository: tools/automation/pi-mobile
Changeset: 13bd80f903c6d0510a85c3bbb38e61de59927ca2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Mar 22 14:08:50 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/13bd80f903c6d0510a85c3bbb38e61de59927ca2 [^]

Related to issue 37025: try to make pagination test more stable

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37025_Pagination.java
---