0037015: contention in DAL proxies with high concurrency

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0037015

Openbravo ERP

A. Platform

public

2017-10-05 16:58

2017-11-29 10:34

Reporter

alostale

Assigned To

alostale

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q1

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0037015: contention in DAL proxies with high concurrency

Description

Whenever a Hibernate proxied object is accessed to any of its methods, even if it is already hydrated, a lock is created at entity's method level, so it is only possible to access this method once a time even in different instances.

For example:

  Thread 1
     Module modInstance1 = OBDal.getInstance().get(Module.class, "0");
     Client clientProxyInstance1 = modInstance1.getClient();           // we have a proxy
     clientProxyInstance1.getId();                                     // accessing to a method in the 
proxy

  Thread 2
     Module modInstance2 = OBDal.getInstance().get(Module.class, "0"); // another Module instance
     
Client clientProxyInstance2 = modInstance1.getClient();           // another proxy instance
     clientProxyInstance2.getId();                                     // accessing to a method in the 
proxy

In this example, clientProxyInstance1.getId() and clientProxyInstance2.getId() cannot be executed concurrently because both of them try to get a lock on Client.getId method.

Steps To Reproduce

-Execute attached test profiling locks and monitors
-> See attached image where it can be seen threads waiting for RuntimeSupport.find2Methods

Proposed Solution

This is an issue [1] in the javassist version that currently Openbravo depends on (3.14.0-GA), which is fixed since 3.17.0-GA.

Decide to which version update, maybe to 3.20.0-GA, which is not the latest one but the one currently Hibernate depends on [2].

Note 3.17 seems to be buggy an Hibernate moved from it [3][4].

Testing with 3.20.0-GA solves the contention issue (see attached image) which is the same test execution without any thread waiting.

---
[1] https://issues.jboss.org/browse/JASSIST-163 [^]
[2] https://github.com/hibernate/hibernate-orm/blob/00492a3707b9128b34646166f6eff402a8169011/libraries.gradle#L20 [^]
[3] https://hibernate.atlassian.net/browse/HHH-7923 [^]
[4] https://issues.jboss.org/browse/JASSIST-189 [^]

Additional Information

Tags

Performance

Relationships

related to	design defect	0020515		closed	alostale	OBCriteria creates contention at JVM
related to	feature request	0037064		closed	caristu	upgrade hibernate to 5.3.2

Attached Files

Selection_214.png (78,055) 2017-10-05 17:04
https://issues.openbravo.com/file_download.php?file_id=11139&type=bug
png

DalProxyConcurrency.java (2,013) 2017-10-05 17:11
https://issues.openbravo.com/file_download.php?file_id=11140&type=bug
png

Same-Test-New-Jar.png (17,673) 2017-10-05 17:20
https://issues.openbravo.com/file_download.php?file_id=11141&type=bug
png

Issue History

Date Modified

Username

Field

Change

2017-10-05 16:58