Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037012Retail ModulesWeb POSpublic2017-10-05 15:052017-10-23 14:58
Reporterasiermartirena 
Assigned Toasiermartirena 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037012: Deleted service line is not correctly saved when deleting by an 'undo' action
DescriptionDeleted service lines saved when doing an 'undo' action are not correctly saved. The ordered and delivered quantities are not set to zero, and in consequence a shipment is generated for that removed line.

This happens because the service quantity is set to zero without disabling the services quantity rules, so it's quantity is set again to the previous one before deleting it.

The line removing code must also be executed by the 'deleteLines' API.
Steps To ReproduceEnable the preference to save removed tickets/lines.
Add a product with a service related.
Click on the undo button (the service line is removed).
Pay and synchronize the ticket.
Check in back-end that the service line has an ordered and a delivered quantity of 1, and that a shipment has been created for that line.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-10-05 15:05asiermartirenaNew Issue
2017-10-05 15:05asiermartirenaAssigned To => asiermartirena
2017-10-05 15:05asiermartirenaTriggers an Emergency Pack => No
2017-10-06 09:52hgbotCheckin
2017-10-06 09:52hgbotNote Added: 0099784
2017-10-06 09:52hgbotStatusnew => resolved
2017-10-06 09:52hgbotResolutionopen => fixed
2017-10-06 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80d6e7c6b21aeacefd779d3d0fbbd3be7695842b [^]
2017-10-23 14:31migueldejuanaReview Assigned To => migueldejuana
2017-10-23 14:58migueldejuanaNote Added: 0099995
2017-10-23 14:58migueldejuanaStatusresolved => closed
2017-10-23 14:58migueldejuanaFixed in Version => RR18Q1

Notes
(0099784)
hgbot   
2017-10-06 09:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 80d6e7c6b21aeacefd779d3d0fbbd3be7695842b
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Thu Oct 05 15:15:15 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80d6e7c6b21aeacefd779d3d0fbbd3be7695842b [^]

Fixed issue 37012: Fixed problem when saving a line after deleting by the 'undo' action

Now, the 'deleteLines' API is used to delete the line. Additionally, the services are not updated during this delete process, or the quantity would be set again after setting to 0.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0099995)
migueldejuana   
2017-10-23 14:58   
Tested and reviewed